From: Adrian Hunter <adrian.hunter@intel.com>
To: Christoph Hellwig <hch@lst.de>,
Shaun Tancheff <shaun.tancheff@seagate.com>
Cc: Jens Axboe <axboe@fb.com>, Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-block@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Josh Bingaman <josh.bingaman@seagate.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Pawel Wodkowski <pawelx.wodkowski@intel.com>
Subject: Re: [PATCH] block: Fix secure erase
Date: Tue, 16 Aug 2016 10:20:25 +0300 [thread overview]
Message-ID: <d350c5b0-3ac8-342b-608b-933652c26b65@intel.com> (raw)
In-Reply-To: <20160815181457.GA9781@lst.de>
On 15/08/16 21:14, Christoph Hellwig wrote:
> On Mon, Aug 15, 2016 at 11:43:12AM -0500, Shaun Tancheff wrote:
>> Hmm ... Since REQ_SECURE implied REQ_DISCARD doesn't this
>> mean that we should include REQ_OP_SECURE_ERASE checking
>> wherever REQ_OP_DISCARD is being checked now in drivers/scsi/sd.c ?
>>
>> (It's only in 3 spots so it's a quickie patch)
>
> SCSI doesn't support secure erase operations. Only MMC really
> supports it, plus the usual cargo culting in Xen blkfront that's
> probably never been tested..
>
I left SCSI out because support does not exist at the moment.
However there is UFS which is seen as the replacement for eMMC.
And there is a patch to add support for BLKSECDISCARD:
http://marc.info/?l=linux-scsi&m=146953519016056
So SCSI will need updating if that is to go in.
next prev parent reply other threads:[~2016-08-16 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 8:43 [REGRESSION] Secure discard is broken Adrian Hunter
2016-08-11 14:05 ` Christoph Hellwig
2016-08-15 14:07 ` [PATCH] block: Fix secure erase Adrian Hunter
2016-08-15 16:43 ` Shaun Tancheff
2016-08-15 18:14 ` Christoph Hellwig
2016-08-16 7:20 ` Adrian Hunter [this message]
2016-08-17 0:52 ` Christoph Hellwig
2016-08-15 18:13 ` Christoph Hellwig
2016-08-15 18:16 ` Jens Axboe
2016-08-15 18:17 ` Christoph Hellwig
2016-08-16 7:59 ` [PATCH V2] " Adrian Hunter
2016-08-16 16:15 ` Christoph Hellwig
2016-08-19 11:52 ` Ulf Hansson
2016-08-19 15:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d350c5b0-3ac8-342b-608b-933652c26b65@intel.com \
--to=adrian.hunter@intel.com \
--cc=Joao.Pinto@synopsys.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=josh.bingaman@seagate.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pawelx.wodkowski@intel.com \
--cc=shaun.tancheff@seagate.com \
--cc=ulf.hansson@linaro.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome