From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D5923D8116 for ; Tue, 21 Apr 2026 14:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776781993; cv=none; b=lF83qKt4GDPFhHkxD+T2TxVHwiXsUzjG/2Yy/4KCB/K2lcT/siCACnEY6eoMRQWLToZszy0w8oTFD3T9d2vDMq1BnoehOph2b56XSzj9Az7RAZ6NnVND9FcbsY79Qt8JQ0vmPoOWyf93QG29hF3yEko/LpFeVyk/uWXRKAwXU/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776781993; c=relaxed/simple; bh=IHRvS3C1jeZEyoYmpFk9W8/Od1wo6/pY6I19NPtYnYk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P3f3TcFBltRn+FesEXgBWB5zxRWiAKJ/lNygKxtJMeCtez0Tix0yyIJpKAcnP53eQkThTXUcvxhJvf2XfXMT4CKz2TYTvrzbXDW4Xq+cbKymhHkY3axDvHu+tg9EvweMZxTjbeA9ECoqj+Yz9dtkZa/OFsxEiRKx9qiFjqnWKAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nXpvdFER; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nXpvdFER" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43d70c30767so3091678f8f.0 for ; Tue, 21 Apr 2026 07:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776781990; x=1777386790; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I86X5f7o1KhxjdDA+yrUKD5IZ9a2fkcl2651mUvpB2I=; b=nXpvdFER/OhwcnXMfQq8af9GCjkxKH4winTg0zM2fmCAeZ/ww2fA6BlZJm1Faap2ye G+het7+WI4piQUP5A0SamWz1orXPPMToRydfUAsQv5vsF6IbtEPmL06l4Jrc+96xFSBu EmQRFKoBzj2hxJBNaNHAwWxnYzsB67NGWcuJDfhj3POa1dtzbQ5LQpQW0L/k9CgNv28U ygdfPAes680JdwslRsUZ87NoeSOV1HbTchZQq11PItb6n2B2ou/DAAwW2yCn5dfVfCnR qZ3NB8M09VP4M8OxDqivx/wcCQPwRv1QwNQsqc2+fAJtsVi3FPHXKebmmijh23N0bcXV Zqeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776781990; x=1777386790; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I86X5f7o1KhxjdDA+yrUKD5IZ9a2fkcl2651mUvpB2I=; b=VJellnKdkhHUyJm3WC1MfpLaM/QYITeE9u5EUeYNCbneRQpzmVVwLO60PHQ2+m/XvT NgOlIsL7Zdb3HXM4JbBygYPd+YXl8X/xOrDT1DF7FCyUyVMNMbirKI2Nz1xtd/Mwhqx2 IfGUlw0FfNvyUD6ghDqmnBrgJs+PdcEtF8pZqMR+uopz6hMlPoqHqP0H9Y2dKX3dUaBi cpLOoaRhwzU89c9ZI0Dg2/Ja/CiA7Y/APiBL+X5z8vqsBSPQn/TyJ5CnzDhvpiR/GDAd 5K4Gm+TOHEYmfvKId3+9MXM7ygRveiyflp7o9bnZqNGN7Wg3YfgtXZr85i1LPPyu9uVu Hghw== X-Forwarded-Encrypted: i=1; AFNElJ+7dLYIdJqGfQdSKEKSqrrF/qb9wzlDDf/l9HljdrGtuaHvBBnHMkAf5mE6kxTg0HZt7mNj7oWT1gGyO5E=@vger.kernel.org X-Gm-Message-State: AOJu0YzfZiB2TyY47rEgDVV8JAt5j7N+DKP/oQjsY2XXdytbtWM4jkMe CVPmMGsdA3o6lxtkbo1AN1j11bpkfZepeGaq5vCTd0Nms1GIFLaQYy7hqJ8ItooJGkA= X-Gm-Gg: AeBDieudF7tXqiC1dCkzJkZFPb+MMfnaircZ925zLCDX6jfjV9mgUsw8VdNUwoFU2eP L6NlBFHEhjeDvOmBSfiBrSFlOCYCOqGRs0uxEzz+qqDOBFOgr4FWIo7xYz/LBLkLqKKC+WT5kQt 4vDmsoqLH+yWRVm98rzENgrHYfXeAyJFc6umvukCqaSMy0l7Q2aUBy9EV/aG2SjinRoA72xqcc8 IM9ZOj0AAXFWV8Ofx9vm0Jac1w8t/iT5Q4VGWo9SnuTwYAgsS5gvNpGIegUoZeHClaKfJcRsJD9 7KaYZSM+AtMWg92TRWOJYij9BPDlwwueS+MpRHwtC7qiXrG2qXDJEjAG9zrHhLtqyfFMSSZbEWh w5ACprEdvMIvOjCmTBxPCXn+8hIxzFrH3jlW7XrzC1mPTzFmy3xmSIBS4Uqo2IPuK23QOSrm0fJ l7kjivHsAU7/Lrcotpm2pwIXtb5cSKHhj1gjFkNFbn3lE= X-Received: by 2002:a05:600c:33a4:b0:489:1abb:5559 with SMTP id 5b1f17b1804b1-4891abb574amr73260305e9.5.1776781989776; Tue, 21 Apr 2026 07:33:09 -0700 (PDT) Received: from [192.168.178.64] ([84.246.200.167]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f82bbsm621187595e9.3.2026.04.21.07.33.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2026 07:33:09 -0700 (PDT) Message-ID: Date: Tue, 21 Apr 2026 15:33:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf build-id: Fix wrong return value checking To: Namhyung Kim , Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org References: <20260420180858.129075-1-namhyung@kernel.org> Content-Language: en-US From: James Clark In-Reply-To: <20260420180858.129075-1-namhyung@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/04/2026 19:08, Namhyung Kim wrote: > The {sysfs,filename}__snprintf_build_id() both return the actual length > of build-ID. But in their fprintf counterparts check with sbuild_id > length which contain a terminating NUL bytes. So they cannot match. > > This resulted in perf buildid-list -k prints nothing. With this fix, > it can show the following result. > > $ perf buildid-list -k > 9524074000cb36cf2559a5b52f0555dab47da553 > > Fixes: fccaaf6fbbc59910e ("perf build-id: Change sprintf functions to snprintf") > Signed-off-by: Namhyung Kim Reviewed-by: James Clark > --- > tools/perf/builtin-buildid-list.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c > index a91bbb34ac946360..8ad39ff9a4b8a4b4 100644 > --- a/tools/perf/builtin-buildid-list.c > +++ b/tools/perf/builtin-buildid-list.c > @@ -61,7 +61,7 @@ static int sysfs__fprintf_build_id(FILE *fp) > int ret; > > ret = sysfs__snprintf_build_id("/", sbuild_id, sizeof(sbuild_id)); > - if (ret != sizeof(sbuild_id)) > + if (ret != sizeof(sbuild_id) - 1) > return ret < 0 ? ret : -EINVAL; > > return fprintf(fp, "%s\n", sbuild_id); > @@ -73,7 +73,7 @@ static int filename__fprintf_build_id(const char *name, FILE *fp) > int ret; > > ret = filename__snprintf_build_id(name, sbuild_id, sizeof(sbuild_id)); > - if (ret != sizeof(sbuild_id)) > + if (ret != sizeof(sbuild_id) - 1) > return ret < 0 ? ret : -EINVAL; > > return fprintf(fp, "%s\n", sbuild_id);