mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodolfo Giometti <giometti@enneenne.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Marek Vasut <marex@denx.de>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: add reset timing properties
Date: Mon, 5 Oct 2026 10:35:47 +0200	[thread overview]
Message-ID: <d352287f-156c-436e-8fa5-b203771a6a84@enneenne.com> (raw)
In-Reply-To: <20261004-transparent-cuscus-of-honor-8ccbb4@quoll>

On Sun, Oct 04, 2026 at 09:27:04AM +0200, Krzysztof Kozlowski wrote:
> On Fri, Oct 02, 2026 at 03:55:41PM +0200, Rodolfo Giometti wrote:
> > How long a KSZ switch needs before it answers on its management bus
> > after the reset line is released depends on the board it sits on, and a
> > board that needs longer than the driver waits has no way to say so.
>
> Not completely. This is implied by compatible. Individual phys/mdios
> have their own delays but not the entire device.

I see. Honestly speaking, what I measured is the switch itself needing
longer after a long reset: 95-120ms after a 10ms pulse, ~160ms after 1s
held in reset, on one board, while a second board gets through the same
sequence in under 100ms. So I cannot tell whether the difference comes
from the board or from the part.

I will drop the binding patch, then. For v2 I am thinking of keeping the
fixed wait and then polling the chip ID until the switch answers, with
an upper bound in the driver, so that no property is needed: a generous
bound costs nothing to a switch that answers early.

If that is not the right direction, I'd be glad to hear it before posting.

Ciao,

Rodolfo

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming

  reply	other threads:[~2026-10-05  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 13:55 [PATCH net-next 0/2] net: dsa: microchip: let the board state its reset timing Rodolfo Giometti
2026-10-02 13:55 ` [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: add reset timing properties Rodolfo Giometti
2026-10-04  7:27   ` Krzysztof Kozlowski
2026-10-05  8:35     ` Rodolfo Giometti [this message]
2026-10-02 13:55 ` [PATCH net-next 2/2] net: dsa: microchip: take the reset timings from the device tree Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d352287f-156c-436e-8fa5-b203771a6a84@enneenne.com \
    --to=giometti@enneenne.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®