From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A95BD411A13 for ; Wed, 29 Jul 2026 16:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785342101; cv=none; b=ulLWh7/oiOTFG2+Ed6FGcRCJFkFAlGpLJ2k4uXPcq7x+8kVAKsN33XixaocWcv2XwTWcQ/ueP7j/xTBR7VoW22wizt0pbhm2Q8lOdr7yW863gQJ3FLzc1HFMxf1y5lo34A26GOWp526PiGlViZcDz3pOfSYiSxcEImM20KP3gg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785342101; c=relaxed/simple; bh=J/dPtV4qOEHFqIZhA5/7ElxHINwksvuDwpgYPO9xLGQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HWjlZlf7P5stiovMRR+jaQC3liZhBMp84D6uIwpNGkHGTOXG/bw7SoqDw5KaN5UD39UiT71vAVxmzYHvJFKleiieyzc5kqxUFZmYsTmNfNUz2EH26cpmweISu4uzRIqbfEXA1nugnMGm+Nl+vQpNvVcjTfOl/932LeNPDYTeHWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XcfE7dqM; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XcfE7dqM" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c998fd549a8so781503a12.2 for ; Wed, 29 Jul 2026 09:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785342099; x=1785946899; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=MGJ04DPjDp5NhuCKplYWqLlAi7JvCa6BgyiKARstS28=; b=XcfE7dqMdujD4xU23tLmnYF/iEGquvd6C7kOqZ8ZqJeBH+em6QJFl76tOfbTURUxot YJ7RWusRIWNMaYruaQj7o3awqwoN48Aj1cNIlZHZzZfVcf5TRYpM/edc1tBBZYedv37R hVPUdC87WujRa9u8ijqycZ8+ocm3MW9Ve9d3qMkbF+dOcJCfKOqVsM6dlPQBLXAJ0bTD 9DuMRFSSh+guIDXpcJnW6NfTAqpyrsqEFG8+O8WVJX+SaLviADMLBhsiFT+uB16C9vbl I6HIniMJslX/exz3U90NLGNI++T8dz2PW/AwrCDx/z1fQZVdarosRAMv+nFrYfnUHobj r5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785342099; x=1785946899; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MGJ04DPjDp5NhuCKplYWqLlAi7JvCa6BgyiKARstS28=; b=MSJuK3lp2ZcbZ6qpYH5c9P4BL65BrEffLJBh/TrtcqySp7fTujcHFtHrVKInFwZv8P MPtIUAW6nxgiUyJjfJDdFqX8yc+1UVvF+AUR8zLvUVQ8LC6NXiV1KH2f6rstrKCG+nMf HsiT8A/HTTwcEjy/Xj2gg0zGy+pHZsGEqWY8cnkIdrbcoUAQTVI5zD/EUEjgbPWLtfrw uPvW1c0izzw/Ua52Zl8s/6sUlUb/gCJqLI/O/yPZjT5HQTDfa1FurqTqJ5foJPfFCHUB o9xgoucdkgjueeXt8V4wXrD3AjzfH/I1pV8vGlZwghFaSeA0G8niNkMspfneVaZLDQWf AvJQ== X-Forwarded-Encrypted: i=1; AHgh+RqovOAlmLozV8wTaxgbT5WnYw/1VXczk+Q63dC8jAHrSbL/3Vpx3KhR2bIMpOmPU55JJ7COFetDaGRQcV4=@vger.kernel.org X-Gm-Message-State: AOJu0YwuuRMCvwCDqteeY+kMHT7QuGnqcpxD5Cuj42VeeY/zQTIfNfPN 6TOpXEK/WnIyu4nUNa0TCke1mBqCNQGMV9hjHoic8ueyX1EEIyB0x2Gh X-Gm-Gg: AR+sD122PQJYbJy/INC7udMEBxEtR0vNz525HFOtGinuCXsImAOuy/SqOa/TbzGodLh QsAgXWcO7aWwaV7N4diYlVkNxbmw7VL9bo3tlyAs7lmVt7cap4eI3nulnioCgpuGzyMs21wXdp0 NecSnucOstAHncQHEArnr0blI6wcorf9ngz3IM2DpoPz0yg7aDUqtkDJNvrDQGaNo0r72pkQQZ+ RxVMaRINzwp8GahzbVf7SAhdwcJoijglITrl+hUFr9jx79oAIsM3OLXcgPl6xALlrtzP4dSLohH IO9JzcWSiACv7z8HSwSXFySwpV2lD2JMQySjzvfJ/Xh0Efw7zwL2q6MuSHfzXgVygRfD+X7W2Mc 7iG6x3fFhNiWixAaCa/pSNyyKxbZT36f+7Bcy3QVlwu8lYBwumMHmZfRKylAMAsHF+TWWOAb/lS ORd8l5SqtW4Mz6dObNdjer0ZNRfuMP1bnbf7HtuUYGyvL2aq96s20sQgymQD2M2eDy/QIRTRD43 Q== X-Received: by 2002:a05:6a21:7a82:b0:3c3:994f:b4f5 with SMTP id adf61e73a8af0-3c8ab0db549mr8766339637.28.1785342098975; Wed, 29 Jul 2026 09:21:38 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504db2c4csm11392516eec.28.2026.07.29.09.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 09:21:38 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 29 Jul 2026 09:21:37 -0700 From: Guenter Roeck To: Hongyan Xu Cc: Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , openbmc@lists.ozlabs.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, jianhao.xu@seu.edu.cn Subject: Re: [PATCH v2] hwmon: (npcm750-pwm-fan): stop fan timer on device detach Message-ID: References: <20260729100116.790-1-getshell@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729100116.790-1-getshell@seu.edu.cn> On Wed, Jul 29, 2026 at 06:01:16PM +0800, Hongyan Xu wrote: > When a fan tach channel is present, npcm7xx_pwm_fan_probe() starts > fan_timer. The timer callback polls tach state and rearms the timer, but > the driver has no remove callback or devm cleanup action to stop it. On > device detach, the devm-managed driver data and I/O mappings can be > released while the timer is still pending or running. > > Register a devm cleanup action before starting the timer and shut the > timer down synchronously from that action. > > This issue was found by a static analysis tool. > > Fixes: f1fd4a4db777 ("hwmon: Add NPCM7xx PWM and Fan driver") > Cc: stable@vger.kernel.org > Signed-off-by: Hongyan Xu Applied. Thanks, Guenter