From: Paolo Abeni <pabeni@redhat.com>
To: Tom Rix <trix@redhat.com>,
shannon.nelson@amd.com, brett.creeley@amd.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pds_core: add stub macros for pdsc_debufs_* when ! CONFIG_DEBUG_FS
Date: Tue, 02 May 2023 16:57:16 +0200 [thread overview]
Message-ID: <d35637b26f7d5632f221e337dca2bd12c5008b86.camel@redhat.com> (raw)
In-Reply-To: <20230502145220.2927464-1-trix@redhat.com>
On Tue, 2023-05-02 at 10:52 -0400, Tom Rix wrote:
> When CONFIG_DEBUG_FS is not defined there is this representative link error
> ld: drivers/net/ethernet/amd/pds_core/main.o: in function `pdsc_remove':
> main.c:(.text+0x35c): undefined reference to `pdsc_debugfs_del_dev
>
> Avoid these link errors when CONFIG_DEBUG_FS is not defined by
> providing some empty macros.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
There is already a patch pending on the same topic:
https://patchwork.kernel.org/user/todo/netdevbpf/?series=744165
and probably a different approach will be preferred:
https://lore.kernel.org/all/84bc488b-5b4b-49ec-7e1a-3a88f92476f6@amd.com/
Cheers,
Paolo
next prev parent reply other threads:[~2023-05-02 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 14:52 Tom Rix
2023-05-02 14:57 ` Paolo Abeni [this message]
2023-05-03 7:36 ` Jiri Pirko
2023-05-03 12:32 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d35637b26f7d5632f221e337dca2bd12c5008b86.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®