From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932090AbdEFIpG (ORCPT ); Sat, 6 May 2017 04:45:06 -0400 Received: from mout.web.de ([217.72.192.78]:58676 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbdEFIo5 (ORCPT ); Sat, 6 May 2017 04:44:57 -0400 Subject: [PATCH 07/10] dlm: Use kmalloc_array() in make_member_array() From: SF Markus Elfring To: cluster-devel@redhat.com, Christine Caulfield , David Teigland Cc: LKML , kernel-janitors@vger.kernel.org References: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> Message-ID: Date: Sat, 6 May 2017 10:44:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:GKtJGH3Je4IcqS5wX2RJ7Yb2XnRUD6aD+s3sea6tdPw4RaKDb7J 9S6gFf8wxXYn3OrVF7r0VDDqyg9RIDdMlNg67AODKvGd78um2L+INjG0FAFrYpR5XgVNR7/ YLVqDk6TGqZabBpNcGRgKrMvvrmi3TjPy8f31uapRZqm8ax49pZ1S4vWyELVnxcMR8zMlbm qqm18hegon1nq0LbMpFIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:MHU8nPd4zw4=:6G1WsvFYVtGODrzOFuYA0j oIaTon89NvjrsEvx3n3s/OlcV9BErtv+shFUiGQ5qsVUOjewgAq8f5Lk5LU9jrvPzkEnSmb+A sx6rRMVOzB3ZRxYGq7pqnenAEcoxWqXONrP2tURR4rdkm3xeun5ffGUBPn7rvZ8bMwEH6BYHB zwmnmQ9omFO0fXlqTxx4oV/M7wlLfyliC84p/ejSzqUi1P6SmQWBbxep6kbySdM3AD5HUUvch nTFUJsOknj5C/eMDRmuzfufU+7Mg+l2B0Ajb2po6PKCX3CJbK4f9Wra0amJROdA5Kl5EPpvhw 3y+syChvoHNNGl1GmwpBjnLXDPIuo9mLyiarayGTQMCfb9bqZ8dnBGQV1vq91Tv6c4tlXYy4n 3bVm25tm7ChRpcpmp4oKBsrIFqscYQ6E+teekJ1gWBvX3leWA91HkOBaAmgy57fos0w3GyPPK YyPtmVo+PR1Z7A2fGFvL6NJ/+m3f8PAQMeTtKjooG6brInogPUK0OHYDzQTOrcSnqX/As9+T4 9oerAFUZVIlGC2KK7njipDgOiTzG4PRgbK2qTPLbBT5jv221yVArzCZCAuqEg9RpLmDEv+fuT cnbeFVfT3be9wnrEG9YvBtezpdMr0af3nOGciUsKEqKaBTT9UutGxdrOOuCeSS+csijQShyNx Bqo4pxsH8QP3pLUXjBgUv6LsaA43rN9Z8yEGh7WV85T8CuTosFg1p6MbG52ZPvMcklYz+xeeD hqWZiSnt7x8/CM57uKwCZeKBU+LIYvcaEZT/SMvJ44COZDxz3zzy7Ku49z9ZUZA/FqbaxhgN+ FFhKF1F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 6 May 2017 09:19:17 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- fs/dlm/member.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/member.c b/fs/dlm/member.c index 9c47f1c14a8b..89257699d4e4 100644 --- a/fs/dlm/member.c +++ b/fs/dlm/member.c @@ -405,8 +405,7 @@ static void make_member_array(struct dlm_ls *ls) } ls->ls_total_weight = total; - - array = kmalloc(sizeof(int) * total, GFP_NOFS); + array = kmalloc_array(total, sizeof(*array), GFP_NOFS); if (!array) return; -- 2.12.2