From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42C98372060 for ; Tue, 23 Jun 2026 06:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782197448; cv=none; b=okTEUHOjr7md9usvOy4eQDpDjpqnlUHvkaTE77eTqmh9jT286vad4w6XxcwEyL/D5ueeUeUbgzdAtyc0rAV+wNunbnPF9N0Nm3aLE0N8KEhN3anLALxaCI4as1Tic+GTyGFX7T4lAHiHlaC6q2Twerpkjqz+4XnnxtJcFVO039Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782197448; c=relaxed/simple; bh=IXnObPcxfklEGW8mwyqDrX78VJ2H0BaeRxGVGXBSLcQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=azjhjuN5r1wXo/orSxAstjdQfmlUz/j2K3lpkaRMIQPeTC+OqyKNcy/IX4Gy+dThex/F4BR0OUqWGZwW9Ibk1gaZbc/VlP0x7xvf0cmNYjrYMKgZI1QdoqQ6H6N01MX5GGbFBjDXD/AZcgaVsXyFuCBFFsNTIAJSDiGVhzlol6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ReJMtsRL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Eft58Kl3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ReJMtsRL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Eft58Kl3" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6cjYO3338576 for ; Tue, 23 Jun 2026 06:50:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pCGeBjnOWqNN9uSHgYauVx8wOhwLSN9S6EVRONnx6SI=; b=ReJMtsRLIDDkoqnb jsMa8zCFkWa+0sxUBghR/QadO8hS3AMqhw2m30iig/dIJy/idMfoRrHN7BytfmPq 5szeZkxxoFWEENQQZuV4kDTSvYwwuktFow10bD0FR7fsoHpCgK8AnRs2H6Z3uzx7 SF7s6VQ6yKYwFLH6+e6H64b8mOZj6VUpgayji0dRBnEZ7gQ/1FrrcLNVfFXYcHIm 1bptvz3oySWxuz0zZ+yy6o4eHupma+SpkJ9mF522kifyOzoM2MxEMUnQGfftoyEv hKl2D4YTYsQqYQiE0FPyFTSMhHpZyvuBweKoyWDem3QX5DM6/KFdDV+4b8TBHHhX tijVfA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eygkjgy3g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 06:50:45 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9229581de9eso27906085a.2 for ; Mon, 22 Jun 2026 23:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782197445; x=1782802245; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pCGeBjnOWqNN9uSHgYauVx8wOhwLSN9S6EVRONnx6SI=; b=Eft58Kl3bCchzy7YG5jeEF9ahlZ3Dfkqe03Q/2jH08ZWtEp8TNfEEbv8iVOm2cFos+ e6bxTSPPiZNBG1xdVkyPN670d+/v3SNXnQVmC0Se4E2vN30GlsDk04bZOYnrF1Aubi5B /3Zf7ptu/xd7Ii7MNjcWjEAJEZOHDXtqx0/Vp9+y0YwzJ1UIp7qcCWMUJqYp9WbkIurX +aLlo8n+ulelp7QCNSH7q8vXzVytkVOUcHdx0QAUFtOVLZntKLv2rROCXlm3MaCz4VO9 yRCHpiRDlqC4yIxUThltcibd6sc4NvMq7WyhxpEKODoTZw7NpgddFrhGpp7B1tj305lV 3ajQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782197445; x=1782802245; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pCGeBjnOWqNN9uSHgYauVx8wOhwLSN9S6EVRONnx6SI=; b=db3ICukkywKcKYrnXuviQKuj7MPb3krBnRbWEhhgoNp8vYDgod0Bu3Z0GfP0/vWEag q0h6FP/coa/58UbDhZXw1RzjnubQ/ht41TDfzmCIm6LiltjQnop/Ix0g6xNVTIAhb0O6 a06H+h5dz5KxSLUO/xy+xzYyAlzXMjyV0NYPlr0rH5NbbfTqFZkbtSAFhDrGQKChfydh a/7vO5gQ7z1HhOYtykyG983dzdI2eWgue7/YUDQpNbi+j5I9gx3h5Rp/Pfo0keirku// HZbiw4k2LpLK8bfhQXfPxtkZ4rPGMe3oPukaZ3ucOsQzcxjm+4+LJd0UmHtkJgXyyMKF T9kw== X-Forwarded-Encrypted: i=1; AFNElJ+rja3fMAb9sWzPsEPY5RTkAXTTAJ1b4vyGXWgehv3fRb1gcO2LQg/j9eoL5dg9pRvxXyUdxi8+csbzHAc=@vger.kernel.org X-Gm-Message-State: AOJu0YxmCstTy8ta0W+E54n26q32DbWGqCu4Wj+RvcqyCla5ZEPR6eCe QqsG5f6OTHH6YNzSrXBvLvZEkmztscFC0qRFIH7+eeUNYaK7kwM+oOOeQLzqNL276+Kwpu2VgKl VlkFkAi7AtVuTTahoJN5MwP2kxHm0kzskCAEIj6HQKHj0m6mmdyadM4EzveTdN9Fmtt0= X-Gm-Gg: AfdE7cmFATF0vUE74UmCiTqO2R0QhUHhnF2jKpFmoFz+Egxj91Q0snnw5ImQ8gPUY9S twoOqD9RQnZSeel8VbVIoGTIZ9ejyW1qB2qH2017GvSc3HBXNF8pG/S3u6sr45P0oR3i3zTIFPa ttMbVvFoja2/IHrxXl6fZdEz4Mgrqyh5rXalrLQXDxWrsoRNOhFRRmAkp4IPfV4UIPuQq9D2p1T fR6M7iB0tea6AF0vkMWfZDEXYKg6F2CXA5GdyjEkH1gg+48X7G3S7yJD3eNc1g6NNUGZmxUDq7G s9oISDAgdsUyEJMu7y2d73Ccz1veNe5WGcx/e+pDaepAlyTCxHmrxfzvx+L3DD0uIBBJDRvL/Tw K3adLPN7ghzTcC1PeLr8Zzgf8UXXMzGZmc2Y= X-Received: by 2002:a05:620a:6cce:b0:920:6579:bee8 with SMTP id af79cd13be357-925c6f59e85mr431192585a.1.1782197444541; Mon, 22 Jun 2026 23:50:44 -0700 (PDT) X-Received: by 2002:a05:620a:6cce:b0:920:6579:bee8 with SMTP id af79cd13be357-925c6f59e85mr431189985a.1.1782197444022; Mon, 22 Jun 2026 23:50:44 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e998decsm459177966b.22.2026.06.22.23.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 23:50:43 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 08:50:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 To: Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260522-qup-se-increase-ram-cnt-v1-1-71854d0b2ef0@oss.qualcomm.com> <09fb9e91-2585-4cb5-8bfb-92df304e9d6c@oss.qualcomm.com> <5363525f-9440-49bd-83db-242a7ed4e15d@oss.qualcomm.com> <9e57f91b-8f80-41d4-b50f-31c900cb0fd0@oss.qualcomm.com> <79520895-f584-47e1-8206-3b7c06b759d4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <79520895-f584-47e1-8206-3b7c06b759d4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA1MyBTYWx0ZWRfXwmCSqhnC5TR0 kPQ1Rg1T9fxDJYzSAZVMkLcm86tKF1a690Yok2XY+oT6paaHmORben3bWD/L1MG023+aUjVWhc3 GeMFHKgEGb5ax6E/FLYRDo9mBImcsT+40l/cP0bUKp6iAXWil5RyQ8wdipITJBQ29tn/SCgb/a5 Y5aUmzSVoCk2jWsSxNiTPTkpWnVOJXqHtTO4oZ0TPTPOZYX+K43xLJ05yAFyjEM5KjO6N9bARUE F2RBrky9JXKu1YQZrKQn59627y8bMFNvyfZ3SVBrONvku9u49MXuFGyM9xJEe9swPzyqfXoSQLm FfxsdUTQlRLzN49NC42j9s1vfILkCQqV5QBu2eb4AdiaBDh3CRytodzYSTWj+XUJWomwlFlMH06 JhVuSprD8pZAATNK1OOi2t5AYGjACxkU0awZg0jIIJUsvMzQlOpNjw1KuOgC6pE2qSEbMGrWp+7 WDySY1GfrIUylg5Kodw== X-Proofpoint-GUID: VSWx3ImSjW4GlMD73AsAPZ7ipf6xwOT- X-Authority-Analysis: v=2.4 cv=SoKgLvO0 c=1 sm=1 tr=0 ts=6a3a2cc5 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=Knb7rj4zzsAo1unsQiMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA1MyBTYWx0ZWRfX28KRw7mtRKtu vtVfNyE+FILK6o8MWDbLDd2AVKBqV/GtoIKEBvsg6ofuCrmvzYfmZkEQUAHoR7rgivRQ4OV0pzy XTMFDiU+4cbbtEujJztnoXZUVduYbUQ= X-Proofpoint-ORIG-GUID: VSWx3ImSjW4GlMD73AsAPZ7ipf6xwOT- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230053 On 6/22/26 7:15 PM, Viken Dadhaniya wrote: > > > On 6/15/2026 5:30 PM, Konrad Dybcio wrote: >> On 6/15/26 2:00 PM, Konrad Dybcio wrote: >>> On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >>>> >>>> >>>> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>>>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>>>> entries, causing incorrect bounds checking and preventing firmware >>>>>> loading on those targets. >>>>>> >>>>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>>>> limit and ensure correct handling of configuration RAM regions across >>>>>> GENI-based SE blocks. >>>>>> >>>>>> Signed-off-by: Viken Dadhaniya >>>>>> --- >>>>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>>>> index cd1779b6a91a..d0810960f3da 100644 >>>>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>>>> /*Magic numbers*/ >>>>>> #define SE_MAGIC_NUM 0x57464553 >>>>>> >>>>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>>>> >>>>> Is there any SoC where this could overflow the register space >>>>> (you say "certain Qualcomm SoCs")? >>>> >>>> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >>>> entries, so the previous limit could overflow. >>> >>> What I'm asking is whether the size of the RAM on any of the SoCs >>> is less than 455 (the previous limit) >> >> *Less than 1020 (the new limit), of course.. >> >> Konrad > > Yes, some SoCs like kodiak, monaco and lemans have CFG RAM smaller than > 455. But MAX_GENI_CFG_RAMn_CNT is only a firmware ceiling; the actual > programmed size comes from the firmware header. Talos needs ~650 items, > so the old 455 limit rejects valid firmware. Raising it to 1020 fixes > that without changing programming behavior. OK I tried to find whether there's a "ram size" register to limit it further (i.e. have a different upper bound for different platforms), but there doesn't seem to be one.. unless we can deduce it from the version register? Konrad