From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 305C72512FF for ; Mon, 14 Jul 2025 13:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752499802; cv=none; b=PB/JAnBqvLi9bnj2JLJdp/OSaAqURrwt9kyNvhAkrsO7q1vFhm5a2Bl2u3EEVx9Fmtecx3QyKE+A8Zs3HQi89ltZNCa3X4qa+1+h+rtolsdeeq4e6Gap14j0iHpa+wVpeWMGrBZpfv5P+ZD6ypBfopRZn5KhTuJh468ZO/BfK4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752499802; c=relaxed/simple; bh=3uKXuWP37D0CEeXXM1tywrvm2McS8VXMhZeTn28VHoI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jgjjAXIAoZuPjgdbSrnlhBD14PxjO07VSooDKMJcKjPY2r9ppc5+3LvMP2/D9Yc9aeHOFqw8pyFLg5FuiTvU6txjXOMCjnri09Mata/ngx0TjKs3SSB74Yivx4WdqkvQU3LhMyIxl+TucBe28/Q55FRA0+l7s/491tRuHK0SkIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ni27Lgie; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ni27Lgie" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56E8GL12007737 for ; Mon, 14 Jul 2025 13:30:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EwocCM6XUaxUM6zqzmqtMLsjRln2ZwRH5MrCIvcpmqQ=; b=ni27LgiegFlY/Rqd 7oocgMbfgVrGrmZLlh1wU+5fWe5lXdhnbpjBjLfspfNAvACzfPxjBDG7UJSHkVZs /p8Fb2FeDKLIq/x/54voDnw7RDbpboVEDnftVbB4E4Kb2hiqXd3LMRZDFVHPRf/1 XZ89NbHnIfBMovimnGzgkobXxU4Pe5FRELVz6JAiTZsNY5QYRnOF+asOWCQu3v1k h8MbmNIf23va0W4Zi3h7wMI48cUCLac/m+feu6lHP/SCfPeh/OmN5AM9HhDK2Sft bapFm8gRZxa1kqQtkxYkffuQuyQI9G1P2cNHoF5wzhZeK3ysHiVBxOBpSy9dAbPj KAOO6A== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47v56a3bq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Jul 2025 13:30:00 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7dbce38d456so84037185a.0 for ; Mon, 14 Jul 2025 06:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752499799; x=1753104599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EwocCM6XUaxUM6zqzmqtMLsjRln2ZwRH5MrCIvcpmqQ=; b=SBWZoihZvQCuegCIGdSopZ0KZuC2sGepcWVLhc1VNawG2+zFYntfXrailhH87YVPY0 HyLWxfgBIhhWMVn/X9Jblvi+x8zqYt4XVB+pz3Dqn0JrrsDW6dxp5ufi7kbtwKKTiGaX 4BjXf9lYHarV30DhxjuZWgMz9WPEo+2uQfP4I6NfOPX0+aMutVCkoCjg88O0b20ysga8 lj3lkln0FPYZLKFx+qg1BBs/IT7K5jq39nOOHdf1h1hhrMCQLA2LkWBrUdjxZxxKt6AU 1j12yn/n2BQRuqRCMn8sIh1kujv7SKebsN8bi7KMT9JR46BAe1kSHC8edwWQfZIgUdkr QEJw== X-Forwarded-Encrypted: i=1; AJvYcCX0jvOQKJEqlthNhQIPl6llF5xtF5DB7Uo7VfrDVobNUD2nAuyssroDf4U65VdbylHjQqREp9T7j2EVqvs=@vger.kernel.org X-Gm-Message-State: AOJu0YxsxM5rFsrDfp0jO5+Q+oHHilb7Qp4RVOqwARYosMzXr7j0OXvY Vzx12O1SlStG3yT5N66WYXqcDrXXZmNZdObXSxvuRpbpIuhoyoIObtZKdnReGbucu2nwCJZrnPq ix8F/qzYzjIJDHIF9sYv4gtEuOUZUijLCwrvXxWzge0NjSPopajZ7vGSFDddW1Gct0P8= X-Gm-Gg: ASbGncvvWwS57TlbvdVNJs1TKLw5WRpmrlUpiCmiQe4SluSkJtsxcnN64JMVvQ5B5jq DzpMncUiXjaVbCnlkofv0kHF+sSvnnxfdI10sJmwFbss9B9bMZjknotF9Bv2A/kKfP9RZ/2Dvi9 DN7ymP9aKLGOjIdJQephzesYgEoYy9uKrFuCwIXXvKBya056upRZwmVm3ueLgDCKrddmXHzIhqb Amnm1KlYxr0I7HyEAY9a5OPFfLwyxPUOWjIWnXpvumWhJuUC+UmPUapyiUK7XGCqV6OdqfTHIBc /miQx/CGPHOF4YdRm933x/lmoAYTdGIIiJf8JfacwK+aKXE56mdlxrHCdLvx2lynMsYUgJylXwU feJlqJ8TEdlycmNjL4zqB X-Received: by 2002:a05:620a:4712:b0:7e3:297d:ec32 with SMTP id af79cd13be357-7e3297df03dmr166521585a.10.1752499798875; Mon, 14 Jul 2025 06:29:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4pVl04wh4MC/yMhCnGpjY5MlKKeWfA0cK5VDPj8AHG8h6eRZW2+HItMHeuT0gOF1TXD/tzA== X-Received: by 2002:a05:620a:4712:b0:7e3:297d:ec32 with SMTP id af79cd13be357-7e3297df03dmr166519985a.10.1752499798442; Mon, 14 Jul 2025 06:29:58 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e91c81sm830369866b.37.2025.07.14.06.29.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 06:29:57 -0700 (PDT) Message-ID: Date: Mon, 14 Jul 2025 15:29:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 12/15] arm64: dts: qcom: x1e80100-t14s: Add pm8010 camera PMIC with voltage levels for IR and RGB camera To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20250711-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-0-0bc5da82f526@linaro.org> <20250711-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-12-0bc5da82f526@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250711-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-12-0bc5da82f526@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: rcX6RIlLBj-ZuElnDdXUL_aPo9Nm_DOf X-Authority-Analysis: v=2.4 cv=X7BSKHTe c=1 sm=1 tr=0 ts=68750658 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=KKAkSRfTAAAA:8 a=tqOywgo3-Srlss81Y0MA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: rcX6RIlLBj-ZuElnDdXUL_aPo9Nm_DOf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE0MDA3OSBTYWx0ZWRfX5qOQ2A6jqtMS 2DyHK0WrECDdW0FNpX6VCE/NBRuDhnXFwNxtJKojX+Ss1yOv6Z/jSBvkN0nxBPeZY/Nw3oh8e2P DEeAYXkc2WlT7Yh1XP5xYfIzSQ1Fd7zB/cFtYx2uF1aH7O93B/w9iFYVJPvDuzV+n2/8Odkk3J+ AE0kjpqfjwoyBpZGfj6uN/NxunJJkBQwvhTNFz5wO5rnctx5FxjLHCmlqShVxkJp8Xc4aPrhtwh AN1EG7g5uRHemHFVxeOZqLiPiT62rB3kgrEHZezEG+JieoYRYZlU9HL04lfq9QOsWnPiHkLZr+M T6pWAWb5p1usyai0SrDC26Q7p+EYmMpevRAXCNhhyCdD6etOaRCXdpd6yERbLr7aAghfLF/Ph2x IzfL6f+4pKPjCSRn8XfCZ8ZR4f5P3FcYnT7WnEq0Z47Dfc0CNYlmxuRrwuHjsFacxrehs7wQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-14_01,2025-07-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 impostorscore=0 clxscore=1015 malwarescore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507140079 On 7/11/25 2:58 PM, Bryan O'Donoghue wrote: > Add the PM8010 PMIC providing the following voltage rails: > > vreg_l1m_r @ 1v2 IR sensor > vreg_l2m_r @ 1v2 RGB sensor > vreg_l3m_r @ 1v8 IR sensor > vreg_l4m_r @ 1v8 RGB sensor > vreg_l5m_r @ 2v8 IR sensor > vreg_l7m_r @ 2v8 RGB sensor > > Signed-off-by: Bryan O'Donoghue > --- > .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 59 ++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi > index e19daf0f41f1f081e4b0c04be71e37f6ef492b6d..c9215c1a37cf4e7bad1512f52afdfc18ea616127 100644 > --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi > @@ -580,6 +580,13 @@ vreg_l6b_1p8: ldo6 { > regulator-initial-mode = ; > }; > > + vreg_l7b_2p8: ldo7 { > + regulator-name = "vreg_l7b_2p8"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-initial-mode = ; > + }; > + > vreg_l8b_3p0: ldo8 { > regulator-name = "vreg_l8b_3p0"; > regulator-min-microvolt = <3072000>; > @@ -823,6 +830,58 @@ vreg_l3j_0p8: ldo3 { > regulator-initial-mode = ; > }; > }; > + > + regulators-8 { > + compatible = "qcom,pm8010-rpmh-regulators"; > + qcom,pmic-id = "m"; > + > + vdd-l1-l2-supply = <&vreg_s5j_1p2>; > + vdd-l3-l4-supply = <&vreg_s4c_1p8>; > + vdd-l7-supply = <&vreg_bob1>; > + > + vreg_l1m_1p2: ldo1 { > + regulator-name = "vreg_l1m_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1260000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l2m_1p2: ldo2 { > + regulator-name = "vreg_l2m_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1260000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l3m_1p8: ldo3 { > + regulator-name = "vreg_l3m_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l4m_1p8: ldo4 { > + regulator-name = "vreg_l4m_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l5m_2p8: ldo5 { > + regulator-name = "vreg_l5m_2p9"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3072000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l7m_2p8: ldo7 { > + regulator-name = "vreg_l7m_2p9"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3072000>; > + regulator-initial-mode = ; > + }; Have you confirmed all these voltages on both T14s and yoga against schematics or similar? These vregs are widely configurable, so the reference values may not be what the hardware expects.. Konrad