From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F934361DC0 for ; Tue, 23 Jun 2026 06:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782195299; cv=none; b=rblE5u8CowG/cgxwreKIGq63x2MxURec1P0+ngjFjhbc/oAEqn1v0RiUhEOwv+g8u8xxbLpdtNPiniCFUlTfrQ0xz8JheXJy/ZvG0htWto8mDJQjkYeElpZJQl99WEmx3tHC9lWOY82Aics6cP+C8QrEP1TGEOG7q7M6x8+mbCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782195299; c=relaxed/simple; bh=MyO9vSxYmW96gkicKMfQpYP2sU8NYxAm2f3g9BjPzFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n/kiN8Vuhjm15y27ybDEdbY9ScCCukdF5j/bAootP720mFnw84f2uLqtlpdwtyFGCSUQ4vV3dS+FlffkeMosooQS9eq/S1UzElC4ddDSRo2PSRJelv4rHzw7c9r4vgReTObUIz8AVRyxPjFW3f1MlBXrwgxT3TLKMbHodIggs8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BdHGanCq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hn/juwvn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BdHGanCq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hn/juwvn" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N0hhAt3880214 for ; Tue, 23 Jun 2026 06:14:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SRmFezgGdNXaD4cxRDkq5/2uzdaGtG1vf2sMTlaxZt4=; b=BdHGanCq/fvjWyLx lO6xyNjBVc9KBvnM97L9TUbDYCAPOOL0DDuBny+lP08yJS19RkAtX583JoZPDe4n 2hLR7qPVS7Vw8tW7ebDheHxnY18S9pvPsI/7VK2V76GOJHSQk9YHBEf69/x94lbL KxBU8ewuJzxi/dNl9trrmdjr84XyAYwsi1fJqT7eRUneFExZGw6OHjAnluDkZyhV /Jv+dX8ffzdhNuIgKUsXr4lcu9Z+Wa6Poo0CP1FsIN0jp3qaQ4GY5U4WAFxeWgR6 H8hRmzyPn0Avk/XPXtwX918jSIpo7BjBdOFsiYxMFBVnIIf5NcJ1nhg7rsP/zrGY P05+fg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey5sn382a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 06:14:57 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c88fc985a65so3294810a12.2 for ; Mon, 22 Jun 2026 23:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782195297; x=1782800097; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SRmFezgGdNXaD4cxRDkq5/2uzdaGtG1vf2sMTlaxZt4=; b=Hn/juwvnhaXiYHtO0V16zDnM3+QxkPzD/vRX9PYQm78gSz2D5SvXz6df/ZFFW2eMmQ 3bHYfOXsF4q7Vh0DRW6hkBRISuXgwqvUIoTpDVBelnZLdmo5NVbcD4ODdMu4CFjGFqoW jMO46EKUa5SgEvI8FMrt6PC+WD2eECfMIGKbEdr2xf1s2GOX70uyJw9y08AJPSUKycuy NTPZYwWj/x2nlua7SK7Tfc7S6cGuB2NUG2qmbh2tKccvDTKVcJuvtB+oXJcXHGxmGmQM W20e9RdcU61D49DFd6ZTmpy54NSwM5HwDxJTm89AmI2YxslzTMSHp9ggTH4/dZf552Mx BnyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782195297; x=1782800097; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SRmFezgGdNXaD4cxRDkq5/2uzdaGtG1vf2sMTlaxZt4=; b=oszDZ55esQO3+9EMvJUl39AbacpMx21wM5MUW1LNFAz9+nWKqz4CIcDi9X6Ps21/jP F0WqSEw0Z8WC4hJai+GWCpy00p5gzxzeLOS7yuJ5wy1TJ4yFXXEOwYs0U1dQOpJBN0Yk 1n4PuedbcrbvLvknjBVITGvXWJMxr2w4VeRuavHx9WNTbAp1IVbkeG+tlLHDN2x1qzYp mZCvFmI7djxrQC2mHiV7JEf82ITb8c3LwkZRCYiiHjxa6H9hRVkxiUXLOBQ+Jvg7ggsI WrCmDdl5GEI+qBRThkKNPwSY8WGDYD6yiZCQl1MFaAlUwulXrkm4+emIrMHQBWS5KYsx UzHQ== X-Forwarded-Encrypted: i=1; AFNElJ9Vu+gGEj1s5blV0rhKVleH/Sg8tjNJBWOk9GyU7mfofYKwIrUC5MyPH3R5R1cddE5Ojl5cSa5ux9k6UWg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd+5PnXa55icsl25y8X+hDy6veCORLGAoPaYVVSSm1Pvzd4g7m TIe8RDhEwzUyktyAjiE/B9MR1ugLAhn67npduPxAZaZgGxUlMBnaijLM6r7PZi3SH35Pnw60E+I Em6zHosD6TfAYCObXZ02dC1t6YLH0At7a7bKKcq8jQ3gS1o0TzowkDSbtNr9Rl16ZK9I= X-Gm-Gg: AfdE7clTWq9fuC1/OjwfoN06bkx1qI+czXQV0sKA5Df7SK1yXgdLYEHugvaPsC9znb7 wxXC8NAVU7jFf1zgQPWQ6phWm8fEt/zJgPn9GyLg037l1PO7idYyIwlLxPKPhivv3ev87TD9UGR IdkrDu93PsC8ONIMt1+cgWa1BskvHoVmfsKvRZUItTImgEbiTcFBxcQ5GasK9yfzQV5MToO/ZFX 5DBI3smAt7kxMeIjzOxivXxhh50iQ8LVNCyMOL+EajlCPo5EsP9tlizcDZuxE7zpSkodiF00GRh klwo0JUexOlmmHXooENCXdIeJZ/bMrJ4j5r4g6dNVb0DNPD1o+83QWBi/4hbrmC51WMf9hmxHlu Owb+Tcw9jHhOdCeNt4m5CB146CI1oLp3SXH8JrQ== X-Received: by 2002:a05:6300:14d:b0:3b9:545d:bff3 with SMTP id adf61e73a8af0-3bd1904cf62mr1456547637.14.1782195296962; Mon, 22 Jun 2026 23:14:56 -0700 (PDT) X-Received: by 2002:a05:6300:14d:b0:3b9:545d:bff3 with SMTP id adf61e73a8af0-3bd1904cf62mr1456492637.14.1782195296513; Mon, 22 Jun 2026 23:14:56 -0700 (PDT) Received: from [10.218.5.114] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8bc2c8f0a7sm9216353a12.7.2026.06.22.23.14.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 23:14:55 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 11:44:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/13] clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Loic Poulain , Brian Masney , Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@oss.qualcomm.com> <20260604-shikra-dispcc-gpucc-v4-1-8204f1029311@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: sfd2BZkg6oOkAtFIapUS0aZ3VCrPJCVY X-Proofpoint-ORIG-GUID: sfd2BZkg6oOkAtFIapUS0aZ3VCrPJCVY X-Authority-Analysis: v=2.4 cv=PuKjqQM3 c=1 sm=1 tr=0 ts=6a3a2461 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=Z54PLgYRQ6qQMJT4v0UA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA0OCBTYWx0ZWRfX4YF0UYo7Lt6z zd3NRQbGucJ9jFd1QeispELjA/gdSqjHbUyvh1v6As39mIkTK6gp7L5gOqOz0bkyhZUdMuzWTqL 5wWkFMQJCsqEOVElIoASK6LFxAoN2Os= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA0OCBTYWx0ZWRfX508CrlMMlBOr wY5VN5pYYelJcQ4s7uO+pG+nlq7vppmT1he8iTTv0ozsxSK3Izm+fqHGuBf+oeB9zoIbxBI8Bmk JqZeRacK6G7KoRPIgosQaZjM9OKGdQOhSmV/Cm+GauytYOU7OlG1C4jABWWdOh933WGHrUqQ6TW ASz5MmFwN9sta1TeO8NNC/vwF547ik+GVAjMKZXUDfVKjfTwJLMWVW1kFOjwzM9q9ECWATTc0De vJdwLLkxkDj1J/qJ+5n04+u/ojO//5gxjCwa2ji8MRctC2l4IZN7zehl7mEk8XInihsVRPUnxAl 5SLF8hsLkY52G/kgY9eFZ+AesnKc6c1IAEKaI13BzF5suDmju+Q3ukc165OQSQdo0iG0nehXIEJ FfwLRbkp6B7hqR2TxS9WFtKtHhn6rYs8h+P/GaCcvDMQ/WtqqCr4EpHSaS38OJdzbV1m21McaqM rvt4NAmls26ZoNuCFJQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_01,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230048 On 22-06-2026 08:42 pm, Dmitry Baryshkov wrote: > On Sun, 21 Jun 2026 at 16:28, Imran Shaik wrote: >> >> >> >> On 06-06-2026 04:54 pm, Dmitry Baryshkov wrote: >>> On Thu, Jun 04, 2026 at 10:56:07AM +0530, Imran Shaik wrote: >>>> Some GCC branch clocks are required to be kept always-on due to the >>>> hardware requirements. Drop the modelling of those always-on QCM2290 GCC >>>> clocks and use the latest .clk_cbcr convention to keep them enabled from >>>> probe. >>> >>> You got the feedback, but it got ignored. There is no explanation about >>> gcc_gpu_iref_clk and several other clocks becoming always on. >>> >> >> Apologies for the late reply. >> >> I have updated generically that few clocks are required to be kept ON >> due to the hardware requirements. For gcc_gpu_iref_clk clock the >> Power-On-Reset value is default ON, and such clocks are kept ON from >> probe. As Agatti is working functionally, I will keep this clock >> modelling same as before. >> >> And I will update commit text that the GCC video ahb/xo clocks are >> required to be kept ON similar to other camera/disp ahb/xo clocks. > > Why? What is _wrong_ with thow they are modelled now? > Usually this is required for the register access, hence we mark them critical and keep them ON. As it is working on Agatti with the modelling, will keep them as is for now. Thanks, Imran