From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933613AbdJQL17 (ORCPT ); Tue, 17 Oct 2017 07:27:59 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:60951 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756956AbdJQL14 (ORCPT ); Tue, 17 Oct 2017 07:27:56 -0400 X-AuditID: cbfec7f5-f79d06d0000031c7-d1-59e5e93903ff MIME-version: 1.0 Content-type: text/plain; charset="utf-8"; format="flowed" Subject: Re: [PATCH v2 2/2] !!! FOR TESTING ONLY !!! dmaengine: pl330: add verbose message and set NR_DEFAULT_DESC to 1 To: Alexander Kochetkov , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dan Williams , Vinod Koul , Krzysztof Kozlowski From: Marek Szyprowski Message-id: Date: Tue, 17 Oct 2017 13:27:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 In-reply-to: <1507117044-3456-3-git-send-email-al.kochet@gmail.com> Content-transfer-encoding: 8bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsWy7djPc7qWL59GGnRNU7NY0e9kMX3qBUaL 1VP/slqcP7+B3eLyrjlsFi/79rM4sHnsnHWX3WPxnpdMHptWdbJ5fN4kF8ASxWWTkpqTWZZa pG+XwJVxpnMCS8EvqYpni7ewNzAeFuti5OCQEDCR6D4X0cXICWSKSVy4t56ti5GLQ0hgKaPE 9Icz2CGcz4wSl4/+ZIeoMpH4snwqVNUyRon7f1ezgCR4BQQlfky+B2YzC1hJPPvXygpR9JxR 4u7p22wgCWGBSomlhxsYQWwRgQyJu7tboRrKJS5f+8sEYrMJGEp0ve1igxhqJ7H0+zIwm0VA VeLl4X4wW1QgRmL14h1gvZwCzhI3F81jg5gjL3HwynOomeISza03WUCOkBA4wCbxdFkbG8QL LhJ/Zm9lgrCFJV4d3wL1moxEZ8dBqHg/o0RTqzaEPYNR4txbXgjbWuLw8YusEAv4JCZtm84M CUdeiY42IYgSD4mGr3OgxjhKXNl2EhoQ5xkl3j29xjyBUX4WUoDNQgqwWUh+mIXkhwWMLKsY RVJLi3PTU4tN9YoTc4tL89L1kvNzNzECU8rpf8e/7mBceszqEKMAB6MSD++BI08ihVgTy4or cw8xSnAwK4nw7rr1NFKINyWxsiq1KD++qDQntfgQozQHi5I4r21UW6SQQHpiSWp2ampBahFM lomDU6qBsf9tnP2srX9X1Em/uLGYof73LnG+k0frrTYeqi5k8devt5Tbt3rh9R2fF5+6oup8 8mDTlRcM/JNXbz1Zvthio9LSuXty9OOi9SYzn5BiSOD/2l63SHhGs2Xzti9S+SwvuELOzlWb E+Oi9OzZijLri9qVuV3fWraERj/pmKedISm6tbf4V/C0XUosxRmJhlrMRcWJAP9yoLklAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xa7qWL59GGpw6z2exot/JYvrUC4wW q6f+ZbU4f34Du8XlXXPYLF727WdxYPPYOesuu8fiPS+ZPDat6mTz+LxJLoAlissmJTUnsyy1 SN8ugSvjTOcEloJfUhXPFm9hb2A8LNbFyMkhIWAi8WX5VDYIW0ziwr31YLaQwBJGiYOHokFs XgFBiR+T77GA2MwCZhJfXh5m7WLkAqp5zijRfG8LK0hCWKBSYunhBkYQW0QgQ+LMqiWsEA3l EpPPTYJqOM8osff8YbBJbAKGEl1vu9ggNthJLP2+DMxmEVCVeHm4H8wWFYiRmPjgIthQTgFn iZuL5rFBDJWXOHjlOdRF4hLNrTdZJjAKzkJy7Cwkx85C0jILScsCRpZVjCKppcW56bnFhnrF ibnFpXnpesn5uZsYgeG/7djPzTsYL20MPsQowMGoxMObcehJpBBrYllxZe4hRgkOZiUR3l23 nkYK8aYkVlalFuXHF5XmpBYfYpTmYFES5+3dszpSSCA9sSQ1OzW1ILUIJsvEwSnVwGjc/dzJ OCdbon1xp7dw03P2mI8rlefG3DCZsGaKRJ4y/5U7kdMrey/25+zw5OqUD7zEtXNj2s2JMW+T nf0C9q9Y/MTu5Rkxf4nTVfrz/px5cynMxj2++emybdsK/ZddXTbjU8j7l2bzWUxLwpPOtXI+ MZPsvn1/z8frf4V/btAxc97tmnMrfpcSS3FGoqEWc1FxIgBwAR73ewIAAA== X-CMS-MailID: 20171017112753eucas1p1205ba3f1aa92a70cb8edf19c2832ac0d X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-CMS-RootMailID: 20171004113734epcas2p3dd41acd6104750bb6f3d24abc33c2564 X-RootMTR: 20171004113734epcas2p3dd41acd6104750bb6f3d24abc33c2564 References: <1507117044-3456-1-git-send-email-al.kochet@gmail.com> <1507117044-3456-3-git-send-email-al.kochet@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexander, On 2017-10-04 13:37, Alexander Kochetkov wrote: > Commit add verbose output to pl330 showing what changes introduced by > commit 1/2 from series work as expected. You should see similar output > running modified kernel: > > The patch tested on rk3188 radxdarock. Could someone else test it on > other hardware with pl330 DMA? > > root@host:~# dmesg | grep pl330 > [ 0.277520] dma-pl330 20018000.dma-controller: Loaded driver for PL330 DMAC-241330 > [ 0.277538] dma-pl330 20018000.dma-controller: DBUFF-32x8bytes Num_Chans-6 Num_Peri-12 Num_Events-12 > [ 0.279894] dma-pl330 20078000.dma-controller: Loaded driver for PL330 DMAC-241330 > [ 0.279910] dma-pl330 20078000.dma-controller: DBUFF-64x8bytes Num_Chans-7 Num_Peri-20 Num_Events-14 > [ 1.344804] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor > [ 1.344832] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor > [ 1.344853] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor > [ 1.344873] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor > [ 1.344893] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor > [ 1.344912] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor > --- rest of similar lines omitted --- > > Signed-off-by: Alexander Kochetkov Tested-by: Marek Szyprowski Seems to be working fine on Exynos4412 OdroidU3 board: # dmesg | grep pl330 [    0.725608] dma-pl330 12680000.pdma: Loaded driver for PL330 DMAC-141330 [    0.725629] dma-pl330 12680000.pdma:         DBUFF-32x4bytes Num_Chans-8 Num_Peri-32 Num_Events-32 [    0.731338] dma-pl330 12690000.pdma: Loaded driver for PL330 DMAC-141330 [    0.731357] dma-pl330 12690000.pdma:         DBUFF-32x4bytes Num_Chans-8 Num_Peri-32 Num_Events-32 [    0.733097] dma-pl330 12850000.mdma: Loaded driver for PL330 DMAC-141330 [    0.733115] dma-pl330 12850000.mdma:         DBUFF-64x8bytes Num_Chans-8 Num_Peri-1 Num_Events-32 [   98.353073] dma-pl330 12680000.pdma: pl330_get_desc:2460 Allocated one more descriptor [   98.360970] dma-pl330 12680000.pdma: pl330_get_desc:2460 Allocated one more descriptor [   98.368867] dma-pl330 12680000.pdma: pl330_get_desc:2460 Allocated one more descriptor > --- > drivers/dma/pl330.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index deec4a4..3441c16 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -266,7 +266,7 @@ enum pl330_byteswap { > > /* The number of default descriptors */ > > -#define NR_DEFAULT_DESC 16 > +#define NR_DEFAULT_DESC 1 > > /* Delay for runtime PM autosuspend, ms */ > #define PL330_AUTOSUSPEND_DELAY 20 > @@ -2455,6 +2455,9 @@ static struct dma_pl330_desc *pl330_get_desc(struct dma_pl330_chan *pch) > > desc = pluck_desc(&pool, &lock); > WARN_ON(!desc || !list_empty(&pool)); > + > + dev_err(pch->dmac->ddma.dev, "%s:%d Allocated one more descriptor\n", > + __func__, __LINE__); > } > > /* Initialize the descriptor */ Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland