From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE140373BE6 for ; Thu, 10 Sep 2026 08:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789027239; cv=none; b=fBB69dQwakBE0L1KQXwUO/NxhediL6likT8DhrpVXPagScxCGCUgto/E2cdrYt+IR1NvoVmmX+hWGrv49DshYEQ3KvYSbs6VocyQ2cXW9pNG/A4uMYFfWEHJPDlwarcgurrBeo/ct7f+eTLZPCa0mU+VOk0DrnxRQ4gEkj1S6GM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789027239; c=relaxed/simple; bh=/3RH+agYBWzjPq6PU40/WNuffhDOzE9IuS/+UNvbaEI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=gCo17fzfi3VKUqhH4Odyf3f8GliUadizCFJEkGt8SgXfdYKizwPHYkjOr2Ow6JzcV4Xhyk7OubFNvFb/+3FFts5zG6xqemElPxQqKoHzs9LTur+1qT2YCvmlGHVzuLNVu5xL1fiTuNKYktwp+DJxV6Q+6HNXmmP6/N2qzlt+xGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from edelgard.fodlan.icenowy.me (unknown [112.94.100.66]) by APP-01 (Coremail) with SMTP id qwCowABXLfGdY6JqsQ2XBw--.19756S2; Thu, 10 Sep 2026 16:00:30 +0800 (CST) Message-ID: Subject: Re: [PATCH 1/2] drm/verisilicon: set blend mode for the primary plane From: Icenowy Zheng To: Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard Cc: David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Thu, 10 Sep 2026 16:00:29 +0800 In-Reply-To: References: <20260901171703.1161592-1-zhengxingda@iscas.ac.cn> <35cf76a67f7473d5ef86d01c812d680abc41687e.camel@iscas.ac.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID:qwCowABXLfGdY6JqsQ2XBw--.19756S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uFWfZw1rAr1kCF4rCr15urg_yoW8AFWfpF srAFWjkr4rArsrJry7tasrtaya9a1rGFn2gry5Xwn7X39rtr1UCF48Jr98uFW5Jr4xWw13 trn3AF9rAr1UCaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkIb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwV C2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxkF7I0En4kS14v26r126r1DMxAI w28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr 4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxG rwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8Jw CI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU5k9NDUUUUU== X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ =E5=9C=A8 2026-09-10=E5=9B=9B=E7=9A=84 09:58 +0200=EF=BC=8CThomas Zimmerman= n=E5=86=99=E9=81=93=EF=BC=9A > Hi >=20 > Am 10.09.26 um 09:09 schrieb Icenowy Zheng: > > =E5=9C=A8 2026-09-02=E4=B8=89=E7=9A=84 01:17 +0800=EF=BC=8CIcenowy Zhen= g=E5=86=99=E9=81=93=EF=BC=9A > > > Blend modes are now required to expose pixel formats w/ alpha. > > >=20 > > > As it's the primary plane and blending is explicitly disabled, > > > just > > > expose PIXEL_NONE blend mode. > > Gently ping for reviews. >=20 > What do these alpha formats do?=C2=A0 Are they a hardware feature?=C2=A0 = It > looks=20 > like they are programmable, but don't differ from XRGB at all. I think they're for consistency with overlay planes. Thanks, Icenowy >=20 > Best regards > Thomas >=20 > >=20 > > Thanks, > > Icenowy > >=20 > > > Signed-off-by: Icenowy Zheng > > > --- > > > =C2=A0=C2=A0drivers/gpu/drm/verisilicon/vs_primary_plane.c | 3 +++ > > > =C2=A0=C2=A01 file changed, 3 insertions(+) > > >=20 > > > diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane.c > > > b/drivers/gpu/drm/verisilicon/vs_primary_plane.c > > > index 1f2be41ae496c..8d58682d88ef8 100644 > > > --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c > > > +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c > > > @@ -7,6 +7,7 @@ > > > =C2=A0=20 > > > =C2=A0=C2=A0#include > > > =C2=A0=C2=A0#include > > > +#include > > > =C2=A0=C2=A0#include > > > =C2=A0=C2=A0#include > > > =C2=A0=C2=A0#include > > > @@ -179,5 +180,7 @@ struct drm_plane > > > *vs_primary_plane_init(struct > > > drm_device *drm_dev, struct vs_dc > > > =C2=A0=20 > > > =C2=A0=C2=A0 drm_plane_helper_add(plane, > > > &vs_primary_plane_helper_funcs); > > > =C2=A0=20 > > > + drm_plane_create_blend_mode_property(plane, > > > + =09 > > > BIT(DRM_MODE_BLEND_PIXEL_NONE)); > > > =C2=A0=C2=A0 return plane; > > > =C2=A0=C2=A0}