From: David Woodhouse <dwmw2@infradead.org>
To: Brian Gerst <brgerst@gmail.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Usama Arif <usama.arif@bytedance.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 3/6] x86/smpboot: Remove initial_stack on 64-bit
Date: Thu, 23 Feb 2023 08:05:34 +0000 [thread overview]
Message-ID: <d372b6d6021f101fe809f397bdba0455c7b037cc.camel@infradead.org> (raw)
In-Reply-To: <20230222221301.245890-4-brgerst@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]
On Wed, 2023-02-22 at 17:12 -0500, Brian Gerst wrote:
> @@ -245,11 +245,11 @@ SYM_INNER_LABEL(secondary_startup_64_no_verify, SYM_L_GLOBAL)
> #ifdef CONFIG_SMP
> /*
> * Is this the boot CPU coming up? If so everything is available
> - * in initial_gs, initial_stack and early_gdt_descr.
> + * in initial_gs and early_gdt_descr.
> */
> movl smpboot_control(%rip), %edx
> testl $STARTUP_SECONDARY, %edx
> - jz .Lsetup_cpu
> + jz .Linit_cpu0_data
>
> /*
> * For parallel boot, the APIC ID is retrieved from CPUID, and then
> @@ -302,6 +302,10 @@ SYM_INNER_LABEL(secondary_startup_64_no_verify, SYM_L_GLOBAL)
> hlt
> jmp 1b
>
> +.Linit_cpu0_data:
> + movq __per_cpu_offset(%rip), %rdx
> + jmp .Lsetup_cpu
> +
Aren't all CPUs taking this .Linit_cpu0_data path for non-parallel
startup, not just cpu0? I think you want something more like
.Linit_cpuN_data:
orl $0x0fffffff, %edx
leaq __per_cpu_offset(%rip), %rbx
movq (%rbx,%rdx,8), %rdx
jmp .Lsetup_cpu
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
next prev parent reply other threads:[~2023-02-23 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 22:12 [PATCH 0/6] x86-64: Remove global variables from boot Brian Gerst
2023-02-22 22:12 ` [PATCH 1/6] x86/smpboot: Use CPU number instead of APIC ID for single CPU startup Brian Gerst
2023-02-22 22:12 ` [PATCH 2/6] x86/smpboot: Use current_task to get idle thread Brian Gerst
2023-02-22 22:12 ` [PATCH 3/6] x86/smpboot: Remove initial_stack on 64-bit Brian Gerst
2023-02-23 8:05 ` David Woodhouse [this message]
2023-02-23 8:27 ` David Woodhouse
2023-02-22 22:12 ` [PATCH 4/6] x86/smpbppt: Remove early_gdt_descr " Brian Gerst
2023-02-23 6:49 ` H. Peter Anvin
2023-02-23 12:10 ` Brian Gerst
2023-02-22 22:13 ` [PATCH 5/6] x86/smpboot: Remove initial_gs Brian Gerst
2023-02-22 22:13 ` [PATCH 6/6] x86/smpboot: Simplify boot CPU setup Brian Gerst
2023-02-23 12:36 ` David Woodhouse
2023-02-23 13:44 ` [PATCH 0/6] x86-64: Remove global variables from boot David Woodhouse
2023-02-23 14:24 ` Brian Gerst
2023-02-23 19:14 ` [External] " Usama Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d372b6d6021f101fe809f397bdba0455c7b037cc.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=usama.arif@bytedance.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®