From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD81C43381 for ; Mon, 8 Mar 2021 10:20:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 540176512C for ; Mon, 8 Mar 2021 10:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231189AbhCHKUR (ORCPT ); Mon, 8 Mar 2021 05:20:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhCHKUF (ORCPT ); Mon, 8 Mar 2021 05:20:05 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F998C06174A; Mon, 8 Mar 2021 02:20:05 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id d15so10831514wrv.5; Mon, 08 Mar 2021 02:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5FyddfYk6kKr/3zvxDS0VxAq0/NkeI1fTb/fX0lhdjQ=; b=VNu2vtDmLmzQJwF4ZyTj8wObBxKSsE82/oOXMgl6E3jKOhli0nYm0p9ir6Pdmv+8+0 kNOXWuutxJh9KiHrdwuEVwytOHAOmG1gX89A8XkQcaGvAVRUgDsEY+xSMcQbIrKahyNv VmhHfiWrWglKX5OXr0HnRIDHBbEC1Z30DWvn5kcF1QNc7Hd4a4xsIZwpxWxe/p22lu5R Ed/DgbFFI4Bt9cehYSktW9xmeHPIGXCRAfQowteFDKa/4SpnvMXz/XnQtHutpVAJpj73 GcHgfoDFjE25pHn6MRZq7F47x8NrAImuJthqjOflUVnYOXYzr6s9yLcSKY2Ft3qOZi+W HZlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5FyddfYk6kKr/3zvxDS0VxAq0/NkeI1fTb/fX0lhdjQ=; b=nsF54KPjaXZgP2Bhm4YC91Pbt8VKibsYpu2n4JPgiJVKY/P0q7r1cYxHUdBpO8cuHX 3C9WlwZR1+ApO+nIVbuxKBNHHBxW3ONKZXx54/fGV7AsDMBrv+Qj6lFF/fBiWqFj2Cjx Z9j7iqjiOKF180CVgCc741WelfT4KfSdWc4Q+Thih1tXnpaYy6dBXJwPw2TGkxquSwal x5e42FvkgDiStkW6NMVcP9I/IwKhOO3k0T2YFtSJs9fFXBR90uEeVQeN790mSTMohASR WV8xx7bIfxNYbCPr3ydFZXS8U++JdfwlsmNUCu5B0tmBBgIIOD7mXxu+QoOtZYAL5w31 p7gw== X-Gm-Message-State: AOAM532WuLJZaSvgTfGWkG0Wi4lF+RLwF8LXambMAuzBkM9VyGsxIEBQ hiByrTKJUHFgi47G3XUHiJkaaC6p+DoBSA== X-Google-Smtp-Source: ABdhPJzCwrBCqqyIGM7tUOvJJ3q8im0e+1PCOS7GVSQC0rnBjVBVUcOR0NiLmcaAa5nAlh2dufPzqg== X-Received: by 2002:adf:aa08:: with SMTP id p8mr21664879wrd.232.1615198803547; Mon, 08 Mar 2021 02:20:03 -0800 (PST) Received: from ?IPv6:2003:ea:8f1f:bb00:95fd:bec9:ac6f:f944? (p200300ea8f1fbb0095fdbec9ac6ff944.dip0.t-ipconnect.de. [2003:ea:8f1f:bb00:95fd:bec9:ac6f:f944]) by smtp.googlemail.com with ESMTPSA id v2sm11306241wru.85.2021.03.08.02.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 02:20:03 -0800 (PST) Subject: Re: [PATCH] net: ieee802154: fix error return code of dgram_sendmsg() To: Jia-Ju Bai Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alex.aring@gmail.com, davem@davemloft.net, kuba@kernel.org, stefan@datenfreihafen.org References: <20210308093106.9748-1-baijiaju1990@gmail.com> From: Heiner Kallweit Message-ID: Date: Mon, 8 Mar 2021 11:19:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210308093106.9748-1-baijiaju1990@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.03.2021 10:31, Jia-Ju Bai wrote: > When sock_alloc_send_skb() returns NULL to skb, no error return code of > dgram_sendmsg() is assigned. > To fix this bug, err is assigned with -ENOMEM in this case. > Please stop sending such nonsense. Basically all such patches you sent so far are false positives. You have to start thinking, don't blindly trust your robot. In the case here the err variable is populated by sock_alloc_send_skb(). > Fixes: 78f821b64826 ("ieee802154: socket: put handling into one file") > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai > --- > net/ieee802154/socket.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c > index a45a0401adc5..a750b37c7e73 100644 > --- a/net/ieee802154/socket.c > +++ b/net/ieee802154/socket.c > @@ -642,8 +642,10 @@ static int dgram_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) > skb = sock_alloc_send_skb(sk, hlen + tlen + size, > msg->msg_flags & MSG_DONTWAIT, > &err); > - if (!skb) > + if (!skb) { > + err = -ENOMEM; > goto out_dev; > + } > > skb_reserve(skb, hlen); > >