From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E133AC4167B for ; Tue, 28 Nov 2023 00:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234399AbjK1AqW (ORCPT ); Mon, 27 Nov 2023 19:46:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234360AbjK1AqT (ORCPT ); Mon, 27 Nov 2023 19:46:19 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77085D6D; Mon, 27 Nov 2023 16:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=tPsB2hWA3Oc577a+cgExHeE0rQjVhZlCmuxB4d3ag6Y=; b=wOrTyuobaJiBkDDEN+3GnJb9Gj khoMngUKyPMKlVGbsfyCinioYWK0Liy4RVI0/Noz7xvcBvdK128h9OAY0vlKvfQpTRb03Oi9dJFK9 /ppp2Ers5rvwGbJhiODR3FSIcr9/87gXJjP/7n93H5gGoTD/zHSh4MjQ4wDbEHbEfDlY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r7mEs-001Oyh-FN; Tue, 28 Nov 2023 01:46:10 +0100 Date: Tue, 28 Nov 2023 01:46:10 +0100 From: Andrew Lunn To: Christian Marangi Cc: Florian Fainelli , Broadcom internal kernel review list , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , David Epping , "Russell King (Oracle)" , Harini Katakam , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v2 3/4] net: phy: restructure __phy_write/read_mmd to helper and phydev user Message-ID: References: <20231126235141.17996-1-ansuelsmth@gmail.com> <20231126235141.17996-3-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231126235141.17996-3-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2023 at 12:51:40AM +0100, Christian Marangi wrote: > Restructure phy_write_mmd and phy_read_mmd to implement generic helper > for direct mdiobus access for mmd and use these helper for phydev user. > > This is needed in preparation of PHY package API that requires generic > access to the mdiobus and are deatched from phydev struct but instead > access them based on PHY package base_addr and offsets. Why is this all going into the header file? Andrew