From: "Yunfei Dong (董云飞)" <Yunfei.Dong@mediatek.com>
To: "tomm.merciai@gmail.com" <tomm.merciai@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "nicolas@ndufresne.ca" <nicolas@ndufresne.ca>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"frkoenig@chromium.org" <frkoenig@chromium.org>,
"Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>,
"wenst@chromium.org" <wenst@chromium.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"stevecho@chromium.org" <stevecho@chromium.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"hsinyi@chromium.org" <hsinyi@chromium.org>,
"benjamin.gaignard@collabora.com"
<benjamin.gaignard@collabora.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH] media: mediatek: vcodec: Force capture queue format to MM21
Date: Fri, 10 Feb 2023 05:56:37 +0000 [thread overview]
Message-ID: <d3754485de6cc5a4b4b1246fb0bf86f13711cf4f.camel@mediatek.com> (raw)
In-Reply-To: <28f167b7-c468-8752-29d1-2a122e8142dd@collabora.com>
Hi AngeloGioacchino,
Thanks for your suggestion.
Add Fixes tag in patch v2.
Best Regards,
Yunfei Dong
On Thu, 2023-02-09 at 13:56 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/02/23 09:57, Tommaso Merciai ha scritto:
> > Hi Yunfei Dong,
> >
> > On Thu, Feb 09, 2023 at 03:40:25PM +0800, Yunfei Dong wrote:
> > > In order to conver the format of capture queue from mediatek MM21
> > > to
> > > standard yuv420 with Libyuv, need to force capture queue format
> > > to
> > > MM21 for Libyuv can't covert mediatek MT21 format.
> >
> > Sorry, just some clarifications on my side, just to understand :)
> > The problem is that libyuv can't convert mm21 format into yuv420
> > than you need to use mm21 (forcing this).
> > Did I understand correctly?
> >
>
> vcodec can output either MM21 or MT21C; libyuv can't handle the MT21C
> format,
> at least for now, hence he is forcing vcodec to always give MM21 for
> things
> to actually work... at a later time, I hope and suppose that this
> driver will
> change to not force anything anymore.
>
> > Thanks in advance,
> > Tommaso
> >
>
> Yunfei, since this is required to get "basic" functionality, this
> commit needs
> a Fixes tag: can you please add the right one?
>
> Thanks!
> Angelo
>
>
next prev parent reply other threads:[~2023-02-10 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 7:40 Yunfei Dong
2023-02-09 8:57 ` Tommaso Merciai
2023-02-09 12:56 ` AngeloGioacchino Del Regno
2023-02-10 5:56 ` Yunfei Dong (董云飞) [this message]
2023-02-10 7:27 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3754485de6cc5a4b4b1246fb0bf86f13711cf4f.camel@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=stevecho@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=tomm.merciai@gmail.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®