From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbeDSRao (ORCPT ); Thu, 19 Apr 2018 13:30:44 -0400 Received: from esa3.dell-outbound.iphmx.com ([68.232.153.94]:48267 "EHLO esa3.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbeDSRam (ORCPT ); Thu, 19 Apr 2018 13:30:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EfAABQ0dhamMuZ6ERbGgEBAQEBAgEBA?= =?us-ascii?q?QEIAQEBAYQVgQgoCoNelHmBdIEPknMUgWQLhGkCGoIoITUXAQIBAQEBAQECAQE?= =?us-ascii?q?CEAEBAQEBCAsLBigvgjUigkwBAQEBAgEjEUoHBAIBBgIRBAEBAQICIwMCAgJEA?= =?us-ascii?q?QgIAgQBEggRhGwIiwabQIIciEOCJYEJhn2CE4EPgwuEMg4BEgEDM4JpglQCjBG?= =?us-ascii?q?LXAiONYxVkCeBJR0BgRhxcIMTgiAOCY4Xb419DxcDgQWBGAEB?= X-IPAS-Result: =?us-ascii?q?A2EfAABQ0dhamMuZ6ERbGgEBAQEBAgEBAQEIAQEBAYQVgQg?= =?us-ascii?q?oCoNelHmBdIEPknMUgWQLhGkCGoIoITUXAQIBAQEBAQECAQECEAEBAQEBCAsLB?= =?us-ascii?q?igvgjUigkwBAQEBAgEjEUoHBAIBBgIRBAEBAQICIwMCAgJEAQgIAgQBEggRhGw?= =?us-ascii?q?IiwabQIIciEOCJYEJhn2CE4EPgwuEMg4BEgEDM4JpglQCjBGLXAiONYxVkCeBJ?= =?us-ascii?q?R0BgRhxcIMTgiAOCY4Xb419DxcDgQWBGAEB?= From: X-LoopCount0: from 10.166.132.187 X-IronPort-AV: E=Sophos;i="5.49,469,1520917200"; d="scan'208";a="1242718601" X-DLP: DLP_GlobalPCIDSS To: , , , Subject: RE: issues with suspend on Dell XPS 13 2-in-1 Thread-Topic: issues with suspend on Dell XPS 13 2-in-1 Thread-Index: AQHT05S3l/OM2r/yv0C0KBEFc37YQqQDkQZAgAJ8rYCAAPZB8IAA+lMAgABhL8A= Date: Thu, 19 Apr 2018 17:30:38 +0000 Message-ID: References: <6ce634cb82617c2a9a060ba6e2accef2a15dcc15.camel@redhat.com> <1524005977.31134.15.camel@intel.com> <6ebf99dedde4446d84333c2cf25cc9fa@ausx13mpc120.AMER.DELL.COM> <1524112616.31134.43.camel@intel.com> In-Reply-To: <1524112616.31134.43.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w3JHUpZX016437 > -----Original Message----- > From: Pandruvada, Srinivas [mailto:srinivas.pandruvada@intel.com] > Sent: Wednesday, April 18, 2018 11:37 PM > To: dgilmore@redhat.com; linux-kernel@vger.kernel.org; linux- > acpi@vger.kernel.org; Limonciello, Mario > Subject: Re: issues with suspend on Dell XPS 13 2-in-1 > > On Wed, 2018-04-18 at 21:01 +0000, Mario.Limonciello@dell.com wrote: > > > > > > > > [...] > > > > > Srinivas, > > > > > > > > Do you know why Runtime PM is defaulting to disabled for all of > > > > these > > > > devices?  Is that a default kernel policy problem or a distro > > > > policy > > > > problem? > > > > > > This is default kernel policy. > > > > Why is policy set this way by default in kernel?  Could we discuss to > > change > > Default kernel policy so that users can get better power consumption > > by default > Good question. This was discussed before, the problem is that it can > cause some issues with legacy devices. If the concern is legacy devices, what about flipping default policy when it's say SKL or newer? > It should be better done in user > space by some policy in gnome power manager, which user can > enable/disable. Sure, I think letting userspace change the policy if a user wants to turn It off makes sense. What I'm hoping to accomplish however is a better default policy however since most users should prefer more battery life, and "power users" would be the ones to further tune for their preferred usage. > > > > > I think it will be especially important as more machines continue to > > adopt > > suspend-to-idle. > Those should impact opportunistic idle since for S2I regular suspend > callbacks are called. In my 9365, I can get PC10 during S2I path > without adjusting them. Only problematic is systems with SATA, where we > need to enable devsleep. Hmm, Dennis did mention that he had an NVME disk, so it can't be a devsleep problem. Perhaps can you also share your kernel config used with 9365 so Dennis can compare? I believe we'll need to see some more information from Dennis you asked in previous email before we can make more progress here though. > > > > > I suggest run > > > #turbostat > > > then suspend and wake > > > when wake up let the turbostat collect data for next sampling > > > interval. > > > We have to see what are PkgC% residencies are? > > > > Assuming you mean for Dan to run this after he adjusts all the PM > > settings > > for those options power top called out, right? > It is better. > May be some device is not behaving correctly. So he can try with > powertop --auto-tune and check turbostat and see status of PkgC states. > > Thanks, > Srinivas > > > > > > > > > Thanks, > > > Srinivas > > > > > > > > > > > > > > > >    Good          Bluetooth device interface status > > > > >    Good          Enable Audio codec power management > > > > >    Good          Runtime PM for I2C Adapter i2c-8 (Synopsys > > > > > DesignWare > > > > > I2C adapter) > > > > >    Good          Autosuspend for USB device > > > > > Integrated_Webcam_HD > > > > > [CNFGE16N092020028362] > > > > >    Good          Autosuspend for USB device xHCI Host > > > > > Controller > > > > > [usb1] > > > > >    Good          Autosuspend for USB device xHCI Host > > > > > Controller > > > > > [usb2] > > > > >    Good          Runtime PM for I2C Adapter i2c-7 (SMBus I801 > > > > > adapter > > > > > at efa0) > > > > >    Good          Autosuspend for unknown USB device 1-2 > > > > > (8087:0a2b) > > > > >    Good          Runtime PM for I2C Adapter i2c-6 (Synopsys > > > > > DesignWare > > > > > I2C adapter) > > > > >    Good          I2C Device i2c-DLL077A:01 has no runtime power > > > > > management > > > > >    Good          I2C Device i2c-WCOM482F:00 has no runtime > > > > > power > > > > > management > > > > >    Good          Runtime PM for PCI Device Intel Corporation > > > > > Sunrise > > > > > Point-LP PCI Express Root Port #10 > > > > >    Good          Runtime PM for PCI Device Intel Corporation > > > > > Sunrise > > > > > Point-LP CSME HECI #1 > > > > >    Good          Runtime PM for PCI Device Intel Corporation > > > > > Sunrise > > > > > Point-LP Serial IO I2C Controller #1 > > > > >    Good          Runtime PM for PCI Device Intel Corporation > > > > > Sunrise > > > > > Point-LP SMBus > > > > >    Good          Runtime PM for PCI Device Intel Corporation > > > > > Sunrise > > > > > Point-LP PCI Express Root Port #5 > > > > >    Good          Runtime PM for PCI Device Intel Corporation > > > > > Sunrise > > > > > Point-LP Serial IO I2C Controller #0 > > > > >    Good          Wake-on-lan status for device virbr0-nic > > > > >    Good          Wake-on-lan status for device virbr0 > > > > >    Good          Wake-on-lan status for device wlp60s0 > > > > > > > > > > Regards > > > > > > > > > > Dennis