From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752221AbdJDOPT (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 10:15:19 -0400
Received: from g9t1613g.houston.hpe.com ([15.241.32.99]:60201 "EHLO
        g9t1613g.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752029AbdJDOPS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 10:15:18 -0400
Subject: Re: [PATCH 4/5] x86/kernel: Provide a means to disable TSC ART
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Bin Gao <bin.gao@linux.intel.com>,
        Prarit Bhargava <prarit@redhat.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Andrew Banman <andrew.banman@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
References: <20171002151214.822224274@stormcage.americas.sgi.com>
 <20171002151217.095807201@stormcage.americas.sgi.com>
 <20171004092704.mm4q5ivrlfrcj6sk@hirez.programming.kicks-ass.net>
From: Mike Travis <mike.travis@hpe.com>
Message-ID: <d37dffa7-c69e-72ed-b777-e7fe742ed5b4@hpe.com>
Date: Wed, 4 Oct 2017 07:15:17 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171004092704.mm4q5ivrlfrcj6sk@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 10/4/2017 2:27 AM, Peter Zijlstra wrote:
> On Mon, Oct 02, 2017 at 10:12:18AM -0500, mike.travis@hpe.com wrote:
>>   static void detect_art(void)
>>   {
>>   	unsigned int unused[2];
>>   
>> -	if (boot_cpu_data.cpuid_level < ART_CPUID_LEAF)
>> +	if (boot_cpu_data.cpuid_level < ART_CPUID_LEAF || tsc_art_disabled)
>>   		return;
>>   
>>   	/* Don't enable ART in a VM, non-stop TSC and TSC_ADJUST required */
> 
> 
> So why can't we use is_uv_system() here an for the tsc_adjust thing?

I could.  I just thought that there may be future system arches that
need the same facility?
> 
> Also (and I hate the name) tsc_multi_sync_resets is the reason you
> cannot use ART, I don't think it makes sense to introduce yet another
> knob.
> 
Okay.  I wasn't sure if there might be different causes for wanting one
condition over the other.  So does this mean change this later test to
use is_uv_system() or tsc_multi_sync_resets?

Thanks.