From: <Tudor.Ambarus@microchip.com>
To: <sudip.mukherjee@sifive.com>
Cc: <pratyush@kernel.org>, <michael@walle.cc>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<greentime.hu@sifive.com>, <jude.onyenegecha@sifive.com>,
<william.salmon@sifive.com>, <adnan.chowdhury@sifive.com>,
<ben.dooks@sifive.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] mtd: spi-nor: add SFDP fixups for Quad Page Program
Date: Wed, 10 Aug 2022 16:48:51 +0000 [thread overview]
Message-ID: <d380a6e8-6666-1c0c-109a-3f8449fb7f02@microchip.com> (raw)
In-Reply-To: <CAHyZL-dgrGu3z4ySy_EdG7KdZwU+DHdo8nH=+Go_nGZUZYFq_A@mail.gmail.com>
On 8/10/22 18:14, Sudip Mukherjee wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, Aug 10, 2022 at 9:06 AM <Tudor.Ambarus@microchip.com> wrote:
>>
>> On 8/9/22 23:14, Sudip Mukherjee wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> SFDP table of some flash chips do not advertise support of Quad Input
>>> Page Program even though it has support. Use fixup flags and add hardware
>>> cap for these chips.
>>>
>
> <snip>
>
>>> @@ -520,6 +521,7 @@ struct flash_info {
>>> u8 fixup_flags;
>>> #define SPI_NOR_4B_OPCODES BIT(0)
>>> #define SPI_NOR_IO_MODE_EN_VOLATILE BIT(1)
>>> +#define SPI_NOR_QUAD_PP BIT(2)
>>
>> No, as I previously said, SPI_NOR_QUAD_PP should be declared as a
>> info->flags, not as info->fixup_flags.
>
> Sorry, I was confused as info->fixup_flags says "it indicates support
> that can be discovered via SFDP ideally, but can not be discovered
> for this particular flash because the SFDP table that indicates this
> support is not defined by the flash."
>
Right, I've just sent a patch addressing this, hopefully is clearer now.
Check it here:
https://lore.kernel.org/linux-mtd/20220810155924.1366072-1-tudor.ambarus@microchip.com/T/#u
> --
> Regards
> Sudip
--
Cheers,
ta
next prev parent reply other threads:[~2022-08-10 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 20:14 [PATCH v2 0/3] Add support for Quad Input Page Program to is25wp256 Sudip Mukherjee
2022-08-09 20:14 ` [PATCH v2 1/3] mtd: spi-nor: issi: is25wp256: Init flash based on SFDP Sudip Mukherjee
2022-08-10 7:55 ` Tudor.Ambarus
2022-09-15 16:51 ` Sudip Mukherjee
2022-08-09 20:14 ` [PATCH v2 2/3] mtd: spi-nor: add SFDP fixups for Quad Page Program Sudip Mukherjee
2022-08-10 8:06 ` Tudor.Ambarus
2022-08-10 8:25 ` Tudor.Ambarus
2022-08-10 15:17 ` Sudip Mukherjee
2022-08-10 15:14 ` Sudip Mukherjee
2022-08-10 16:48 ` Tudor.Ambarus [this message]
2022-08-09 20:14 ` [PATCH v2 3/3] mtd: spi-nor: issi: is25wp256: Enable Quad Input " Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d380a6e8-6666-1c0c-109a-3f8449fb7f02@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=adnan.chowdhury@sifive.com \
--cc=ben.dooks@sifive.com \
--cc=greentime.hu@sifive.com \
--cc=jude.onyenegecha@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sudip.mukherjee@sifive.com \
--cc=vigneshr@ti.com \
--cc=william.salmon@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®