From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C845F38BF84 for ; Tue, 24 Feb 2026 12:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771934803; cv=none; b=DmtI0BH/CMbtIjTPZCfkSnWL5E7b3nSd1zqpFyjnZdrOID5ICnnq/T9SadFgSChCBBqJaEMT3+eu8tBhDL9vJZKsaXxrxDjprRYGfMxmk3lJaCqeJurWlhkeP6aAqqCZJ4xRvOBn3//v6Ibsbuu77uZyl98wtf5ii7Q3I607YkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771934803; c=relaxed/simple; bh=kBZj9miGFSQFJ0YH3FJIUfJJvnx8d1aKL1JDNWIViwI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cryt7n84IVWIXTgwRu1vm8rd1hVKRMu2cbzmrG8hbp2bQspXz6mTvZVLhdcXX85ha7al342vsr/7AbngRwQfj+JDnoTNSeLIsNVVZ/DK8HfY/Tmwy3NBkilidNbz+aJWGpPkj1oel26ePGfNWWq7foUEWdYwjuQe/RY6Cm6IvC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YTbraPJU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HEbDeJHh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YTbraPJU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HEbDeJHh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771934800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mYMqK1cVj3HuIDLVMmhgwBdTK896O5r5K8TYOirOOgE=; b=YTbraPJUGhQa4levq3QP9j/+lDbWDu3ctJLKRpKIDKJbVQmRV+X/zuQ9saXlDAP1bhbAV9 35jRp1Y6e7D0zDwN0QuOHtza6jzdU5ZUjNztZDjchTKg/mKEugioVbHEdrULpemU6Kf8Z4 9Y9nb1qgh+shaPmBXCU/gUP0K2CYQ/A= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-zo5mCJ29MuSqHTZPLjkQZQ-1; Tue, 24 Feb 2026 07:06:38 -0500 X-MC-Unique: zo5mCJ29MuSqHTZPLjkQZQ-1 X-Mimecast-MFC-AGG-ID: zo5mCJ29MuSqHTZPLjkQZQ_1771934796 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4836abfc742so36946115e9.0 for ; Tue, 24 Feb 2026 04:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771934796; x=1772539596; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mYMqK1cVj3HuIDLVMmhgwBdTK896O5r5K8TYOirOOgE=; b=HEbDeJHh1GChwNUcjwZhabI0gZATiVcCydWRyXtq8pySIAAnEdJQrruUZU2auaJ4Zu w6n4yxsUQa4U2r9YnxIqnuD1a6y5Jhek4HVboqYze1EuvUICRYW+ajlG4zA3wtddtowp i/Z9xiJXib4tLMWUT2HxZakM/d1CwWPpOdXEoVbZZwheWh2dp3m//QhSdgduRVZKTFtV xvqX09uixQ/EFE3FxTsxehH17V2LPuDw+MSg8pbLIblhVqnBl/R3SSPi4rtXsKdFMZow ho/m1IZKh8z6YRI0KXWVhuhxQv8sJSFbwLFJxANZCiQ3SjtXwBoj8FWCwOW2Jn54hsOZ n5DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771934796; x=1772539596; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mYMqK1cVj3HuIDLVMmhgwBdTK896O5r5K8TYOirOOgE=; b=k6ZBTxDSgUzV+yrtL8I+U8/h5KXoq3rxMSnpK1FybdlQVpOG4VxpcUDzvGbMIgjaTX GtJPP6ASBrJV2WRsITeo8WQhlakwriPMt90fWvLKmBi7UXOtajw6cQdZytMgOhRQVaas QSaPlVWtCJYTGTuQcw4c/VYlaQbbtsYWJHxW8/b6dzHQT9EXPF8oGjIn9Yx0FIn9vEnp WW3gUGtf8BZ5Eof5C26rgWXm2/SdXCrqN+pLH0thBUb65hf5bE2P6Y1fdkwNeoZh9SEn z/uQXR2LRpk6m9g8/A1gDe2UNN/docgTlPOxKmZnQmVf3X3AuQlMapb9P6302oUyQTDl KpuQ== X-Forwarded-Encrypted: i=1; AJvYcCUzJGUKaxU9csUjaA/9nYNq1jZnvOhWchSb2VYEyykJ5nt8uiTjPljXgIou8XHoc4zUww0WheZzcOAN9kY=@vger.kernel.org X-Gm-Message-State: AOJu0YzFf9ANFXZOTJ7ynOz4kYKd1i8yMNMym9khb8tZJBicw7MzrFu6 UG4aV7nGqbK9OuQool3XdPig9yUkAsFxUEphjTQn0Lu1zqF/MutH5j10GfB9FrpZ3IaW+SFxfVu 5xD7FMRdZFwvuo52NcAeKGgIPknNMrEQ14b+cSjGTyGV6Aet+Z0Z0dsPyt3sJ+jGaHQ== X-Gm-Gg: AZuq6aLENEKQWyWLQkm16qF2O7xq82qK60lO6V3t51LFuto+00miweqYX8dKqOBphI/ 8IGblXdi0U8j5Oc+3hS/qzAw5cDaFTNIKZh3Mp7nFWq+Orx/3lkPD1zQziDWz6EDPgX/NKOsLuB Ow996rz/Rj/XPR7Yd6fAOVaxUCcUfDmCJr2LKAcgAR47lUHxwiAnoSlmrJBrTzEGCW97a1OerOP 089UwAR8e4YBpuspPdUx0LYJlSVTAcdbzIS8AlwX62b0WmtUVBvuBeuj5jsHPScxa1WWsn9Dwz3 8nu8GvN8JYc/eFjSTiXZlqfRcbeGuW6ea51v2UwlkaTAl4O1ozYTxM39J+iGD0R8tImyIcHIZbC LaJTtwdTMllY/lDljrE/8 X-Received: by 2002:a05:600c:3b08:b0:480:1c69:9d36 with SMTP id 5b1f17b1804b1-483a95eacf7mr181851105e9.17.1771934796391; Tue, 24 Feb 2026 04:06:36 -0800 (PST) X-Received: by 2002:a05:600c:3b08:b0:480:1c69:9d36 with SMTP id 5b1f17b1804b1-483a95eacf7mr181850485e9.17.1771934795769; Tue, 24 Feb 2026 04:06:35 -0800 (PST) Received: from [192.168.88.32] ([216.128.9.5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c00d0csm26850618f8f.11.2026.02.24.04.06.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 04:06:35 -0800 (PST) Message-ID: Date: Tue, 24 Feb 2026 13:06:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: atlantic: fix reading SFP module info on some AQC100 cards To: Tiernan Hubble , Igor Russkikh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260223004139.1444811-1-thubble@thubble.ca> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260223004139.1444811-1-thubble@thubble.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/23/26 1:41 AM, Tiernan Hubble wrote: > @@ -992,15 +1024,15 @@ static int aq_ethtool_get_module_info(struct net_device *ndev, > > /* Module EEPROM is only supported for controllers with external PHY */ > if (aq_nic->aq_nic_cfg.aq_hw_caps->media_type != AQ_HW_MEDIA_TYPE_FIBRE || > - !aq_nic->aq_hw_ops->hw_read_module_eeprom) > + !aq_ethtool_can_read_module_eeprom(aq_nic)) > return -EOPNOTSUPP; > > - err = aq_nic->aq_hw_ops->hw_read_module_eeprom(aq_nic->aq_hw, > + err = aq_ethtool_read_module_eeprom(aq_nic, > SFF_8472_ID_ADDR, SFF_8472_COMP_ADDR, 1, &compliance_val); I'm sorry for nit picking, but here and later this leads a quite bad indentation. You should reformat the whole argument list according to the kernel coding style, i.e. err = aq_ethtool_read_module_eeprom(aq_nic, SFF_8472_ID_ADDR, SFF_8472_COMP_ADDR, 1, &compliance_val); /P