From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.48.22 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794943329; b=iKilCR3mQkgqoX/rav/KjQbRqDyIWj9gvz+Dc0/kVMMqGstxpvBJWBB0qUIu84zg3V0l MLVm0NnPsqAr/YNqIxvlkPAlt/Lv/Dy14qlNMat7dvG2um+cPxZJ0H5EWY1GYl5ZDpms7 Mzl8sTikO3HxmVBQiMzEzCLr5mHE5xphqVx73GXND7CWHaRSAsIpVI5N41pvEWqSbLPs8 GczNWwDd10/HJmtJ1kTy97Rr/hskaUZU0CUOLqi0nByqkeJcREq6fT5Hr3CRKdlLyn5gz ey7gEVne38ASQu96xE2/Wge1/aKTrY6ag0hvSN4judsaxGOSvI7ZkxDOvtoPbD0r7jA== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794943329; h=DMARC-Filter:DKIM-Signature:Received:Received: X-MS-Exchange-Authentication-Results:Received-SPF:Received:Received: Received:Received:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type:X-NV-OnPremToCloud:X-EOPAttributedMessage: X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic: X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck: X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam: X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-Id: X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=P0nl3az0FrnI86MzNYtGIeDDnt/B5ura6HZHXXE3EeU=; b=ucqOdMJiEt8ufduFLkVzBBXX1KZPfHEvCTm6SAI0pedzVyfuTlC6CnSyLlioZb+mA6KG jaahPxGHn1fSfw4yrjg0A5s27GH9pyFFE5EmN9dpE7vLLJA8znI+KFISk6t63yinJSWQm mb9TJz0vrjlgVQJhssiUwTP1J+Im874EWmORarhE08eORajUQs2hV2QD60LueWoa8ca91 1fOGPo5NyXxGlPnmcnm4PWgukBMqaeJ8aBb545ppNrQQGQy9GZUGNXxIVDemkkGCeRT61 BreOSna0WB58/650Ahkt/blmEncZNFseKwhCnHQOSqzZ9DNqaz9yBhrGG4+s1LqxLOw== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=XsSt7yUJ; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.48.22 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012022.outbound.protection.outlook.com [52.101.48.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23232606A331 for ; Tue, 17 Nov 2026 19:22:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 23232606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=XsSt7yUJ ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ybbRBqvWG0yJ6kkTCOuqMUZMK+Yxa4rchX7M8z9IG8Fk8uQKwWvfK+RlcOgdc0JbiodsllYhyRcHT0FOUc7MpGbme+MbIQaFv3MbpXjnNRXq5OzKdzLsMI5hUGG++A09vWyThYufWTPw6mhlRG1P8In3I/9yyILYF84sIRcU849gOGm3V38AmJ5rJypivG7ugVVQJDPJZ6yO8UB0h41pn9yIg99t41UodvEFZZV6J1N1X+oLAOp4MHaXQObLs9BVxeL/glO7yiF6drGKkEzbkRweWVuz070nbFxq1ra78xEwEcZ138UxM6ZK6DDKJ9zah2WKDHew++u4ZbKaK49u6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0nl3az0FrnI86MzNYtGIeDDnt/B5ura6HZHXXE3EeU=; b=uxCZC4Q9AQTAbL8y3yJxqSPyusewd8VCm5J5usHuoRy60FBbZ7ymux8QncGqqq+8O08L0PlLgHJCD49qBKd84gmr/q7Q3rgeKjal6UqAb4OVqxwySo1SyRYKxfwQWtAGlBo/HFGcMxh62vh6utevuwTjPB7ff5kF2wx1cjRTbC9TV3pw61G2WPfEnTKkO5UtmoT3PNBTgriFgbYJB3/U4CeOkHqbaG5KNdFI15Y/UvdS3rm0AkpOfvLWQRNuscsiiyr3PO/9qSVI9oApG+bP1EOB4Up1BiE01qoAV4am3eiCR0uGXZR5MyvvWkAUVG7TiSAslfZPiEe5n4FPjIlLjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0nl3az0FrnI86MzNYtGIeDDnt/B5ura6HZHXXE3EeU=; b=XsSt7yUJfcHZERcfEjygy0B2JAOuQ9k8W6R85f7N6fvR1UuFH9433vBjeLgv2k+OhTRGvamP1+KgIHUppgKvZ8EKn0IJ/nCmMRVAAxZ5iLe9A5TJQn0uNSOuo8U609jp+F+SR4BMBa01z9Nr1hNG37tgQm5xIMcLWrYrKAM5oMIgUepn1CGtVVjrK26wrOzPgPWDUrTzPd8v3OJqZze4QlGL9dEG90LoJ8zNiLde6SqUidviSsq1cl6P462tDNTvCAHa/zAcmb1U8acL0Tr0VbDF6dVtBpbstvZ9Tg0Hkzh9MEx3IGPcwNpnGKGlj/7zCwoWSclizy28yCZbokyhUw== Received: from BL1PR13CA0154.namprd13.prod.outlook.com (2603:10b6:208:2bd::9) by SA1PR12MB9246.namprd12.prod.outlook.com (2603:10b6:806:3ac::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.10; Tue, 17 Nov 2026 19:22:03 +0000 Received: from BN2PEPF0000A990.namprd04.prod.outlook.com (2603:10b6:208:2bd:cafe::48) by BL1PR13CA0154.outlook.office365.com (2603:10b6:208:2bd::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.639.0 via Frontend Transport; Tue, 17 Nov 2026 19:22:03 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BN2PEPF0000A990.mail.protection.outlook.com (10.167.248.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Tue, 17 Nov 2026 19:22:02 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.57; Tue, 17 Nov 2026 11:21:36 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.57; Tue, 17 Nov 2026 11:21:35 -0800 Received: from Asurada-Nvidia.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.2562.57 via Frontend Transport; Tue, 17 Nov 2026 11:21:35 -0800 From: Nicolin Chen To: , CC: , , , , , , , , , , Cristian Prundeanu , Breno Leitao , , Subject: [PATCH v13 01/12] iommu: Pass in NULL old_domain when attaching a deferred device Date: Tue, 17 Nov 2026 11:21:18 -0800 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000A990:EE_|SA1PR12MB9246:EE_ X-MS-Office365-Filtering-Correlation-Id: be9ba46a-dd41-4a5e-31af-08df44e00f4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700016|7416014|23010399003|18002099003|6133799003|22082099003|261009223027099003|11063799006|56012099006|261102123227099003|261026121527099003|261021135927099003|261026140227099003|10067099003|261022075727099003|261028144727099003|261021121427099003|261022105027099003|261021123027099003; X-Microsoft-Antispam-Message-Info: ruywKT1L/zQo5jtffKvamoywthkcEcfNYEkCjJZxynLERE8g10wIakDslUquycF/9Lfpht81l/v/X1/3xmdmnsu5Glg7fLPDfvwErjI0s64Yc+QP9AL539aqTbDSp/gAzNO0jWPmryJVm1CZZeWucfjzdkIKbxnOxP5gJY4qWpNgmAW1pW/5vtUKYPw898nPC/fKWLPacRXP22o0hCAswolr4WXt89FGvH8vyNHz1JZrYr9NpzQLIOi5Y90oktgYTxJisfjLnysyrz/lJuDQSzN93AYBf5O9NtSfqwC51XZtAqWw54LckE0S5ud1o2CBiK5xN5OW/6E46djlFNQxzQEw9rc76l10MxxLNeeP2QeYUYjFpJDbWBiE+tF0pC76zWcNHfrM1N7ynLb8x2h/M+xR/2KPI2pY2IqVDc2sqjaVfC4jLCrvay7Jzrv2//7q96JnT1ung0d9jiGNW2xFnIlxMf1OeHYRoSmQRgWl7/jQl7uKF7fWa7O5KfjHfwgNQk29Z10maIphHDilQX8emHhP61i1haIifpnuhsCaIRDhgPR+fUmNFU2eEN0ayUCQomkjl74YiCjmF4ML2Yfg9ogTHWe9jtUyBlcKBKALpvT8u++A2S2L7ZHovnWf/2IrauRcQPTRRvE8MKr1I8t3DFJa0fEG9UK4J/pRNO6RiI78ztMTCdM81T7InWQoVD4J9LckctQ9o1DsXpeYVRl01w== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700016)(7416014)(23010399003)(18002099003)(6133799003)(22082099003)(261009223027099003)(11063799006)(56012099006)(261102123227099003)(261026121527099003)(261021135927099003)(261026140227099003)(10067099003)(261022075727099003)(261028144727099003)(261021121427099003)(261022105027099003)(261021123027099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JfXIBH6ienMAUj2U8bKTTgPVOsLm1C6WkrOsyU89LrB17bDbwxu2/dGijaYb2ClmwsJrK+vqpPDLj100+enaUUmicE3sDuro7Yao7WvKIxQpIPLU7WbhxgKO/TSaVkLQkxQTLfKxtWwjKYZQw1+Z9VZRDGvK5zUAGYDXwpqWq8Vv5x5YkJqCr9kk16H3TWmvgXy9kRZXP4Y0BF1o+44ka29CQFa9huyt19qJa6KCgFjsjD5q+vPu7w8qD1aUlmdZluTYQYKmw1a5gfhF0G/tpg6/wH6XEVOC2L7MV4C2RUYe6rvrMFsqBzSri5olArydKPyX6W46Iol20LISw66iklQID4a6Q30Wy2HVmLHBpnx6sjA9OLhDFMpDklvKpRP5YEqalK/9hGAxZgL/uOj3ueVnRwTHi2DwIAHIpK7Po8aQZUv8QOUKUPdL9hFXnj7g X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 19:22:02.8130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be9ba46a-dd41-4a5e-31af-08df44e00f4d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000A990.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB9246 When a driver defers the default domain attachment of a device, the IOMMU core skips the attachment in __iommu_device_set_domain() but still sets the group->domain to the group->default_domain. Since the driver has not seen this attachment, iommu_deferred_attach() later finalizes it by passing in a NULL old_domain. However, two other paths pass in the group->domain as the old_domain for a deferred device: - __iommu_device_set_domain(), when attaching a non-default domain - pci_dev_reset_iommu_prepare(), when attaching the group->blocking_domain A driver uses the given old_domain to clean up the device's state in that domain. However, a deferred device has no state in the group->domain, since the driver has never attached the device to it. So, the driver would end up cleaning up a state that does not exist. In practice, the first path is unlikely, since it requires the device to be attached to a non-default domain before its first DMA mapping. The second path is reachable when an ATS supported device gets reset before its first DMA mapping. Pass in a NULL old_domain on both paths for a deferred device. Note that pci_dev_reset_iommu_done() can keep using the group->domain for recovering the device, because pci_dev_reset_iommu_prepare() has unset the attach_deferred flag. This will be needed for the SMMUv3 driver to support the kdump mode, where it relies on the given old_domain to unreference the invalidation entries of a master. Signed-off-by: Nicolin Chen --- drivers/iommu/iommu.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index b486b8bbd1fcd..4585ffa9a73c9 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -2420,6 +2420,8 @@ static int __iommu_device_set_domain(struct iommu_group *group, if (new_domain == group->default_domain) return 0; dev->iommu->attach_deferred = 0; + /* The driver has never attached the device to old_domain */ + old_domain = NULL; } ret = __iommu_attach_device(new_domain, dev, old_domain); @@ -4059,8 +4061,13 @@ int pci_dev_reset_iommu_prepare(struct pci_dev *pdev) /* Stage RID domain at blocking_domain while retaining group->domain */ if (group->domain != group->blocking_domain) { + struct iommu_domain *old_domain = group->domain; + + /* The driver has never attached a deferred device */ + if (pdev->dev.iommu->attach_deferred) + old_domain = NULL; ret = __iommu_attach_device(group->blocking_domain, &pdev->dev, - group->domain); + old_domain); if (ret) { gdev->reset_depth--; return ret; -- 2.43.0