From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6BF431AF1B; Mon, 2 Mar 2026 18:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772474707; cv=none; b=UDzWWgzt1EvbHNlD6NnN5Hpl40qB9JPA7YB4PYcmFIcHDheS3s3T6KHSQS20yP1X98X+zMztu2aH5cKgovs8nS32X/B5wsT4WS4dZjtYerHpKfrMXPcAgDVJl/6qFDK2gOynyUPa+5YSUKZF2cWdyc8j1QoeRTnQCQTk/w0SJR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772474707; c=relaxed/simple; bh=dRWhp0jgiZYdaCpdVMWBg8XlmA5CRHdTjkT8z520rtA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lD3nNfHyzcvk1L1YjiNkgE0r00DiMq+jGlFPcOFgSZKBxhVZHHNp7oU9Lbsw+pkXCl8TuR8lZFtuIxKJ1+XKBeP3lGXkF9c62Q1N6Wunm5/SrCdHSRM2yp+BjhKE1JKHjr3VOV99vpw+2yPAE8sHHMx6J5lar/jQ55b9Kqzq0bM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=xgHA13mQ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="xgHA13mQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=dbpABA9JU9KyaoLnaTdX+Qzh6UTBVghyj5mUgAc/zc4=; b=xg HA13mQZ5O1YbCy2kc/VtLtTftOkFHafr3zOCksEaxiTMZKhZ0CBVcavvjdwQ2U5aUnKkRGAjwuao3 MWq05P4bkvs5AXWzKkgcRpVXVrnuQbVGWtJUGya9CcZPR6d5lkjNMQFW1PncpSRiUhoEw/WXwuFie 63ne8jAIS0bMsuA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vx7dO-009ibj-KT; Mon, 02 Mar 2026 19:04:46 +0100 Date: Mon, 2 Mar 2026 19:04:46 +0100 From: Andrew Lunn To: Jacky Chou Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Po-Yu Chuang , Joel Stanley , Andrew Jeffery , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, taoren@meta.com Subject: Re: [PATCH net-next v6 5/5] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC Message-ID: References: <20260302-rgmii_delay_2600-v6-0-68319a4c4110@aspeedtech.com> <20260302-rgmii_delay_2600-v6-5-68319a4c4110@aspeedtech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260302-rgmii_delay_2600-v6-5-68319a4c4110@aspeedtech.com> On Mon, Mar 02, 2026 at 06:24:32PM +0800, Jacky Chou wrote: > This change sets the rx-internal-delay-ps and tx-internal-delay-ps > properties to control the RGMII signal delay. > The phy-mode for MAC0–MAC3 is updated to "rgmii-id" to enable TX/RX > internal delay on the PHY and disable the corresponding delay > on the MAC. > > Signed-off-by: Jacky Chou > --- > arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts > index 3f2ca9da0be2..a2a1c1dbb830 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts > @@ -123,42 +123,54 @@ ethphy3: ethernet-phy@0 { > &mac0 { > status = "okay"; > > - phy-mode = "rgmii-rxid"; > + phy-mode = "rgmii-id"; > phy-handle = <ðphy0>; > > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_rgmii1_default>; > + > + rx-internal-delay-ps = <0>; > + tx-internal-delay-ps = <0>; In the binding, you said these default to 0. So you don't need them. It is also odd that rgmii-rxid becomes rmgii-id, yet both delays are 0? What was the bootloader doing? This is worth a comment in the commit messages. Andrew