From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 127F32E2850 for ; Tue, 26 May 2026 02:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779761653; cv=none; b=XtdGXKsdD18cw61hEVg7rlAPX8XIpArFRW5SpSJdPyEo6WwwvUGCfNxB7h3CQng8EX6OyD+MTDGnKwsEbR3DUlr+2NuFpqODJHJ3rCLE3qyJWCkr6kiP54lQiuPbi2qmlcVAl3/f+ESiEdFgNQyE9jsoge2RRgg+1Bic3EkGAmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779761653; c=relaxed/simple; bh=BzvrLMGYkgj1p7MKaYpBMN65DybuOjuCVzqRg624ldk=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=Nm1W/vW01bhoYX/yCVPjRHTO2rQxsurAqhPgHez7GOEMOVb+aKTCRX/GlAu2R2eJbadkRSdn+UBPJTKAPzd4QG9SYyCZb4zqjwIPyR0QmupeoRsK81/983Wosjt2GLxzMztP33oyfpoSjH0kPlrv8FGZSksBMUZK3bBsef3lk9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ssk0v4lz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ssk0v4lz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E6051F000E9; Tue, 26 May 2026 02:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779761651; bh=vMJro2FNfSWiXVq4zv/1oscD0Kiggb0QURyovkKp3M4=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=Ssk0v4lz3YeeRI8Ax/t+GrgAl3Zbk6IhgXLgK1bNbk0ZW4d8/Mp9mYmFLiTZkBOni JayrgcVzthtkvKowz8IF721ecQnbWnGwDZTrA6laIU8A2iIKQnEEuuoCce2hTI0sru Sd9TaAZVXsoLAjkQU/MG8biNt3XQcM/JC7HsPltZOiY2yqE1xwXyfTbOSZB0Fys+ai oyepomO73yu+7grOLnpnxVxBAGDYvYShozW+kKswJe6+ob6CfrdnPTao6/3S7XFd/v 9pEpeeLO+jszJkSY4U4SYT0mS8L7CJ12TAlAwB5TYsWjGTTs8BNff+zlW9rsPrnIKI 461MulTLE8QPA== Message-ID: Date: Tue, 26 May 2026 10:14:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, yuchao0@huawei.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com, stable@kernel.org Subject: Re: [PATCH] f2fs: stop checkpoint on compressed write IO error To: Wenjie Qi , jaegeuk@kernel.org References: <20260525061456.231710-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260525061456.231710-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/25/26 14:14, Wenjie Qi wrote: > Compressed data writes are accounted as F2FS_WB_CP_DATA because they > write compressed pages through fio->compressed_page. Their end_io path > should therefore have the same checkpoint-stop behavior as ordinary > F2FS_WB_CP_DATA writes. > > However, f2fs_compress_write_end_io() only records -EIO in the inode > mapping when the bio fails. The filesystem can keep checkpointing after > that failure, so a later checkpoint may persist metadata that points to > compressed data blocks whose writeback failed. > > Stop checkpointing with STOP_CP_REASON_WRITE_FAIL for failed compressed > F2FS_WB_CP_DATA writes, matching the ordinary data write end_io path. > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Cc: stable@kernel.org > Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu Thanks,