From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D62C433EF for ; Fri, 10 Sep 2021 06:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEF8061026 for ; Fri, 10 Sep 2021 06:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbhIJGZn (ORCPT ); Fri, 10 Sep 2021 02:25:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34387 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbhIJGZm (ORCPT ); Fri, 10 Sep 2021 02:25:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631255071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pnqlEhLtfhytMeRqppmfXFCckHKhqrWYsJrwlC/wIv4=; b=erByxi5Js2WtirE9MePbb//F6382h3Y/0nEIesNz7pWIj5PHiM4mu2DLGvNXlNxEOfRhaG GEspjQTUiTB+YXbgWqdm0jy2WcI+YC6SwBub8JV2FbDQeHOY1adfs+3t+QYLcAK4k384Q4 Oh/LXaix3STF4UN27C/8rSTPa5DzV0A= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-596-L9C-uhQqNLGEa0d5oZnbmA-1; Fri, 10 Sep 2021 02:24:29 -0400 X-MC-Unique: L9C-uhQqNLGEa0d5oZnbmA-1 Received: by mail-ej1-f69.google.com with SMTP id o14-20020a1709062e8e00b005d37183e041so516510eji.21 for ; Thu, 09 Sep 2021 23:24:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pnqlEhLtfhytMeRqppmfXFCckHKhqrWYsJrwlC/wIv4=; b=2UiQAg9Lvl6IonD1UqYq6SmTM//41YeEogogJsVzGTYYz+fubi5+NsWgPVnkp/gntt 92aNe9Cuvc8mCUncblK07fzASDw4SsszAzjNXjVTIuzm5+7ybcGzFopJEhVTDYX8HU6N n4K6KwkKlbekuvHq+QdFnIlHATPaMSCdQl+FlNDe9iRrMTkhonoZO//OAan+yUXSNpXw EcCYR9GHIntNJ6F6wzAOwMVEUGYEbIe5xWFLF2D5rhzj+Dj+3rBg1XnFt4snA8II7dMb OLSQei1v2qLqg6OfI4hmdrbojgPMbl2+SB5dbz5pUD18M8COO/YR5AnfFNAnWTopHO9P 1XLw== X-Gm-Message-State: AOAM533w0Pgng/ObJRgwdSXUZe8rQ0BG+HSr/pi2a45Pw3U4DZZQspHn oLa8xCeWX1BkGRXlb2olI+YXtUrWBk3TVB9JAwvcYUIg9R1qk+VK8bWhttgY/lnA4VcagGbx3nb pOnbsZRKzTnoyc8qJe0Zyx+0Q5MfSiwYdAuIcjTImw7kWr5BmnCFjIJ6SgKPPUt6i1mT/vAcdHs JT X-Received: by 2002:a17:906:5408:: with SMTP id q8mr7398376ejo.54.1631255068517; Thu, 09 Sep 2021 23:24:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySHpKwGqt60OguV1nAVbYXS6ixd+RRfr7vvv0dTOupfqnEpbcGDztj8pVK2vfAO7tCNUk0eg== X-Received: by 2002:a17:906:5408:: with SMTP id q8mr7398351ejo.54.1631255068242; Thu, 09 Sep 2021 23:24:28 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id gz22sm1926879ejb.15.2021.09.09.23.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 23:24:27 -0700 (PDT) Subject: Re: [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c To: Michael Straube , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210909211922.24872-1-straube.linux@gmail.com> From: Hans de Goede Message-ID: Date: Fri, 10 Sep 2021 08:24:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210909211922.24872-1-straube.linux@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/9/21 11:19 PM, Michael Straube wrote: > These macros are not used in the driver, remove them. > Found with GCC -Wunused-macros. > > Signed-off-by: Michael Straube Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > index 908022a17b3f..27fb1be036b8 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > @@ -15,20 +15,6 @@ > > #define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30) > > -#define SCAN_ITEM_SIZE 768 > -#define MAX_CUSTOM_LEN 64 > -#define RATE_COUNT 4 > - > -/* combo scan */ > -#define WEXT_CSCAN_HEADER "CSCAN S\x01\x00\x00S\x00" > -#define WEXT_CSCAN_HEADER_SIZE 12 > -#define WEXT_CSCAN_SSID_SECTION 'S' > -#define WEXT_CSCAN_CHANNEL_SECTION 'C' > -#define WEXT_CSCAN_ACTV_DWELL_SECTION 'A' > -#define WEXT_CSCAN_PASV_DWELL_SECTION 'P' > -#define WEXT_CSCAN_HOME_DWELL_SECTION 'H' > -#define WEXT_CSCAN_TYPE_SECTION 'T' > - > static int wpa_set_auth_algs(struct net_device *dev, u32 value) > { > struct adapter *padapter = rtw_netdev_priv(dev); >