From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C392BC4332F for ; Tue, 7 Nov 2023 10:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233826AbjKGKQz (ORCPT ); Tue, 7 Nov 2023 05:16:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233785AbjKGKQx (ORCPT ); Tue, 7 Nov 2023 05:16:53 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13409ED for ; Tue, 7 Nov 2023 02:16:49 -0800 (PST) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SPkf02dH9zfZxn; Tue, 7 Nov 2023 18:16:40 +0800 (CST) Received: from [10.174.176.88] (10.174.176.88) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 7 Nov 2023 18:16:00 +0800 Message-ID: Date: Tue, 7 Nov 2023 18:16:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next,V2] fscache: support to disable assert macro To: CC: , , , References: <20231101163414.2105727-1-wozizhi@huawei.com> From: Zizhi Wo In-Reply-To: <20231101163414.2105727-1-wozizhi@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.88] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500020.china.huawei.com (7.185.36.49) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org friendly ping 在 2023/11/2 0:34, WoZ1zh1 写道: > In fs/fscache/internal.h, ASSERT macro is enabled by default and can not > be disabled, then assert failure will crash the kernel as the BUG() is > included in the ASSERT macro. Therefore, add FSCACHE_ASSERT to control it. > > Signed-off-by: WoZ1zh1 > --- > fs/fscache/Kconfig | 10 ++++++++++ > fs/fscache/internal.h | 2 +- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/fs/fscache/Kconfig b/fs/fscache/Kconfig > index b313a978ae0a..7ff844038bc3 100644 > --- a/fs/fscache/Kconfig > +++ b/fs/fscache/Kconfig > @@ -38,3 +38,13 @@ config FSCACHE_DEBUG > enabled by setting bits in /sys/modules/fscache/parameter/debug. > > See Documentation/filesystems/caching/fscache.rst for more information. > + > +config FSCACHE_ASSERT > + bool "FSCACHE asserts" > + default n > + depends on FSCACHE > + help > + Support the ASSERT mode for failure behavior. > + Say N here to disable the ASSERT by default. > + Say Y to add assertion checks in some places. But the assertion > + failure will result in fatal errors that BUG() the kernel. > diff --git a/fs/fscache/internal.h b/fs/fscache/internal.h > index 1336f517e9b1..951166ed772f 100644 > --- a/fs/fscache/internal.h > +++ b/fs/fscache/internal.h > @@ -225,7 +225,7 @@ do { \ > /* > * assertions > */ > -#if 1 /* defined(__KDEBUGALL) */ > +#ifdef CONFIG_FSCACHE_ASSERT > > #define ASSERT(X) \ > do { \