From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8BEC41513 for ; Thu, 17 Aug 2023 10:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349767AbjHQKBg (ORCPT ); Thu, 17 Aug 2023 06:01:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349229AbjHQKBF (ORCPT ); Thu, 17 Aug 2023 06:01:05 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9792D2D61 for ; Thu, 17 Aug 2023 03:01:04 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4CFE0D75; Thu, 17 Aug 2023 03:01:45 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C69E43F64C; Thu, 17 Aug 2023 03:01:02 -0700 (PDT) Message-ID: Date: Thu, 17 Aug 2023 11:01:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] coresight: trbe: Allocate platform data per device Content-Language: en-US To: James Clark , Anshuman Khandual , hejunhao3@huawei.com Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathan.cameron@huawei.com, leo.yan@linaro.org, mike.leach@linaro.org, linuxarm@huawei.com, yangyicong@huawei.com, prime.zeng@hisilicon.com References: <20230814093813.19152-1-hejunhao3@huawei.com> <20230816141008.535450-1-suzuki.poulose@arm.com> <20230816141008.535450-2-suzuki.poulose@arm.com> <9cd9f83c-7778-2d87-a175-a4cb7ceb8723@arm.com> <3f681660-a0f0-20cb-b79b-7b2e2f6a1b5c@arm.com> From: Suzuki K Poulose In-Reply-To: <3f681660-a0f0-20cb-b79b-7b2e2f6a1b5c@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/08/2023 10:24, James Clark wrote: > > > On 17/08/2023 07:37, Anshuman Khandual wrote: >> Hi Suzuki, >> >> Seems like this patch is going to conflict with the below proposed change >> >> https://lore.kernel.org/all/20230817055405.249630-4-anshuman.khandual@arm.com/ >> >> Please let me know how should we resolve this conflict. > > We could merge them both, with the fixes: one first, just to acknowledge > that there was a problem. But I suppose your one will have to be rebased > on top. > >> >> On 8/16/23 19:40, Suzuki K Poulose wrote: >>> Coresight TRBE driver shares a single platform data (which is empty btw). >>> However, with the commit 4e8fe7e5c3a5 >>> ("coresight: Store pointers to connections rather than an array of them") >>> the coresight core would free up the pdata, resulting in multiple attempts >>> to free the same pdata for TRBE instances. Fix this by allocating a pdata per >>> coresight_device. >>> >>> Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver") >> >> The above mentioned commit i.e 4e8fe7e5c3a5 seems to be a more recent one which >> has triggered this problem. But would the problem be still there without that ? >> Else 'Fixes:' tag would need changing. >> > > Yes I think the fixes tag should point to 4e8fe7e5c3a5. Agreed, I will change the fixes tag and push this. Suzuki