From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbcLJWLP (ORCPT ); Sat, 10 Dec 2016 17:11:15 -0500 Received: from mout.web.de ([212.227.15.3]:51083 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbcLJWLN (ORCPT ); Sat, 10 Dec 2016 17:11:13 -0500 Subject: Re: [media] bt8xx: One function call less in bttv_input_init() after error detection To: Daniele Nicolodi References: Cc: linux-media@vger.kernel.org, Alexey Khoroshilov , Hans Verkuil , Mauro Carvalho Chehab , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Sat, 10 Dec 2016 23:10:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Ci4dNqdrO+3gFk4dpPFXSsj579R/EN4riyG6416UzNBOH5j8TNX H9IdIqHHAMpmAoygbIJkjtqzFuVtAq0jOyAL5ePmIidSv+aFWb9d+fZBhg68ypYNz+CeXYm BN0Szp9zlDpHYjPNIx533NCMK9a2dN0fPx3pesY7ObSVVVbcQf5B6Fbb55Lz/eV6mh1yRI6 h/kxaAFnVsFFLAgMN8Epg== X-UI-Out-Filterresults: notjunk:1;V01:K0:uEh6Iz0ennQ=:Wit+yI9CQTpkmNmOqTgZnq T8qgG+mA9LYQ4V1lAPO9S+Za1W+nCqNmImj9cfN8D4lQUX28gpWWjeO2+VaKbgOILyBAUqnZ0 M8xwG6GInfnjkR70VrBVuf/UU3YSU+lNLJVRUIMgCPQCwMi5IwOB2SNQ3kZzzi7e+TnCBSL9Z Y8s5e9HSgfcPsczHQMFrxvp0+QK+ysl3liLR0oFyPJHzyzLFtp8FRuJbvAzU4e70+xlWJNb1e UAKcxnipvWoqrQoFAZZ78PLXmWjgE+6VqNIhQvctSQKKLhGkvL/31AqrfVuuMrqHmcxuGFKwh wnfvj3mHT4irDxvi1Ig/wiBa7nKEAfdLxCypyFExlrmc/t9TRbQbnpQ54b4BzYcOB/LameLcm 1I6TMlHER48XLtGENm9+WO7MUvogaiEReGOQdMPmwooaUzXWeocKJa5MNsEsjWr7CFDBIYGdK NV1wxjjCFNDel9X3Zrrm1y5nXxIg4ltfs/2z2uoWo1guzLTh2eGfDrLpYlIN2ktj3D3rEqy1K tBYjnFnNnR77/hFacpJEe+Su+f5jzkDg8t1VfYFfNeyXpKyxzCb3BIdlJJ8B9QRERxiCuHgCD +ItxiW6Ll8tZ0QfsXJh6blmTZCmNcuB4XuKUQXGatG73IKhnJ4qMqrWp09YeeZR1f96K5vtdx JmKzPoET+X7HF8/oBSE6YnjTyU9rMi9W6IqkyeZW3E3InzrXot1w+waABlylWp9vTS6QNOIJd 7LPUdhzYCgaX6T9sPDa2/T7Y25hZ9NYKdQDD4BBHJEliwUaaZuQ1EPVdlNwYBUNjAOmDi7pHD Pm3cylI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > kfree() is safe to call on a NULL pointer. This is true. > Despite that, you have found several instances of similar constructs: Yes. - Special source code search pattern can point such places out for further considerations. > Didn't it occur to you that maybe those constructs are fine the way > they are and this is the idiomatic way to write that kind of code? Such a programming approach might look convenient. - I would prefer a safer coding style for the corresponding exception handling. > Why are you submitting patches implementing changes that have already > been rejected? The feedback to my update mixture is varying between acceptance and disagreements as usual. > Judging from your recent submissions, it seems that this process is not > working well for you. I'm probably not the only one that is wonderign > what are you trying to obtain with your patch submissions, other than > having your name in the git log. I am picking some change possibilities up in the hope of related software improvements. Regards, Markus