From: Gary R Hook <gary.hook@amd.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
"Hook, Gary" <ghook@amd.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
David Howells <dhowells@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback
Date: Fri, 2 Mar 2018 18:16:09 -0600 [thread overview]
Message-ID: <d3b268a9-1ebe-d9bd-01db-a513538e74c5@amd.com> (raw)
In-Reply-To: <7deb1115-b4b2-8fe3-885f-0162f2fe359f@maciej.szmigiero.name>
On 03/02/2018 05:58 PM, Maciej S. Szmigiero wrote:
> On 03.03.2018 00:49, Hook, Gary wrote:
>> On 3/2/2018 5:15 PM, Maciej S. Szmigiero wrote:
>>>
>>> Thanks.
>>>
>>> However, what about the first patch from this series?
>>> Without it, while it no longer should cause a buffer overflow, in-kernel
>>> X.509 certificate verification will still fail with CCP driver loaded
>>> (since CCP RSA implementation has a higher priority than the software
>>> RSA implementation).
>>>
>>> Maciej
>>>
>>
>>
>> I commented on that one here:
>> https://marc.info/?l=linux-crypto-vger&m=151986452422791&w=2
>>
>> Effectively a NACK. We are a reviewing a proposed patch right now.
>
> Your earlier comment referred to the third patch from this series.
> My message above was about the first one.
Apologies; my mistake.
next prev parent reply other threads:[~2018-03-03 0:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 16:03 Maciej S. Szmigiero
2018-03-01 0:34 ` Gary R Hook
2018-03-02 16:44 ` Herbert Xu
2018-03-02 23:15 ` Maciej S. Szmigiero
2018-03-02 23:49 ` Hook, Gary
2018-03-02 23:58 ` Maciej S. Szmigiero
2018-03-03 0:16 ` Gary R Hook [this message]
2018-03-04 12:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b268a9-1ebe-d9bd-01db-a513538e74c5@amd.com \
--to=gary.hook@amd.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ghook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®