From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Hongfu Li <hongfu.li@linux.dev>, willy@infradead.org
Cc: akpm@linux-foundation.org, liam@infradead.org,
lihongfu@kylinos.cn, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, ljs@kernel.org, mhocko@suse.com,
rppt@kernel.org, surenb@google.com, vbabka@kernel.org
Subject: Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers
Date: Mon, 20 Jul 2026 09:24:14 +0100 [thread overview]
Message-ID: <d3b2b0cb-7934-4f9a-ad25-f7af3fdd1d8c@kernel.org> (raw)
In-Reply-To: <20260720013703.4257-1-hongfu.li@linux.dev>
On 7/20/26 02:37, Hongfu Li wrote:
>>> From: Hongfu Li <lihongfu@kylinos.cn>
>>>
>>> unlock_page(), end_page_writeback() and wait_on_page_writeback()
>>> are void wrappers forwarding to folio-based functions which also
>>> return void. Explicit return statements here are syntactically valid
>>> but unnecessary, and inconsistent with other nearby compat helpers
>>> such as mark_page_accessed() and set_page_writeback().
>>>
>>> Drop all these superfluous return keywords.
>>
>> why bother? this file is temporary scaffolding. if they offend you so
>> much, work on removing the need for them.
>
> Thanks a lot for your comments.
>
> I fully agree with your point. You've already made great progress cleaning
> up this temporary scaffolding. I will follow your lead and keep working
> on reducing usages of these helper functions.
As much as I agree, this patch here is perfectly fine.
--
Cheers,
David
prev parent reply other threads:[~2026-07-20 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 7:20 Hongfu Li
2026-07-17 8:42 ` Lorenzo Stoakes (ARM)
2026-07-17 8:55 ` David Hildenbrand (Arm)
2026-07-17 10:31 ` Hongfu Li
2026-07-17 17:29 ` Matthew Wilcox
2026-07-20 1:37 ` Hongfu Li
2026-07-20 8:24 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b2b0cb-7934-4f9a-ad25-f7af3fdd1d8c@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hongfu.li@linux.dev \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®