From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FD2C23816D for ; Tue, 30 Sep 2025 16:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759249875; cv=none; b=oQCv0+2G7HmQ80qPVFMR6rx4GeENDs4zc4dQrAWS4d/P+y6CYs8sNlfk+y3eX2oQuU8kKLwcKF5xT53SXwEpFfsIHamMd9i7/2VTxgmGbHWHp0mEJbuM9gaQWP0PVnsyQpmOSbMswi/HxvyIzaukzjhspzivhZwRJIu+U00TeOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759249875; c=relaxed/simple; bh=KrP72lI1FFAU2CtrhllKwhHy148gk9UN/Wkcz+o+ngg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fgl27rtsOYAivoZq4+rfNK/0TId+1yXCW6RG44IizVabrXRJVp9HObER7eG91sktpXVnS7me2MA/IrNS4wl+61dzmmzQiE2Gx+7omwhRt2FiQqcPa+gWGKXZAU2j7ArmDy3YFbWfvcrNhXNTS0nhkfu/poMZ1tNciV+ldvlbevA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=g4tLbS+Y; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="g4tLbS+Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1759249872; bh=KrP72lI1FFAU2CtrhllKwhHy148gk9UN/Wkcz+o+ngg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=g4tLbS+YDrZR5+xReW7WBOtYQiZFTrR36tzXP/piGDwK85kdUgalxR2uM5HSxQb+N 5976la+hwmd6cqqWFJEocRw1uesEkO9vuDgBU8XOKZQ4ed9iC73uVKYj2Lo7mDtdeJ sOjURRuVZewAjo+vk88vMvrnC8H4OC1nDdyMMG87h/F8/OEHKVxE/lPiryPCfloYnw RFW36AmuyIRWvrSiqblWxrkAsXf2D/4FTK3PTlWJ7Ms0cs218c8dYtxyOkSpzlnQJ/ hWMI2O2+ecGS0YsHbbCc4vizwY7B+MymOeEvpVLKnHHsSC8e0GRGl/Q+EK+F8igYJ3 iunHfmMC2LUQg== Received: from [IPV6:2a01:e0a:5e3:6100:7aed:fe0e:8590:cbaa] (unknown [IPv6:2a01:e0a:5e3:6100:7aed:fe0e:8590:cbaa]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: loicmolinari) by bali.collaboradmins.com (Postfix) with ESMTPSA id 604E117E0AC3; Tue, 30 Sep 2025 18:31:11 +0200 (CEST) Message-ID: Date: Tue, 30 Sep 2025 18:31:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] drm/panthor: Introduce huge tmpfs mount point option To: Boris Brezillon Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Hugh Dickins , Baolin Wang , Andrew Morton , Al Viro , =?UTF-8?Q?Miko=C5=82aj_Wasiak?= , Christian Brauner , Nitin Gote , Andi Shyti , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, kernel@collabora.com References: <20250929200316.18417-1-loic.molinari@collabora.com> <20250929200316.18417-7-loic.molinari@collabora.com> <20250930123416.4ff59b11@fedora> Content-Language: fr From: =?UTF-8?Q?Lo=C3=AFc_Molinari?= Organization: Collabora Ltd In-Reply-To: <20250930123416.4ff59b11@fedora> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30/09/2025 12:34, Boris Brezillon wrote: > On Mon, 29 Sep 2025 22:03:14 +0200 > Loïc Molinari wrote: > >> diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/panthor/panthor_device.h >> index 4fc7cf2aeed5..54ca61567426 100644 >> --- a/drivers/gpu/drm/panthor/panthor_device.h >> +++ b/drivers/gpu/drm/panthor/panthor_device.h >> @@ -135,6 +135,9 @@ struct panthor_device { >> /** @devfreq: Device frequency scaling management data. */ >> struct panthor_devfreq *devfreq; >> >> + /** @huge_mnt: tmpfs mount point with Transparent Hugepage enabled. */ >> + struct vfsmount *huge_mnt; > > Now that we have a helper to create a huge mountpoint, wouldn't it > make sense to have this field in drm_device instead of having each > driver add a huge_mnt field to their _device object. Not sure this should be enforced for all DRM drivers since most of them don't create separate huge mountpoints (only 4 for now including this patchset) and I guess some maintainers might prefer to depend on the sysfs interace to enable huge pages. >> + >> /** @unplug: Device unplug related fields. */ >> struct { >> /** @lock: Lock used to serialize unplug operations. */ > Loïc