mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muzaffer Kadir <muzafferkadir@mainlining.org>
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Ulf Hansson <ulfh@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	"Joerg Roedel (AMD)" <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>, Lee Jones <lee@kernel.org>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Robert Marko <robimarko@gmail.com>,
	Guru Das Srinagesh <linux@gurudas.dev>,
	Amit Kucheria <amitk@kernel.org>,
	Thara Gopinath <thara.gopinath@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>, Kees Cook <kees@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	David Heidelberg <david@ixit.cz>,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	iommu@lists.linux.dev, mfd@lists.linux.dev,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-pm@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v3 16/19] thermal: qcom: tsens: Add support for MSM8952 tsens
Date: Tue, 29 Sep 2026 15:09:27 +0300	[thread overview]
Message-ID: <d3b99da7-bc64-4df8-94ab-25080474ee35@mainlining.org> (raw)
In-Reply-To: <4de27200-3598-47b7-b0af-8f7acd037618@oss.qualcomm.com>

Hi Daniel,

On Tue, 29 Sep 2026 09:11:28 +0200, Daniel Lezcano wrote:
> On 9/21/26 20:19, Muzaffer Kadir via B4 Relay wrote:
>> From: Muzaffer Kadir <muzafferkadir@mainlining.org>
>>
>> Add MSM8952 support for tsens.
>>
>> Downstream does a lot of advanced things with calculations.
>> But seems like using tsens-v1 directly works too.
> 
> Can you elaborate a bit the changelog please ?
> 
> Thanks
> 

MSM8952 has 11 sensors
and 3200 default slope (according to downstream)

For tests, this is the table for readings:
tsens sensor 0  1  2  3  4  5  6  7  8  9  10
TWRP         32 31 29 28 28 31 30 30 30 32 30
this patch   31 29 31 29 29 31 30 31 31 30 30

Both are read from same device, one after the other,
First upstream then TWRP.
2 degree difference seems reasonable in my idea,
as there is a reboot process happens in between reads and
downstream has more power saving features than this port.

I don't know any way to independently measure temperature.

I reused offsets and slope from downstream.

My commit message wasn't good, I will expand the
commit message by v4.

Best regards,
Muzaffer Kadir

  reply	other threads:[~2026-09-29 12:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 18:18 [PATCH v3 00/19] Add Initial Support For MSM8952, Add General Mobile Shamrock Muzaffer Kadir via B4 Relay
2026-09-21 18:18 ` [PATCH v3 01/19] dt-bindings: clock: qcom: Add MSM8952 global clock controller Muzaffer Kadir via B4 Relay
2026-09-25 13:39   ` Krzysztof Kozlowski
2026-09-21 18:18 ` [PATCH v3 02/19] clk: qcom: Add global clock controller driver for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-22 20:36   ` Abel Vesa
2026-09-21 18:18 ` [PATCH v3 03/19] dt-bindings: nvmem: Add compatible " Muzaffer Kadir via B4 Relay
2026-09-21 18:18 ` [PATCH v3 04/19] dt-bindings: power: rpmpd: Add MSM8952 power domains Muzaffer Kadir via B4 Relay
2026-09-27 17:47   ` Krzysztof Kozlowski
2026-09-28 13:57   ` Ulf Hansson
2026-09-21 18:18 ` [PATCH v3 05/19] dt-bindings: mmc: sdhci-msm: Add MSM8952 compatible Muzaffer Kadir via B4 Relay
2026-09-27 17:47   ` Krzysztof Kozlowski
2026-09-29 13:34   ` Ulf Hansson
2026-09-21 18:18 ` [PATCH v3 06/19] dt-bindings: vendor-prefixes: Add General Mobile Muzaffer Kadir via B4 Relay
2026-09-21 18:18 ` [PATCH v3 07/19] dt-bindings: arm: qcom: Document MSM8952 SoC binding Muzaffer Kadir via B4 Relay
2026-09-21 18:18 ` [PATCH v3 08/19] dt-bindings: iommu: qcom,iommu: Add MSM8952 IOMMU to SMMUv2 compatibles Muzaffer Kadir via B4 Relay
2026-09-27 17:49   ` Krzysztof Kozlowski
2026-09-21 18:19 ` [PATCH v3 09/19] dt-bindings: mfd: qcom,tcsr: Add compatible for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-27 17:48   ` Krzysztof Kozlowski
2026-09-21 18:19 ` [PATCH v3 10/19] dt-bindings: display/msm: qcom, mdp5: Add MSM8952 compatible Muzaffer Kadir via B4 Relay
2026-09-27 17:48   ` Krzysztof Kozlowski
2026-09-21 18:19 ` [PATCH v3 11/19] dt-bindings: firmware: qcom,scm: Document MSM8952 SCM Muzaffer Kadir via B4 Relay
2026-09-27 17:48   ` Krzysztof Kozlowski
2026-09-21 18:19 ` [PATCH v3 12/19] dt-bindings: clock: qcom,rpmcc: Add MSM8952 compatible Muzaffer Kadir via B4 Relay
2026-09-27 17:50   ` Krzysztof Kozlowski
2026-09-21 18:19 ` [PATCH v3 13/19] drm: msm: mdp5: Add MDP5 configuration for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-21 18:19 ` [PATCH v3 14/19] soc: qcom: ubwc: Add UBWC config " Muzaffer Kadir via B4 Relay
2026-09-21 18:19 ` [PATCH v3 15/19] dt-bindings: thermal: tsens: Add MSM8952 Muzaffer Kadir via B4 Relay
2026-09-27 17:51   ` Krzysztof Kozlowski
2026-09-21 18:19 ` [PATCH v3 16/19] thermal: qcom: tsens: Add support for MSM8952 tsens Muzaffer Kadir via B4 Relay
2026-09-29  7:11   ` Daniel Lezcano
2026-09-29 12:09     ` Muzaffer Kadir [this message]
2026-09-21 18:19 ` [PATCH v3 17/19] arm64: dts: qcom: Add initial support for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-21 18:19 ` [PATCH v3 18/19] dt-bindings: input: touchscreen: goodix: Add binding for GT970 Muzaffer Kadir via B4 Relay
2026-09-27 17:52   ` Krzysztof Kozlowski
2026-09-21 18:19 ` [PATCH v3 19/19] arm64: dts: qcom: generalmobile-shamrock: new device Muzaffer Kadir via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3b99da7-bc64-4df8-94ab-25080474ee35@mainlining.org \
    --to=muzafferkadir@mainlining.org \
    --cc=abelvesa@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=daniel.lezcano@oss.qualcomm.com \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gpiccoli@igalia.com \
    --cc=iommu@lists.linux.dev \
    --cc=jbrunet+clk@baylibre.com \
    --cc=jesszhan0024@gmail.com \
    --cc=joro@8bytes.org \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@gurudas.dev \
    --cc=lukasz.luba@arm.com \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mfd@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=robin.murphy@arm.com \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@kernel.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=srini@kernel.org \
    --cc=thara.gopinath@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=tzimmermann@suse.de \
    --cc=ulfh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®