mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@collabora.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mehdi Djait <mehdi.djait@linux.intel.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Frank Li <Frank.li@nxp.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: synopsys: VIDEO_DW_MIPI_CSI2RX should depend on ARCH_ROCKCHIP
Date: Tue, 27 Jan 2026 20:24:57 +0100	[thread overview]
Message-ID: <d3b9fe8c-688f-48a2-aa00-2f640dec079e@collabora.com> (raw)
In-Reply-To: <02ef452575fda61ca1d5d54086fec1223e3421a9.1769540923.git.geert+renesas@glider.be>

Hi Geert,

Thanks for the patch!

On 1/27/26 20:10, Geert Uytterhoeven wrote:
> The Synopsys DesignWare MIPI CSI-2 Receiver is currently only supported
> on Rockchip RK3568 SoCs.  Hence add a dependency on ARCH_ROCKCHIP, to
> prevent asking the user about this driver when configuring a kernel
> without Rockchip platform support.
> 
> The dependency can be relaxed later, when adding support for appropriate
> SoCs from other vendors (if any).

No objections from my side. I kicked out exactly this line when I moved
the driver from rockchip to synopsys, as I thought there shouldn't be
any Rockchip-specific bits.

Cc: Frank (since he aims to build upon this driver IIRC)

> 
> Fixes: 355a110040665e43 ("media: synopsys: add driver for the designware mipi csi-2 receiver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

AFAIC:

Acked-by: Michael Riesch <michael.riesch@collabora.com>

Regards,
Michael

> ---
>  drivers/media/platform/synopsys/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
> index e798ec00b1897560..8d0f5e3e8cd58eab 100644
> --- a/drivers/media/platform/synopsys/Kconfig
> +++ b/drivers/media/platform/synopsys/Kconfig
> @@ -4,6 +4,7 @@ source "drivers/media/platform/synopsys/hdmirx/Kconfig"
>  
>  config VIDEO_DW_MIPI_CSI2RX
>  	tristate "Synopsys DesignWare MIPI CSI-2 Receiver"
> +	depends on ARCH_ROCKCHIP || COMPILE_TEST
>  	depends on VIDEO_DEV
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on PM && COMMON_CLK


  reply	other threads:[~2026-01-27 19:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 19:10 Geert Uytterhoeven
2026-01-27 19:24 ` Michael Riesch [this message]
2026-01-28 15:39   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3b9fe8c-688f-48a2-aa00-2f640dec079e@collabora.com \
    --to=michael.riesch@collabora.com \
    --cc=Frank.li@nxp.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=hverkuil@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®