From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77198390CBF for ; Mon, 8 Jun 2026 07:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780904293; cv=none; b=SCpwNn8Y8+t5pEVEdPNx4HMnmzXqFfkyGtwy7uA7xMpbClRue1Q+d5pXYKmUDX43RKaMtFsv96PApAJlECXzO9JQvJn0Sh1NBTAT3d6f6Q43jsx3wWukdr+ekxe2R7DlDW7gq2Jb73KMAwd5xb3l3az4hGgx5fq1Wkm/8mxCw8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780904293; c=relaxed/simple; bh=Gj9H4HhPXQjCkY7uCmkaxSlWLYW3kXULZyjF99Y5z+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=odm6TD0E5viMzI4zXMe3D5EMWjgtQ2qr4Id+ljaRu6NRf7OZIAz5aWC7F2KL/FMrZYFzgknOZ9NcAuqORgX3h7tGwWdeRNvMQP9pNtFeGAS8UmGm5uTPJlxkanlVy5m/CPAdAFpHc1lcmSMOOWUhpDXHwXAsTncdAQaKhFu5iLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XdD8+cDH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PUahO3Wf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XdD8+cDH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PUahO3Wf" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586QrY42771578 for ; Mon, 8 Jun 2026 07:38:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kFyLb5NQMRlannRjdrU+C2uvM7tmZpLij7t0JT2ZFU4=; b=XdD8+cDHBmuNn/Ya 7Fd83crWGYV3WPx8Ye/oPfWDcv8U1E3TxFIMyEOj4OH0w5HAVmJVRnZTxSHeQ0jI JSl6CqVO6Wo/oPHfv1EpzW+4agFq1BeLQHHHbB3nOUGj1fVPAnIWHnPpa6Uf9Pr/ 0QP2Cx4C0zresZJIAjRHG584JqHYNoqy6ABYflgUnumnqfcsYgFT2jxO/rXaVkpF 2Gp+2ScLrMH3hGuwApopDedsrktEEUeEhGXg8tws8dmwYZ+iS8zNRbrDd3o1S08R ta9ZJFo1aAa/eaPs/Fd7oWYI7ZjyZAivQ0Nwt+goFIzACo4eIJ7TjKkCqALVpEbx G2Cz4g== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embx6eg1q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 07:38:10 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-517bdeceb54so1040181cf.2 for ; Mon, 08 Jun 2026 00:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780904290; x=1781509090; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kFyLb5NQMRlannRjdrU+C2uvM7tmZpLij7t0JT2ZFU4=; b=PUahO3Wf2IAQ9IDTM4AvLKGpOfhT/ZDAU6ed7RCOMFn8tWkdVORu3n5bysVqBbumwA R//jQ0oFhNvUgqYSVIUK3G8JuEok9nM3WPO93c+PM+ltTVxVfXpiIYusrKM62D6ERR9o nAHAIhl5PT8+i0xb+DFBlwbh7ylJb96/ImPV/0S9DtY/oZP6HlAnnKfVhG/NqDbe3Ox5 o1xeBqkk5OVFfdktw6Vizk9ZkGsARzsvObo4HSIdSooBbHP8Fu2BaOVuGsJSNF9RJBHZ +QSdmND0XMlTCKKfAAdgedMdkmKIqDM1psAbuwRpx1YMXxxcvF1h7Wm7e2aHft/xt9NJ yMGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780904290; x=1781509090; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kFyLb5NQMRlannRjdrU+C2uvM7tmZpLij7t0JT2ZFU4=; b=eXRyKzncK+aYrh/ycVwuJEkH+Vx/NlmtLWhgw1t1jYNDxdTE19NfDx8vpZQMVa1myE +XY9vHL5QaPqeNeX1uQMlLV4LdWe31W63S/6EnnAZa2wIxSfAcVg6o1Mq0weZNxW9D8k /jr7BpmHLMIS3SkQZlxupaCb2MSj4LnufW/0IwgLSQbP0PBnGQuxzClrGzyA42/X0kZ8 v3AE+efQFZz4a3Yv/QkfotKy498WOB95U9fE+sFEoHMTLcroaVE9mXjb3xdDF+jdmjlT BZFEBjrtQn17KS2IAcDvsxJ97Kp5j7nDcyzyCbqzlMT2UegEE+d+NBBzce4DZVQ6fxIv gJ+A== X-Forwarded-Encrypted: i=1; AFNElJ91EIvUpBvq04V1oZagWBq9Xu1FobfxFrgMdz6VeIR+Fe1kRZ0pkJccjfNo4wVHKhitTQ2IKdQx5oOAiNQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyNIkU+H2eY1z2Eeh9eMsXjz+gSQqTNBepvEf9gRkdvNbKmSp22 uXfxbrfFT7XzJfQpDdPC0hxHjntvBJiZzITymFEN+TXH2FbW8HqGudGMkmnr/nX5dIPBj8iyke/ +SI/gmybYF+WqtFhvnzXjpjEnR/C0Tugrzwz1AhiqE6xSSS83aAExP23Nmk+s3Nfd7lCCMeOU7z w= X-Gm-Gg: Acq92OGDjl7Gq3QGMdcrOjsm4WizSz5JTb8ev+41U1ZZH1gJ9Nts0drEAl+nOWZGl7j 2qGXlSPY9/AX/vfKGmGWRL6tHLBFJEw7VLIGXl0zBHeaIFFEIIGYeTigDhMCp3YkPLf55nnuNo6 y6qQu7emYKsLhJ79J/Oo+LWM2pmPFeEJdWEZ+NYbv/H/8icbTV/s9VKd0II6u5Z+0/5D8q42YTm IndcxlQXmbofcp2vuQ2mjCYwN+GYW4Mij+4dIOLYchZixUUb3L04ilCMjjoaV1TAMKg4ZXla/PE DW0F9l4guSnZePDbkElL0W7ALOGcD9+bCYyTTQ31I9MKRs3Mt6gFmWx1dlYCYkrKf3l5ilc+3Bs FfAD+VauwUOeo8bOyY7UzZ+jvc5KUwvVQqACqzd6EaLi0SYLlm7/qMXEP X-Received: by 2002:ac8:7f4d:0:b0:517:5e32:f3c2 with SMTP id d75a77b69052e-517959fed19mr127248101cf.1.1780904289778; Mon, 08 Jun 2026 00:38:09 -0700 (PDT) X-Received: by 2002:ac8:7f4d:0:b0:517:5e32:f3c2 with SMTP id d75a77b69052e-517959fed19mr127247831cf.1.1780904289312; Mon, 08 Jun 2026 00:38:09 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf055309368sm810757366b.49.2026.06.08.00.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 00:38:08 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 09:38:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] media: qcom: iris: fix runtime PM reference leaks To: Hungyu Lin , linux-media@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vikash.garodia@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, hverkuil@kernel.org, stefan.schmidt@linaro.org, Dmitry Baryshkov References: <20260607232841.79275-1-dennylin0707@gmail.com> <20260607232841.79275-2-dennylin0707@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260607232841.79275-2-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=cvmrVV4i c=1 sm=1 tr=0 ts=6a267162 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=C79_ONC1FbgHrQW08VoA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA2OCBTYWx0ZWRfX/FV16d7ccERO F4PzMRajjcgNNUomOs4Imn7P0TF+qt4MKLB8vBiKjRWLiqLmmucONzpH0a8qXoUB7wdwNlgqZYd o2C2V4P5ks+0RDmbTMEaVLOdNAGabvKyZ/zxJq/gKeXFYyjNedVI5iN2JnnSrnxBW+QSO/hMKBs TkW3JpOcsZ4cqSkALZZzD1W+AwzPth9Us20MtNCl1gvd8Z9NIRuzEj/sQm4a94sD/NUMtx2cmSQ Ku4UTX7LHSU4W8/lfpwgiEoCxpOIMHdqqifcq/ERHHF9dQ+tYit/ASsdzM4RF/VzYubj00rY9by uWhP24lbpsBJykkD8EosqPUAHo+zePcLKAnU3S7WcCfWQg83hTRbFGmUUE1yLDIoKycoz/LR8oj xwkbLb+YoUUa9VA3qnXHmB9SjljEQH4+OHWD/4iOoSoGA5NTh+sglzDlRGaDewLPNUdt5DcKr8W 13z6xB68kNX5LdLfarQ== X-Proofpoint-GUID: rjUnzVECmiEhbYjA7elWFIBzaKog-jy2 X-Proofpoint-ORIG-GUID: rjUnzVECmiEhbYjA7elWFIBzaKog-jy2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080068 On 6/8/26 1:28 AM, Hungyu Lin wrote: > Use pm_runtime_resume_and_get() in iris_enable_power_domains() > to avoid leaking a runtime PM usage count on failure. > > Also ensure pm_runtime_put_sync() is always called in > iris_disable_power_domains(), even when iris_opp_set_rate() > fails, so runtime PM references remain balanced. > > Fixes: bb8a95aa038e ("media: iris: implement power management") > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Hungyu Lin > --- > Changes in v4: > - Added Dmitry Baryshkov's Reviewed-by tag. > > drivers/media/platform/qcom/iris/iris_resources.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c > index 773f6548370a..f5e3341e1430 100644 > --- a/drivers/media/platform/qcom/iris/iris_resources.c > +++ b/drivers/media/platform/qcom/iris/iris_resources.c > @@ -78,11 +78,11 @@ int iris_enable_power_domains(struct iris_core *core, struct device *pd_dev) > if (ret) > return ret; > > - ret = pm_runtime_get_sync(pd_dev); > - if (ret < 0) > + ret = pm_runtime_resume_and_get(pd_dev); > + if (ret) > return ret; > > - return ret; > + return 0; > } "return pm_runtime_resume_and_get(pd_dev)" > > int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev) > @@ -90,12 +90,10 @@ int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev) > int ret; > > ret = iris_opp_set_rate(core->dev, 0); > - if (ret) > - return ret; > > pm_runtime_put_sync(pd_dev); > > - return 0; > + return ret; put_sync() can fail too Konrad