From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754479AbcH3OZo (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 10:25:44 -0400
Received: from mail-it0-f41.google.com ([209.85.214.41]:38431 "EHLO
        mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754380AbcH3OZk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 10:25:40 -0400
From: Pramod Kumar <pramod.kumar@broadcom.com>
References: <1472565240-31053-1-git-send-email-axel.lin@ingics.com> <1472565240-31053-2-git-send-email-axel.lin@ingics.com>
In-Reply-To: <1472565240-31053-2-git-send-email-axel.lin@ingics.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQHyAVVjNPPc9chen0jtCvNWI6XRxgLdTuZdoAqnjXA=
Date: Tue, 30 Aug 2016 19:55:33 +0530
Message-ID: <d3c59d19c72f896e27e0d99695124be4@mail.gmail.com>
Subject: RE: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner
 field in ns2_pci_phy_ops
To: Axel Lin <axel.lin@ingics.com>, Kishon Vijay Abraham I <kishon@ti.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jon Mason <jonmason@broadcom.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@ingics.com]
> Sent: 30 August 2016 19:24
> To: Kishon Vijay Abraham I
> Cc: Pramod Kumar; Andrew Lunn; Jon Mason; linux-kernel@vger.kernel.org;
> Axel Lin
> Subject: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner
> field in ns2_pci_phy_ops
>
> Add missing .owner field in ns2_pci_phy_ops, which is used for
refcounting.
> While at it, also makes ns2_pci_phy_ops const as it's never get
modified.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Reviewed-and-tested-by: Jon Mason <jon.mason@broadcom.com>
> ---
> This was sent on http://www.spinics.net/lists/netdev/msg383514.html
> Resent on https://lkml.org/lkml/2016/8/12/659
>  drivers/phy/phy-bcm-ns2-pcie.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-bcm-ns2-pcie.c
b/drivers/phy/phy-bcm-ns2-pcie.c
> index ee61772..4c7d11d 100644
> --- a/drivers/phy/phy-bcm-ns2-pcie.c
> +++ b/drivers/phy/phy-bcm-ns2-pcie.c
> @@ -47,8 +47,9 @@ err:
>  	return rc;
>  }
>
> -static struct phy_ops ns2_pci_phy_ops = {
> +static const struct phy_ops ns2_pci_phy_ops = {
>  	.init = ns2_pci_phy_init,
> +	.owner = THIS_MODULE,
>  };
>
>  static int ns2_pci_phy_probe(struct mdio_device *mdiodev)
> --

Looks fine to me.

Reviewed-by: Pramod Kumar <pramodku@broadcom.com>

> 2.5.0