From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933510AbcH3Rhj (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 13:37:39 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:42501 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932721AbcH3Rhd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 13:37:33 -0400
DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org AFBF561D68
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org
Subject: Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for
 tx_status
To: Vinod Koul <vinod.koul@intel.com>
References: <1471927691-28827-1-git-send-email-okaya@codeaurora.org>
 <1471927691-28827-4-git-send-email-okaya@codeaurora.org>
 <20160830170422.GN9355@localhost>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
        jcm@redhat.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Dan Williams <dan.j.williams@intel.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Dave Jiang <dave.jiang@intel.com>, linux-kernel@vger.kernel.org
From: Sinan Kaya <okaya@codeaurora.org>
Message-ID: <d3c5e9ca-2381-71e0-5b03-5bad68868b97@codeaurora.org>
Date: Tue, 30 Aug 2016 13:37:29 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160830170422.GN9355@localhost>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/30/2016 1:04 PM, Vinod Koul wrote:
> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote:
> 
>>  	spin_lock_init(&lldev->lock);
>> -	tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev);
> 
> ??
> 
> This is not described in changlog? If you are not using in anywhere else,
> then rst_task variable should be removed too..
> 

Sure, I can add more description. I thought I did mention that we are no longer
resetting the hardware in ISR. 

I can certainly mention that rst_task variable is removed and can get rid of it.
It is no longer in use.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.