From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Hector Martin <marcan@marcan.st>
Cc: sven@svenpeter.dev, robh+dt@kernel.org, marcan@marcan.st,
alyssa@rosenzweig.io, kettenis@openbsd.org, maz@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: apple: Add t6000/t6001 MacBook Pro 14/16" compatibles
Date: Thu, 9 Dec 2021 15:19:29 +0100 (CET) [thread overview]
Message-ID: <d3cb39b15900ad62@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211209051001.70235-2-marcan@marcan.st> (message from Hector Martin on Thu, 9 Dec 2021 14:09:58 +0900)
> From: Hector Martin <marcan@marcan.st>
> Date: Thu, 9 Dec 2021 14:09:58 +0900
>
> This adds the initial apple,t6000 platforms:
>
> - apple,j314s - MacBook Pro (14-inch, M1 Pro, 2021)
> - apple,j316s - MacBook Pro (16-inch, M1 Pro, 2021)
>
> And the initial apple,t6001 platforms:
>
> - apple,j314c - MacBook Pro (14-inch, M1 Max, 2021)
> - apple,j316c - MacBook Pro (16-inch, M1 Max, 2021)
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> .../devicetree/bindings/arm/apple.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> index b23c8dc5a27d..8d93e8a6cc18 100644
> --- a/Documentation/devicetree/bindings/arm/apple.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
> @@ -19,6 +19,13 @@ description: |
> - MacBook Air (M1, 2020)
> - iMac (24-inch, M1, 2021)
>
> + And devices based on the "M1 Pro" and "M1 Max" SoCs:
> +
> + - MacBook Pro (14-inch, M1 Pro, 2021)
> + - MacBook Pro (14-inch, M1 Max, 2021)
> + - MacBook Pro (16-inch, M1 Pro, 2021)
> + - MacBook Pro (16-inch, M1 Max, 2021)
> +
> The compatible property should follow this format:
>
> compatible = "apple,<targettype>", "apple,<socid>", "apple,arm-platform";
> @@ -60,6 +67,20 @@ properties:
> - apple,j457 # iMac (24-inch, 2x USB-C, M1, 2021)
> - const: apple,t8103
> - const: apple,arm-platform
> + - description: Apple M1 Pro SoC based platforms
> + items:
> + - enum:
> + - apple,j314s # MacBook Pro (14-inch, M1 Pro, 2021)
> + - apple,j316s # MacBook Pro (16-inch, M1 Pro, 2021)
> + - const: apple,t6000
> + - const: apple,arm-platform
> + - description: Apple M1 Max SoC based platforms
> + items:
> + - enum:
> + - apple,j314c # MacBook Pro (14-inch, M1 Max, 2021)
> + - apple,j316c # MacBook Pro (16-inch, M1 Max, 2021)
> + - const: apple,t6001
> + - const: apple,arm-platform
>
> additionalProperties: true
>
> --
> 2.33.0
next prev parent reply other threads:[~2021-12-09 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 5:09 [PATCH 0/4] dt-bindings: Add trivial Apple t6000/t6001 SoC bindings Hector Martin
2021-12-09 5:09 ` [PATCH 1/4] dt-bindings: arm: apple: Add t6000/t6001 MacBook Pro 14/16" compatibles Hector Martin
2021-12-09 14:19 ` Mark Kettenis [this message]
2021-12-09 17:12 ` Rob Herring
2021-12-09 5:09 ` [PATCH 2/4] dt-bindings: i2c: apple,i2c: Add apple,t6000-i2c compatible Hector Martin
2021-12-09 14:20 ` [PATCH 2/4] dt-bindings: i2c: apple, i2c: Add apple, t6000-i2c compatible Mark Kettenis
2021-12-09 16:34 ` [PATCH 2/4] dt-bindings: i2c: apple,i2c: Add apple,t6000-i2c compatible Sven Peter
2021-12-09 17:13 ` Rob Herring
2021-12-09 5:10 ` [PATCH 3/4] dt-bindings: pci: apple,pcie: Add t6000 support Hector Martin
2021-12-09 14:25 ` Mark Kettenis
2021-12-09 17:15 ` Rob Herring
2021-12-09 5:10 ` [PATCH 4/4] dt-bindings: pinctrl: apple,pinctrl: Add apple,t6000-pinctrl compatible Hector Martin
2021-12-09 14:25 ` [PATCH 4/4] dt-bindings: pinctrl: apple, pinctrl: Add apple, t6000-pinctrl compatible Mark Kettenis
2021-12-09 17:16 ` [PATCH 4/4] dt-bindings: pinctrl: apple,pinctrl: Add apple,t6000-pinctrl compatible Rob Herring
2021-12-12 4:04 ` [PATCH 0/4] dt-bindings: Add trivial Apple t6000/t6001 SoC bindings Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3cb39b15900ad62@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®