From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9744E3B9D98 for ; Wed, 10 Jun 2026 11:24:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781090681; cv=none; b=c61RfpNPDA3sguOU06EWeougtRVm0hJio+GBb2hpWB+FKq1AnOsCj9Wdw873ZyXUcy5Iat9aYMHK4vt1iDCUvVjigmMgj/97heXRnvcLUzfTeLl9mEIVbCarj5S+ueiej3D5XSvY/mQnYgIaBPLhixeLTfPDRa/yLrgH6sZJd5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781090681; c=relaxed/simple; bh=KjQMRB5Lh+PIOxK/gGbgCDNBaQme9ufzW1sZkgyg2uU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=FqLDB9bAhwtRFJfPpIhYjw//UeKEQ/C+27QvM+u+ohLdzW09yF7Fxs6rbjonQiBO6BKIrCNj+nmYCDEvKyKujIr68wA0zG+N6EMsbnuUMAR+F8pON7i8kpEQvNb7LMZoafGVkGuVwNrvFZ8rDfsq9n2yiblWdTn1NDTC+GtiD4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M3nfnVUr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M3nfnVUr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E87841F00898; Wed, 10 Jun 2026 11:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781090680; bh=68rnEy2Ju2fivHQsmk6rwdh19LpwaE7dKyVpigYKIjQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=M3nfnVUrNRW4KZj4XJfEKqPrC4ZvUReob2xv+/ExNxyUUptYsBuHiCg3Mrd87+RaI yZOg4YtFr44fcSgw4+2p4YTJVbCuVDWWsW6aPAnt0GHwlakZ5Vu0W6VGZL0ykRDO4U DvE4Jyikv0lYK9LLCoKpOpwBRMCwmons6lt9IO3eMsQjA1B+RL+O/AuQvJBolQ6axc qkUNghY01Ru5W++Xiu1LtYFgR6PFpVMeDL3jS4zkv6XFkhnQrk2irsdkmg1u6V6SxP Dj4MhsAt2mA6CtsTZ8WO8QRVoTPktakAma0o7oC4UbFklAr9DT6+vecB9hkE+xfBVw bc5N/IK+sLxWA== Message-ID: Date: Wed, 10 Jun 2026 19:24:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH] f2fs: honor per-I/O write streams for direct writes To: Jaegeuk Kim , Wenjie Qi References: <20260522061206.2405336-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/10/26 08:40, Jaegeuk Kim wrote: > On 05/22, Wenjie Qi wrote: >> io_uring can pass a per-I/O write stream through kiocb->ki_write_stream, >> and block direct I/O propagates that value to bio->bi_write_stream. >> >> F2FS added FDP stream mapping for DATA writes, but its direct write >> submit hook always rewrites bio->bi_write_stream from the inode write >> hint and F2FS temperature. As a result, a direct write with an explicit >> io_uring write_stream is submitted to the F2FS-selected stream instead >> of the user-requested stream. >> >> Validate an explicit write stream before starting F2FS direct I/O, pass >> the kiocb through the iomap private pointer, and preserve the per-I/O >> stream in the direct write bio. When no per-I/O stream is supplied, keep >> using the existing F2FS temperature-to-stream mapping. >> >> Fixes: 42f7a7a50a33 ("f2fs: map data writes to FDP streams") >> Signed-off-by: Wenjie Qi >> --- >> fs/f2fs/file.c | 30 +++++++++++++++++++++++++++--- >> 1 file changed, 27 insertions(+), 3 deletions(-) >> >> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >> index 71385ca4163d..20d6e7ab7416 100644 >> --- a/fs/f2fs/file.c >> +++ b/fs/f2fs/file.c >> @@ -5074,17 +5074,36 @@ static int f2fs_dio_write_end_io(struct kiocb *iocb, ssize_t size, int error, >> return 0; >> } >> >> +static bool f2fs_valid_write_stream(struct f2fs_sb_info *sbi, u8 write_stream) >> +{ >> + int i; >> + >> + if (!write_stream) >> + return true; >> + if (!f2fs_is_multi_device(sbi)) >> + return write_stream <= bdev_max_write_streams(sbi->sb->s_bdev); >> + >> + for (i = 0; i < sbi->s_ndevs; i++) >> + if (write_stream > bdev_max_write_streams(FDEV(i).bdev)) >> + return false; >> + return true; >> +} >> + >> static void f2fs_dio_write_submit_io(const struct iomap_iter *iter, >> struct bio *bio, loff_t file_offset) >> { >> struct inode *inode = iter->inode; >> struct f2fs_sb_info *sbi = F2FS_I_SB(inode); >> + struct kiocb *iocb = iter->private; >> enum log_type type = f2fs_rw_hint_to_seg_type(sbi, inode->i_write_hint); >> enum temp_type temp = f2fs_get_segment_temp(sbi, type); >> >> bio->bi_write_hint = f2fs_io_type_to_rw_hint(sbi, DATA, temp); >> - bio->bi_write_stream = >> - f2fs_io_type_to_write_stream(bio->bi_bdev, DATA, temp); >> + if (iocb->ki_write_stream) >> + bio->bi_write_stream = iocb->ki_write_stream; >> + else >> + bio->bi_write_stream = >> + f2fs_io_type_to_write_stream(bio->bi_bdev, DATA, temp); > > Let me apply as below. > > bio->bi_write_stream = > + iocb->ki_write_stream ? iocb->ki_write_stream : > f2fs_io_type_to_write_stream(bio->bi_bdev, DATA, temp); Reviewed-by: Chao Yu Thanks,