mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: Chao Yu <chao@kernel.org>, Derek McGowan <derek@mcg.dev>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] erofs: use buffered I/O for file-backed mounts by default
Date: Thu, 12 Dec 2024 22:46:02 +0800	[thread overview]
Message-ID: <d3ce3735-42c2-484a-84e1-8b70e5d53584@kernel.org> (raw)
In-Reply-To: <20241212134336.2059899-1-hsiangkao@linux.alibaba.com>

On 2024/12/12 21:43, Gao Xiang wrote:
> For many use cases (e.g. container images are just fetched from remote),
> performance will be impacted if underlay page cache is up-to-date but
> direct i/o flushes dirty pages first.
> 
> Instead, let's use buffered I/O by default to keep in sync with loop
> devices and add a (re)mount option to explicitly enable direct I/O
> if supported by the underlying files.
> 
> The container startup time is improved as below:
>                                       unpack        1st run  non-1st runs
> EROFS snapshotter buffered I/O file  4.586404265s  0.308s   0.198s
> EROFS snapshotter direct I/O file    4.581742849s  2.238s   0.222s
> EROFS snapshotter loop               4.596023152s  0.346s   0.201s
> Overlayfs snapshotter                5.382851037s  0.206s   0.214s
> 
> Fixes: fb176750266a ("erofs: add file-backed mount support")
> Cc: Derek McGowan <derek@mcg.dev>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

  reply	other threads:[~2024-12-12 14:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 13:35 [PATCH 1/4] erofs: add erofs_sb_free() helper Gao Xiang
2024-12-12 13:35 ` [PATCH 2/4] erofs: use `struct erofs_device_info` for the primary device Gao Xiang
2024-12-12 14:37   ` Chao Yu
2024-12-12 13:35 ` [PATCH 3/4] erofs: reference `struct erofs_device_info` for erofs_map_dev Gao Xiang
2024-12-12 14:42   ` Chao Yu
2024-12-12 23:54   ` [PATCH v2 " Gao Xiang
2024-12-12 13:35 ` [PATCH 4/4] erofs: use buffered I/O for file-backed mounts by default Gao Xiang
2024-12-12 13:43   ` [PATCH v2 " Gao Xiang
2024-12-12 14:46     ` Chao Yu [this message]
2024-12-12 14:29 ` [PATCH 1/4] erofs: add erofs_sb_free() helper Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3ce3735-42c2-484a-84e1-8b70e5d53584@kernel.org \
    --to=chao@kernel.org \
    --cc=derek@mcg.dev \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®