From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbdB1RMe (ORCPT ); Tue, 28 Feb 2017 12:12:34 -0500 Received: from ale.deltatee.com ([207.54.116.67]:52380 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbdB1RM1 (ORCPT ); Tue, 28 Feb 2017 12:12:27 -0500 To: Bjorn Helgaas References: <1488091997-12843-1-git-send-email-logang@deltatee.com> <20170228150920.GB12481@bhelgaas-glaptop.roam.corp.google.com> Cc: Keith Busch , Myron Stowe , Greg Kroah-Hartman , Bjorn Helgaas , Geert Uytterhoeven , Jonathan Corbet , "David S. Miller" , Andrew Morton , Emil Velikov , Mauro Carvalho Chehab , Guenter Roeck , Jarkko Sakkinen , Linus Walleij , Ryusuke Konishi , Stefan Berger , Wei Zhang , Kurt Schwemmer , Stephen Bates , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org From: Logan Gunthorpe Message-ID: Date: Tue, 28 Feb 2017 10:11:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170228150920.GB12481@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, stephen.bates@microsemi.com, kurt.schwemmer@microsemi.com, wzhang@fb.com, stefanb@linux.vnet.ibm.com, konishi.ryusuke@lab.ntt.co.jp, linus.walleij@linaro.org, jarkko.sakkinen@linux.intel.com, linux@roeck-us.net, mchehab@kernel.org, emil.l.velikov@gmail.com, akpm@linux-foundation.org, davem@davemloft.net, corbet@lwn.net, geert+renesas@glider.be, bhelgaas@google.com, gregkh@linuxfoundation.org, myron.stowe@gmail.com, keith.busch@intel.com, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v5 0/4] New Microsemi PCI Switch Management Driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This driver doesn't have anything to do with the PCI core, other than > using the pci_register_driver() interface (just like all other drivers > for PCI-connected devices), so drivers/pci doesn't really feel like > the right place for it. Putting it in drivers/pci leads to the sort > of confusion you mentioned above ("To make this entirely clear ..."). > > Would drivers/perf or drivers/misc/switchtec/ be possible places for > it? I made a similar argument when we made the decision of where to put the code. In the end, the device _is_ a PCI Switch and someone going through menuconfig or the source tree would probably look there first. As for drivers/perf, our device does a fair bit more than performance counters so it doesn't seem like it really fits in there. drivers/misc just seems like a dumping ground which we'd prefer not to contribute to. We also considered drivers/char (seeing it exposes a char device), but that also seems like a dumping ground with stuff that belongs and other stuff that just ended up stuck between the cracks. If you still feel strongly about this we can move it into misc, but I think from an organizational perspective pci/switch makes a bit more sense. In any case, I also wish we could have had this discussion 3 months ago when we posted the RFC and not when I have people pushing to get this merged. Thanks, Logan