From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6729C001DB for ; Mon, 3 Jul 2023 14:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231159AbjGCOiI (ORCPT ); Mon, 3 Jul 2023 10:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbjGCOiG (ORCPT ); Mon, 3 Jul 2023 10:38:06 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98DF094 for ; Mon, 3 Jul 2023 07:38:04 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4fb8574a3a1so7013674e87.1 for ; Mon, 03 Jul 2023 07:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688395083; x=1690987083; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ly7UoRFAfJIXz+VZaxLWPYiCxf0M8wVXDUzALvT+VJw=; b=P1Q+CDXgpdgM6oPIREepdtde+wYfYizdyI94xbx8/wNAN9yLHAGkLsy4MJWwTUXEaZ 360BaXS/bgSxxN9JO4b5QO+HGMWTUdYKCT4+cZSb7S6o5KccL6dluWHDCns/Yz6t2drP R/1K20vZIdpAP5B+DIZKM8jmnDq84q+WYFHVvlRQ3TlZ5ddc3iN8qbEiOvuEFuCLlZRW eaXmmud5RcSbX7zC+G855Yqcd0+4EYhDZdW3jJR4P0eE8YX7QChV+7S4DQMGjcxHp4bm uOLJI2clsyvbq0UWEgBwe5HMWdEfwo/eJLxBagF7/aevPiPa9GqQ4/GORry59dYmkyBX 8Msg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688395083; x=1690987083; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ly7UoRFAfJIXz+VZaxLWPYiCxf0M8wVXDUzALvT+VJw=; b=Krkh94U23DXZBWIrJDWRKpxV3KOBjedpDki0FJoRn8IIbg6Ueoepj7OkTBEeW6gyvB BW5HtmKRbhmtvM+f9JXcOfrohnxpmH5Cc4BJKbFv0F7EnGvpW1+1fErg7ya7S+6Q+JhF gtpw1xUxSfAlWlNcj2cPThMSmnZ4iSifwS9FXHzIEpcVqjbEPX+1cs1L0NmawM1piQba JGerFYungWAOWxle53ro4fyCbeyxUDkHMxb2CQPL4iF4p30Inoz0+5P5DjfOfKMNeN0v HPj8RPO835ppcRWpLUCplQvthFBFjYFg6jEOEcle4dFQcuB7BDnJ9McjQADpne5DQvDE Nd1g== X-Gm-Message-State: ABy/qLYp8DQcOosMrIytAwAZmjg5J5mZ3bq747mgsMwXbSo3uITh3UzR 2BT9+gc/NxT6thj+GgcJvvWOEVdJpQksO5MpnHuO3Q== X-Google-Smtp-Source: APBJJlFqk+6qejn9duPcCZsPljYfwRyF88tcjmxYswN/z+Qf/DKk0PiKz2qLPHygCRJ+3hv9aiNP2w== X-Received: by 2002:a05:6512:20d0:b0:4f7:4098:9905 with SMTP id u16-20020a05651220d000b004f740989905mr6057789lfr.65.1688395082833; Mon, 03 Jul 2023 07:38:02 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id y16-20020a197510000000b004fba5eb0a64sm2004685lfe.42.2023.07.03.07.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 07:38:02 -0700 (PDT) Message-ID: Date: Mon, 3 Jul 2023 16:38:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/5] dt-bindings: serial: geni-qcom: Allow no qup-core icc path Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Andi Shyti Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-i2c@vger.kernel.org References: <20230703-topic-8250_qup_icc-v1-0-fea39aa07525@linaro.org> <20230703-topic-8250_qup_icc-v1-2-fea39aa07525@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3.07.2023 16:01, Krzysztof Kozlowski wrote: > On 03/07/2023 15:31, Konrad Dybcio wrote: >> Some SoCs (like SM8150 and SM8250) don't seem to provide a qup-core path. >> Allow such case. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/serial/qcom,serial-geni-qcom.yaml | 26 +++++++++++++++------- >> 1 file changed, 18 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml >> index dd33794b3534..a0acba57bc06 100644 >> --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml >> +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml >> @@ -25,14 +25,6 @@ properties: >> clock-names: >> const: se >> >> - interconnects: >> - maxItems: 2 >> - >> - interconnect-names: >> - items: >> - - const: qup-core >> - - const: qup-config > > Instead please keep the definition of the fields in top-level properties > with the widest constraints, e.g. > interconnects: > minItems: 1 > maxItems: 2 > > interconnect-names: > minItems: 1 > items: > - const: qup-core > - const: qup-config Sadly the issue here is that the qup-config path exists, but qup-core doesn't. Konrad > > If there was allOf:if:then per variant, this could be further customized. > > Best regards, > Krzysztof >