From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1382175A8A; Sat, 3 Oct 2026 13:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791033467; cv=none; b=dzExDGj3HIPb8NRKsDVINI1oprjIIcReE8ffapTvvCBpLkpU96w9hUZTeVU9g7yA4ljJ6pNmiT6OpnHUgqYNCWm727/ILO3cXmaAXhDufCGbavQ7ApjSjFB32cG6ZKsR4LWn3XYjdH/5LOACFEeYxi04359h7+bMpj4pHS/hGjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791033467; c=relaxed/simple; bh=WtrnOYPfoCIVycA33AV23kjL/1nSMC2IR2IcPofxGjo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q84JIWNqpfnJSu84Vp76zB/AudUcyd7ZHbG1UKZvradYSJGpvT3NwsujJJb3AoFEj4hOrhfbxeVW/UJ7XcGrnM9zpZ6s8s2TNOLMBRKV0I1hA9CIL0Jt9f68rrXMQtQmXRdXMwqfa1IB4q4X9ALGEkRJ9Kwqda5S/eIObNyiFq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CAN/rVvg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CAN/rVvg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 638301F0089B; Sat, 3 Oct 2026 13:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791033465; bh=IzbNPOia8VMKvzs9m7iStPmTfA5edKy5GnhybPACNJg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=CAN/rVvgMSKtbA1KsHN4RGBkEoftMGFQkGSEnSQs+8AEVSkBCWecWeksf/WYsl1JG vex0FEYYejEF5KBKQs3a3h2WUWTGlrypAHO0jB7GcWDeXS+D/+znTX6DKUfidRG83X KItpx2EQPp7inJx6IFStH8dZ+eMtoE7P8nu9DjRFIQNUe6U/ssysH7A+cXRlIPm4Ai uS0zxXdr9FMT2JNfL9NgSa4w/DxjAmkHiv17gFyFjuKU7FUXI5TNUC3F06nl6tEBlE 3czGY7wygWYhTxNlVL3QeN/Tvv2nfFHUwj7QHwOyoenvU3RvYpzPX68Qt38Q5OaCdO N3Jr4jT5uXPxg== Message-ID: Date: Sat, 3 Oct 2026 15:17:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] media: Consolidate AtomISP v2 PCI IDs in the pci_ids.h To: Andy Shevchenko , Jani Nikula , Bjorn Helgaas , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-pci@vger.kernel.org Cc: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman References: <20261002094813.856439-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede Content-Language: en-US, nl In-Reply-To: <20261002094813.856439-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 2-Oct-26 11:43, Andy Shevchenko wrote: > We have a few drivers using same pair of the PCI IDs across the kernel and > there seems more to go, consolidate AtomISP v2 PCI IDs in pci_ids.h database. > > Signed-off-by: Andy Shevchenko Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Assuming that media subsystem is the main beneficiary I think it is the best > to route it via that tree. For others (i915, PCI, PDx86), please Ack if you > are agree. > > drivers/gpu/drm/i915/display/intel_display_power.c | 6 +++--- > drivers/platform/x86/intel/atomisp2/pm.c | 6 +++--- > drivers/staging/media/atomisp/pci/atomisp_internal.h | 2 -- > drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 10 +++++----- > include/linux/pci_ids.h | 2 ++ > 5 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c > index 2e534ddb7347..ee2c59b72b4a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -2086,9 +2086,9 @@ static void assert_ved_power_gated(struct intel_display *display) > static void assert_isp_power_gated(struct intel_display *display) > { > static const struct pci_device_id isp_ids[] = { > - {PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0f38)}, > - {PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x22b8)}, > - {} > + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ISP_BYT) }, > + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ISP_BSW) }, > + { } > }; > > drm_WARN(display->drm, !pci_dev_present(isp_ids) && > diff --git a/drivers/platform/x86/intel/atomisp2/pm.c b/drivers/platform/x86/intel/atomisp2/pm.c > index ad1f99140962..f3dee0e58f62 100644 > --- a/drivers/platform/x86/intel/atomisp2/pm.c > +++ b/drivers/platform/x86/intel/atomisp2/pm.c > @@ -121,9 +121,9 @@ static UNIVERSAL_DEV_PM_OPS(isp_pm_ops, isp_pci_suspend, > isp_pci_resume, NULL); > > static const struct pci_device_id isp_id_table[] = { > - { PCI_VDEVICE(INTEL, 0x0f38), }, > - { PCI_VDEVICE(INTEL, 0x22b8), }, > - { 0, } > + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ISP_BYT) }, > + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ISP_BSW) }, > + { } > }; > MODULE_DEVICE_TABLE(pci, isp_id_table); > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_internal.h b/drivers/staging/media/atomisp/pci/atomisp_internal.h > index 5a69580b8251..1a05fc331557 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_internal.h > +++ b/drivers/staging/media/atomisp/pci/atomisp_internal.h > @@ -37,7 +37,6 @@ > (((isp)->media_dev.hw_revision & ATOMISP_HW_REVISION_MASK) == \ > ((rev) << ATOMISP_HW_REVISION_SHIFT)) > > -#define ATOMISP_PCI_DEVICE_SOC_BYT 0x0f38 > /* MRFLD with 0x1178: ISP freq can burst to 457MHz */ > #define ATOMISP_PCI_DEVICE_SOC_MRFLD 0x1178 > /* MRFLD with 0x1179: max ISP freq limited to 400MHz */ > @@ -45,7 +44,6 @@ > /* MRFLD with 0x117a: max ISP freq is 400MHz and max freq at Vmin is 200MHz */ > #define ATOMISP_PCI_DEVICE_SOC_MRFLD_117A 0x117a > #define ATOMISP_PCI_DEVICE_SOC_ANN 0x1478 > -#define ATOMISP_PCI_DEVICE_SOC_CHT 0x22b8 > > #define ATOMISP_PCI_REV_MRFLD_A0_MAX 0 > #define ATOMISP_PCI_REV_BYT_A0_MAX 4 > diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > index 476fe143a591..ab8727a806bf 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > @@ -1239,7 +1239,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i > } > isp->hpll_freq = HPLL_FREQ_1600MHZ; > break; > - case ATOMISP_PCI_DEVICE_SOC_BYT: > + case PCI_DEVICE_ID_INTEL_ISP_BYT: > isp->media_dev.hw_revision = > (ATOMISP_HW_REVISION_ISP2400 > << ATOMISP_HW_REVISION_SHIFT) | > @@ -1284,7 +1284,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i > isp->dfs = &dfs_config_merr; > isp->hpll_freq = HPLL_FREQ_1600MHZ; > break; > - case ATOMISP_PCI_DEVICE_SOC_CHT: > + case PCI_DEVICE_ID_INTEL_ISP_BSW: > isp->media_dev.hw_revision = (ATOMISP_HW_REVISION_ISP2401 > << ATOMISP_HW_REVISION_SHIFT); > isp->media_dev.hw_revision |= pdev->revision < 2 ? > @@ -1487,12 +1487,12 @@ static const struct pci_device_id atomisp_pci_tbl[] = { > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, ATOMISP_PCI_DEVICE_SOC_MRFLD_1179)}, > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, ATOMISP_PCI_DEVICE_SOC_MRFLD_117A)}, > /* Baytrail */ > - {PCI_DEVICE(PCI_VENDOR_ID_INTEL, ATOMISP_PCI_DEVICE_SOC_BYT)}, > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ISP_BYT) }, > /* Anniedale (Merrifield+ / Moorefield) */ > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, ATOMISP_PCI_DEVICE_SOC_ANN)}, > /* Cherrytrail */ > - {PCI_DEVICE(PCI_VENDOR_ID_INTEL, ATOMISP_PCI_DEVICE_SOC_CHT)}, > - {0,} > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ISP_BSW) }, > + { } > }; > MODULE_DEVICE_TABLE(pci, atomisp_pci_tbl); > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 63774ae2bf71..0693e4532a68 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2732,6 +2732,7 @@ > #define PCI_DEVICE_ID_INTEL_HDA_HSW_3 0x0d0c > #define PCI_DEVICE_ID_INTEL_HDA_BYT 0x0f04 > #define PCI_DEVICE_ID_INTEL_SST_BYT 0x0f28 > +#define PCI_DEVICE_ID_INTEL_ISP_BYT 0x0f38 > #define PCI_DEVICE_ID_INTEL_8257X_SOL 0x1062 > #define PCI_DEVICE_ID_INTEL_82573E_SOL 0x1085 > #define PCI_DEVICE_ID_INTEL_82573L_SOL 0x108f > @@ -2787,6 +2788,7 @@ > #define PCI_DEVICE_ID_INTEL_VMD_201D 0x201d > #define PCI_DEVICE_ID_INTEL_HDA_BSW 0x2284 > #define PCI_DEVICE_ID_INTEL_SST_BSW 0x22a8 > +#define PCI_DEVICE_ID_INTEL_ISP_BSW 0x22b8 > #define PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN 0x2310 > #define PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX 0x231f > #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410