From: Stephen Boyd <sboyd@kernel.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Pin-yen Lin <treapking@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>,
linux-clk@vger.kernel.org, Pin-yen Lin <treapking@chromium.org>
Subject: Re: [PATCH] clk: mediatek: mt8183: Only enable runtime PM on mt8183-mfgcfg
Date: Mon, 01 Jul 2024 13:49:30 -0700 [thread overview]
Message-ID: <d3d91a26f205925c4d0197fbd977a6d3.sboyd@kernel.org> (raw)
In-Reply-To: <20240613120357.1043342-1-treapking@chromium.org>
Quoting Pin-yen Lin (2024-06-13 05:02:28)
> Commit 2f7b1d8b5505 ("clk: mediatek: Do a runtime PM get on controllers
> during probe") enabled runtime PM for all mediatek clock controllers,
> but this introduced an issue on the resume path.
>
> If a device resumes earlier than the clock controller and calls
> clk_prepare() when runtime PM is enabled on the controller, it will end
> up calling clk_pm_runtime_get(). But the subsequent
> pm_runtime_resume_and_get() call will fail because the runtime PM is
> temporarily disabled during suspend.
>
> To workaround this, introduce a need_runtime_pm flag and only enable it
> on mt8183-mfgcfg, which is the driver that observed deadlock previously.
> Hopefully mt8183-cfgcfg won't run into the issue at the resume stage
> because the GPU should have stopped rendering before the system calls
> suspend.
>
> Fixes: 2f7b1d8b5505 ("clk: mediatek: Do a runtime PM get on controllers during probe")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2024-07-01 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 12:02 Pin-yen Lin
2024-07-01 20:49 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d91a26f205925c4d0197fbd977a6d3.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=treapking@chromium.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®