From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C326D29B8D9 for ; Mon, 11 Aug 2025 06:43:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754894595; cv=none; b=qhHqismwUP88e7HsVM/GEE8mkJG185sVWBsMAfj1eJ7zjhPELb8f11eW+s0DNH1xJmuU1oQ29ULd4imE6nrE8j7L7gz/vfME3E5ljwcaVbLn5YpvRHfsKhbCQ1SEioBx51/hSLJy3Znr0CvkCyBZd51o7dkzw436cOIyB3fNn+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754894595; c=relaxed/simple; bh=cEn05/8gtRzmJHod10gCk03EvDC+5ybsS4jnchxKkv8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pEcpE9P2P3NDQGQMzciin7kH+eMBiMgls79HNkgCFtTm6E7psYomU19XpXgwy4QIBn/dm/cHbY/WN71PSgbkg7D9wWNfZUwK3SRTn38MShLsXvWJABqKDOulyOemYhigVca7gRut58kmpEgQGuXN/d8QVOdm/Pzvy2nSy/V6ZM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AYUHoZPf; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AYUHoZPf" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-617b526d402so579426a12.1 for ; Sun, 10 Aug 2025 23:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754894592; x=1755499392; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=GDk12v2vJL34l7+873CbL1ksmxiNCrMWuEVM/GTIuU8=; b=AYUHoZPf0NLt3hhB1QXkgByLG9X5w26eZeFqAxhXV/PYN2B9VzGO8BUaP64nE8O42y Exl7OCrr2L3X0NpproRPdamQqr1RS4VlQkawQyMQW+AjIUg1iMXvQS4FS4SV+ZmjwAg2 k8sBZAku65fHb4oJcWI9MR0owwX2mHfuFryfn4aQbV8Dn3svD2JBw/jHyDy7yQ3WCjA1 YwsbpFhOQ5NpKrZyIQHaSjXuCgD+eny8dfhimd9MxfXNwB7pap78lNgAWW6ku9U24zut lKSnMmk5H6q7AyIaJZUmz5hyGq0LbGLrUA+yn1QwciALgGnT+jPjO/CnFoE1L2za6h/y 90Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754894592; x=1755499392; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GDk12v2vJL34l7+873CbL1ksmxiNCrMWuEVM/GTIuU8=; b=fUGoWIGHpByYYy0ycoBVbXYZnQ9k8Dk4CNU0kxZlAkPLoxTN7QLagis+34owd9bc1M C/QyhsS1Maz8vhyBOvx3PNtrFDyrMJj1VHGqsuhp92ldWDL/CilFWeG9m8bHRlCZXb1Z jomoomNvB8JcGwo5rFWHam9+Oj9wTjMcIHpTTmdJC5S8pVypLa47ta/NwJdyDrApc7xy UsCJBkEhcXiE/nxnKLTMdB22AccpJRN6Jq4rVZPZpHyPRfgzBZ7vFNNC26YdskO82wLo qK7+Gl8Zps1HconXMrUQ/XuS+39Kl7vJgoBluMk/dZavrlWfk+OHMT8HO75VMbERQ6oE C16g== X-Forwarded-Encrypted: i=1; AJvYcCXrwTpqUln17045XEif57py9FgxG6xK0EDu/uJttP4QTNYogoo9OyEQhwSMK8rfJdaHwd2O1lEIW1cW2Ww=@vger.kernel.org X-Gm-Message-State: AOJu0YzfR4MtZQIoDVUbE8laGcOl0M+dofaqDxhNiqzUMzSPHldWYetW 7hDX4qVy+7erxi4v04uC/gF9p4JcGgcJ3AuN+/xMXIUiiiDhW6jCsAi/Sa4iUyzQpvA= X-Gm-Gg: ASbGncvPRYwVkVpV8r7Cl2IulbvEL8uSfNLoddMp2XmZgtVPQEDtKGuGd0XFTkURQsV 8m+ynCWPGGJeUkcL1b9p0cHS4odv9yzHTrrDlGmxqyVOy20k6+4+0+fLhoDZbKl9GpLu/4+WHdZ GksxDGrKxu8EIHg9LNgZf9klYVSLnYIMazKHyWH6tHOV1vIdB0cAZN6b073riPIhfxpwyWuiKGO N66L1IuOAVDuFSv/vq42ysEQRaufIGuggA3lPPsmXKe5i/07ZTQn8hkBV6Z+RkVYitcssXX2VVM C6fFMXr01Y7JQUqQ5cp8GAWxrudFd0UPCtp7l65LlCpPqBgQ3QOLMWbtK2iioyoMF6EkIce3eel nIhLz3qR4BNSIlfSlq5rqQbKYXk23UHQi0dJ9yD6buMM= X-Google-Smtp-Source: AGHT+IGpG5QWBCuxjBn8lkRYjkYkSzvGJ4BaudTpOzokDNqUOytSRhvV4L83yjG40igjSuF63eeWHg== X-Received: by 2002:a17:907:7e8e:b0:ae3:5d47:634 with SMTP id a640c23a62f3a-af9e1ceff40mr304544866b.9.1754894591880; Sun, 10 Aug 2025 23:43:11 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a0766e2sm1960618866b.27.2025.08.10.23.43.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Aug 2025 23:43:11 -0700 (PDT) Message-ID: Date: Mon, 11 Aug 2025 08:43:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] reset: thead: Scope TH1520 reset driver to VO subsystem To: Michal Wilczynski , Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Icenowy Zheng References: <20250810-fix_reset_2-v1-1-b0d1900ba578@samsung.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: <20250810-fix_reset_2-v1-1-b0d1900ba578@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/08/2025 23:14, Michal Wilczynski wrote: > The reset controller driver for the TH1520 was using the generic > compatible string "thead,th1520-reset". However, the current > implementation only manages the resets for the Video Output (VO) > subsystem. > > Using a generic compatible is incorrect as it implies control over all Depends, it does not need to imply that. But in general this is why we ask - and writing bindings have it documented - to post COMPLETE bindings. > reset units on the SoC. This could lead to conflicts if support for > other reset controllers on the TH1520 is added in the future like AP. > > To ensure correctness and prevent future issues, this patch renames the > compatible string to "thead,th1520-reset-vo". The device tree bindings, > the th1520.dtsi file, and the driver itself are updated to use this new, > more specific compatible. The device tree node label is also renamed > from 'rst' to 'rst_vo' for clarity. > > Fixes: 30e7573babdc ("dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller") That's not a commit from the current RC. Where is cc stable? > Reported-by: Icenowy Zheng > Signed-off-by: Michal Wilczynski > --- > Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml | 6 +++--- > arch/riscv/boot/dts/thead/th1520.dtsi | 6 +++--- > drivers/reset/reset-th1520.c | 2 +- Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > index f2e91d0add7a60e12973c216bb5a989857c3c47c..f84c5ae8bc3569cb1d4e8f07999888ea26e175d0 100644 > --- a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > @@ -16,7 +16,7 @@ maintainers: > properties: > compatible: > enum: > - - thead,th1520-reset > + - thead,th1520-reset-vo No, don't rename the compatible. That's ABI break and this was ALREADY released. That's a NAK because you break ABI for not important reason - style. > > reg: > maxItems: 1 > @@ -36,8 +36,8 @@ examples: > soc { > #address-cells = <2>; > #size-cells = <2>; > - rst: reset-controller@ffef528000 { > - compatible = "thead,th1520-reset"; > + rst_vo: reset-controller@ffef528000 { Drop the label. Why is it here in the first place? > + compatible = "thead,th1520-reset-vo"; > reg = <0xff 0xef528000 0x0 0x1000>; > #reset-cells = <1>; > }; > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > index 42724bf7e90e08fac326c464d0f080e3bd2cd59b..9cc2f1adf489ac432b2f3fbb06b655490d9e14b3 100644 > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > @@ -235,7 +235,7 @@ aon: aon { > compatible = "thead,th1520-aon"; > mboxes = <&mbox_910t 1>; > mbox-names = "aon"; > - resets = <&rst TH1520_RESET_ID_GPU_CLKGEN>; > + resets = <&rst_vo TH1520_RESET_ID_GPU_CLKGEN>; > reset-names = "gpu-clkgen"; > #power-domain-cells = <1>; > }; > @@ -500,8 +500,8 @@ clk: clock-controller@ffef010000 { > #clock-cells = <1>; > }; > > - rst: reset-controller@ffef528000 { > - compatible = "thead,th1520-reset"; > + rst_vo: reset-controller@ffef528000 { > + compatible = "thead,th1520-reset-vo"; > reg = <0xff 0xef528000 0x0 0x4f>; > #reset-cells = <1>; > }; > diff --git a/drivers/reset/reset-th1520.c b/drivers/reset/reset-th1520.c > index 7874f0693e1b427a094a68f2b6d783985e789bf8..05ed11972774618df4512b7c9f9f12e71455e48b 100644 > --- a/drivers/reset/reset-th1520.c > +++ b/drivers/reset/reset-th1520.c > @@ -116,7 +116,7 @@ static int th1520_reset_probe(struct platform_device *pdev) > } > > static const struct of_device_id th1520_reset_match[] = { > - { .compatible = "thead,th1520-reset" }, > + { .compatible = "thead,th1520-reset-vo" }, NAK, actual ABI break. Best regards, Krzysztof