From: Nikolay Borisov <nborisov@suse.com>
To: YueHaibing <yuehaibing@huawei.com>,
clm@fb.com, David Sterba <dsterba@suse.com>,
josef@toxicpanda.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] btrfs: Make inc_block_group_ro static
Date: Tue, 27 Aug 2019 16:48:34 +0300 [thread overview]
Message-ID: <d3e3b582-00a2-3006-9510-712748bd092e@suse.com> (raw)
In-Reply-To: <20190827134312.15216-1-yuehaibing@huawei.com>
On 27.08.19 г. 16:43 ч., YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/block-group.c:1183:5: warning:
> symbol 'inc_block_group_ro' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/block-group.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
> index 3147e84..8cc7768 100644
> --- a/fs/btrfs/block-group.c
> +++ b/fs/btrfs/block-group.c
> @@ -1180,7 +1180,7 @@ struct btrfs_trans_handle *btrfs_start_trans_remove_block_group(
> * data in this block group. That check should be done by relocation routine,
> * not this function.
> */
> -int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
> +static int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
> {
> struct btrfs_space_info *sinfo = cache->space_info;
> u64 num_bytes;
>
prev parent reply other threads:[~2019-08-27 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 13:43 YueHaibing
2019-08-27 13:48 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e3b582-00a2-3006-9510-712748bd092e@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®