From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A93FC00449 for ; Fri, 5 Oct 2018 07:55:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21FB72084D for ; Fri, 5 Oct 2018 07:55:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21FB72084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728039AbeJEOwc (ORCPT ); Fri, 5 Oct 2018 10:52:32 -0400 Received: from mga07.intel.com ([134.134.136.100]:40368 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727329AbeJEOwc (ORCPT ); Fri, 5 Oct 2018 10:52:32 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 00:55:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,343,1534834800"; d="scan'208";a="89396000" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 05 Oct 2018 00:55:00 -0700 Received: from [10.125.251.251] (abudanko-mobl.ccr.corp.intel.com [10.125.251.251]) by linux.intel.com (Postfix) with ESMTP id 21FF858038C; Fri, 5 Oct 2018 00:54:57 -0700 (PDT) Subject: Re: [PATCH v9 3/3]: perf record: extend trace writing to multi AIO To: Namhyung Kim Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Andi Kleen , linux-kernel , kernel-team@lge.com References: <6cf496d7-60b6-2ba3-7c40-26caeec81837@linux.intel.com> <20181005072248.GD3768@sejong> From: Alexey Budankov Organization: Intel Corp. Message-ID: Date: Fri, 5 Oct 2018 10:54:57 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181005072248.GD3768@sejong> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 05.10.2018 10:22, Namhyung Kim wrote: > On Wed, Oct 03, 2018 at 07:17:01PM +0300, Alexey Budankov wrote: >> @@ -1833,6 +1861,10 @@ static struct option __record_options[] = { >> "signal"), >> OPT_BOOLEAN(0, "dry-run", &dry_run, >> "Parse options then exit"), >> +#ifdef HAVE_AIO_SUPPORT >> + OPT_INTEGER(0, "aio-cblocks", &record.opts.nr_cblocks, >> + "Max number of simultaneous per-mmap trace writes (default: 0 - serial, max: 4)"), >> +#endif >> OPT_END() >> }; > > Please update the documentation for the new option and config Accepted. > variable. Perhaps it can provide the option always and check the > availability at runtime (with a warning message if not enabled). Not sure if this complication is really required. So far NO_AIO define is possible at compile time. Thanks, Alexey