From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010017.outbound.protection.outlook.com [52.101.46.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B27341E4AB for ; Sat, 6 Dec 2025 03:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764991870; cv=fail; b=f5jPVZUd1jdo3+DBWKsdHdVbKkH+YEDp84U9CrU0zRO2IFad+kxEhaCI+NxkghMVU13+w37OBHBRug8rtE6dp3HPkAeHL2jWc0Wzr8tIrjW8usgFqrc8qwr0D//VKjhXHqBb/NEfMJt7TwxvMWMCzyPKPMAel0IneMtDx0W6Jg8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764991870; c=relaxed/simple; bh=JhjTTzBcTOWupikg9Lh+sE9f/opQgtJ69WLOiZn0FHE=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=a1D49K/z3jJTacy8n+uvf90J+/TZPLv2nUMN25UkwqwsiInfzUhD6XqO9WYuI1lmf6wnnBCsQDpOH8CmKGoLflJL8ALvGX1GBfNKBQLWDcEJUapDkFC+C9RMp9l3K36ljpsw8AqPsujDuXGmQXwD5aO4z3VJFWUkGyrcBMG5ojI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lV+UbfQI; arc=fail smtp.client-ip=52.101.46.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lV+UbfQI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oxES5kZmMrMHx+28gWORH9Qhvoktw9B5gVKViLof2mwKdy53DofgE/Y63wvxO8fJSPA+wOMT81zkemBi8QFC2JFvnTEyDe50GOU4AGShplG5Q8mI/Dh7YTY6PJYwhk3W4qfvQc1//bb3BqUZjNHbx5NThg7KF57A5M+lOgW3k6hyxEUbNEPXAwrwB+pJqjH/cUP8HD5tymqRxEcgBb5yabc2AscZBVvK97OI4hgUi8/CQp+5yNcXoeJshGgVTR6QOjAgouZLAwMdm04kHe4kkBKAo54vlP5IpqeBh2PPlrEdgxljr09KIcWz3cqBTe3wnqmjXAcGxXqwjeged0CQbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TWNVYsXiqgZoxYLVBrX2kDwqObXYZVv3XF+zRax3SyQ=; b=AhRhDeMRXv7EIPahUCtJvFltlr8nr6+zqQ0Y2DqmbUM46oBu69AlgUlz+Ux9s6taawnvR1B8BhICNGhxc7pdg/lkyANPPjzYov2CHHnMN1tPbJgDB7nAlwu8N3wvAAZU7IIT4iM8CoqTQjp5L6Q9VZOjTN9GQnHjnxCVdg3CNZzczL6PyNFSUJF0xyvHK6FbZqRlQWMF1yqYu8oFbd3DmdpKvkZ9SAYOfgEBwDuodzxzwZc7Y6ILU7lMVUaypwIM7JcLKxNcTr07u5Ob2zcARXJeeP5NoaO1YUCjBLKThG74einF7w37TLdvg6bDDb6Neic//2vim8Ze94/0cWwxUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TWNVYsXiqgZoxYLVBrX2kDwqObXYZVv3XF+zRax3SyQ=; b=lV+UbfQIGOuazB8q6rrlfJ24KbavqlDmgWVfUqsUArQEIjwrgcrTz6UR7EvZFwQpwNkcyarrBiD/0iZ8W1XTOIUR8sPgbijAjBIOTOujwUUgKlForIh4WIOJzd+iWSzBTGzo2yn2R1jWzHGGv66NZam5oH3XAUP1c4nUiJAlpzAip24Bz4ai4rb1WB40HC/FnTQAwquj8mBg4H/i82XN1J6LNu/FkEHaTsUbEYWFeGgSgFr2pX5t8L8FtpiEWJIel9FV91dQUIJSSjKumDmh72niJqKDEP7jehNvK3Y+jAGjFu2A1LBiembphFPThZ57Edvn+oAbnsmuO8vN2LAnSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB2667.namprd12.prod.outlook.com (2603:10b6:5:42::28) by SN7PR12MB7936.namprd12.prod.outlook.com (2603:10b6:806:347::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Sat, 6 Dec 2025 03:31:00 +0000 Received: from DM6PR12MB2667.namprd12.prod.outlook.com ([fe80::bd88:b883:813d:54a2]) by DM6PR12MB2667.namprd12.prod.outlook.com ([fe80::bd88:b883:813d:54a2%6]) with mapi id 15.20.9388.003; Sat, 6 Dec 2025 03:31:00 +0000 Message-ID: Date: Fri, 5 Dec 2025 19:30:58 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] x86/resctrl: Add missing resctrl initialization for Hygon To: Xiaochen Shen , tony.luck@intel.com, reinette.chatre@intel.com, bp@alien8.de Cc: babu.moger@amd.com, james.morse@arm.com, Dave.Martin@arm.com, x86@kernel.org, linux-kernel@vger.kernel.org References: <20251204023750.994143-1-shenxiaochen@open-hieco.net> <20251204023750.994143-2-shenxiaochen@open-hieco.net> Content-Language: en-US From: Fenghua Yu In-Reply-To: <20251204023750.994143-2-shenxiaochen@open-hieco.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY5PR17CA0007.namprd17.prod.outlook.com (2603:10b6:a03:1b8::20) To DM6PR12MB2667.namprd12.prod.outlook.com (2603:10b6:5:42::28) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2667:EE_|SN7PR12MB7936:EE_ X-MS-Office365-Filtering-Correlation-Id: 40ed53af-22bb-450d-b190-08de3477e037 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWxYNFMzSzJxcE5rS2lieHZyRUdsVjQyS2RlRnNVcXFZQkp6c0xMa2ZBN3dL?= =?utf-8?B?S2hoVEp4eGwrT21qN2E4Z0ViSHk1TkNvei9raEo0WkRZYnZzUmpGZkllbHlr?= =?utf-8?B?SWtvOFd0WWRKd29DTUxDVWRLc3pPU2Y3YVFRQmZUZ2dmVUx2N1l0QmJHTGc4?= =?utf-8?B?a09QU0REWFlhdUVFZnlWdlFEV0xzOSs1RDN2eE5kd2NOZVBQb2IwUlUwbElm?= =?utf-8?B?VjJmU3ZHTG5ONGxJZmsyeGpPS1h3ZDRzQVozWmc1R0FoSG0wK0liNE85a3hI?= =?utf-8?B?NzV0WHVybTE2RTFDWngreTJZOTB6ZlE2bDR6NTRhMGZHV1FLejJTMitkQ2Vv?= =?utf-8?B?anU5ZzFIVGpucnVHRUtJVExtOUs0SUpJdzVNdFJBL20rYzZWajlnUThTaFlz?= =?utf-8?B?ZGpVWUx5Mlg5bWhtY0p4V2wwMTlCeTczV053eWpBdUcwUmZlRmc0T0RqTDR6?= =?utf-8?B?ZlFnQzB2anlJRWJHZkwyT3F0dmxxVU5yaDkwQXFkZkQ3L1pob1U3eXJFU3ZU?= =?utf-8?B?YnJxTmRnc1puNGlodDlEUHhkMjNQQWJvR2cxdjk0NUMxR0kwQ1h5YUFVV3hh?= =?utf-8?B?NWI1UFVhZjJLSXdhbDN5c0xkdU9MWnV1RWtOa1p1ZGdVckJibk9OSGF4Sjlv?= =?utf-8?B?dmRLdDhXSG1qUkRoVkVVQitmTmUyUDY0NEhmTkZrVkVhZGNzcEFpVzQ3N1hJ?= =?utf-8?B?ckNmYTQ0KzhHVWR3aXpNUXB4aG1maVBtM2pRcUlCMTVXdmhtU1pUUUp5dFhs?= =?utf-8?B?VllNUGxSdzF3TElHNkRtOWpoc3pqRURNT041YWpaVndsMnU0MkswMnZXYkh1?= =?utf-8?B?RHRsRU5LTTdFUm5EU1JIRStQUlVYMmVKMnp1UlB6ZEJIT05veUdYb2tvQmUw?= =?utf-8?B?akw2WVd2UkszR3JTTmFKTXlla1ZENWF2VTUvUjRQL2tTanVTc0t1R2p3aWN0?= =?utf-8?B?dTBwTndmWUxTZ3diMHBvVDMvbXNXM1pNdDhMQUF4T2dLckRuMGQ0VjZiVURK?= =?utf-8?B?aVBqRFVmSXErbWp1andLeXdyYzI0dSt0elpyRHBiblNCTXZJc0NyZnBDZ1l4?= =?utf-8?B?eVVnMExvM29rZktHYUFrdldaVVZBZTJ1Ylp2dnVsNU1TY0piNTgxN3BtMVAz?= =?utf-8?B?YmVjMG1JR3g0TGR4bmd0cDZTNEY0clF2ckVTY1lWWlY3OWdrdmdHaFBic1d6?= =?utf-8?B?ZDVwTGhhbjFhUUJ1RWxNem9lTGRxY2gzSlMvNzZ1aHBzS0F4b3krUk1KbDkz?= =?utf-8?B?c2dCVmduMTRINVF2UW5QQUZhZkE0VTkrRjlZcjdyakVpMFh3aG9rSkZxalVT?= =?utf-8?B?MWIrVGRVWnNSeVZXbVB4QmMzQ1FOVXMwV1FPdDEwT3pyK0VQWFMvRjZtbndv?= =?utf-8?B?N1NIRVhEUUppakd6RHplT2FGWER1TU41V0UxYm9jdVMwNTV6Z01WZnRYeVlu?= =?utf-8?B?V0pnS0JUaTFuMFZ6SjhTdmVzMTJjQWk0aGVnWmpPUnNRV05rTnVFd0Q5OTJP?= =?utf-8?B?VmRGUElHOENRbXdVaXZ5Z0lQVEpaNUQvYU9rS25XUVF2REkrSGtraFVscGE3?= =?utf-8?B?UldLZ0ZEOXBCZENSaUFPMXl3Z3oxVDE4d3J1c3RtL05qdStYZ0dsQ0ZuNHVj?= =?utf-8?B?TjRyQ1hGZ21hYnNpOFViSUd3SVhSTCtHUlNYQ2hvc1ljaW14THBBVE0xWmRK?= =?utf-8?B?YkxvVjM3OTF6eEl4M3V6ZWtOR2dnKzZXdXIwYXBwKzlzZncxTThPQS9KZEpL?= =?utf-8?B?S2FVNVJiL05qbXkvcVdVbjBkQnJUTG1wZWNTZWkvSVVoT2xYcjkyVGZxcWFC?= =?utf-8?B?K1dLemdRcEhHc2R3eUU2ZGc3NHZuM1J0YnNpY1NlelRtOTN4SjBBenhjQUIy?= =?utf-8?B?SnF3Zms3RThzZzZNb0xGbXFKNHNqN3ZGUHhGdXUzQ1BSZ2xZeGZicEdMOGpr?= =?utf-8?Q?YzzOckhWauVOXAJd+FEVk8Q4HMr94hs9?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlVJaVFmajdzdjl0SU4rem9iK3BObklVUmJSUXRFS01TUUNUTjdsNGRHL2lP?= =?utf-8?B?TkNmTVJHK212WDcwZmh4Wlp6V0l5SXErWExKbmIrYTNOTlFYRGVESkE5QTF2?= =?utf-8?B?Njc4dU50eFFMVGg5bkc0RXp2Vk5nRW1vWTFBSm5UdjcvRDNHbm1nWXhWR3Zj?= =?utf-8?B?NEpoWG5Sc1ZLWC9qZzV2Y29pcGs3ZnliQjlJbW1FZlA0dk04Y2NIRVZudE5S?= =?utf-8?B?UVFQaThBRDFISzMwNUw3MUxxb3FvSWcwS1I0eUx1Z3NNSkFSNU5ITjZLMGtt?= =?utf-8?B?RGViZ2xMdk9WUjZNb1lhR2lmWWlmM2lyeXJOT0tKYVRTZEtoeWdmSHYza1ZU?= =?utf-8?B?ZVBoVVIyeng3N3NkRHM5R0UvNlhsRGFzNkRqdlBKSXJwNXRRY0tMYXR5bUFm?= =?utf-8?B?Ni8wUmhQK1R6a3JZdnhyQUpCK3E2QmIveXBCdDEzbGlVeUJUY0Jqa0lCTitI?= =?utf-8?B?Kyt6dldqUjRnT0N6cFA1VnB3enY1WkZTdmdWQjBndllVejd0dklFQjduU1Zt?= =?utf-8?B?cWVXQU1hME1PTHF4UDZBOWRXdmRVQWo0SCs0dTFmTGZEZTNwZlNyWW84a2gv?= =?utf-8?B?SE1yN0dUUFJNdFBTREdMa0FRNnYrb1dHcVQyOTNBVnhKSFZ6SVVoeHVsREIv?= =?utf-8?B?b2todFNGTlRrWGR5RFpyVEM5ZDVIWmh5dHRtL3VsclhjTS80RlQwSXl3NFcv?= =?utf-8?B?cWZ3OUpHSkJ0SWpHeUl5TktVa2ZmVHZZQTYwcDBSNSs0dDduZ1pSQjFFWUNq?= =?utf-8?B?Zkdwblc5QXkwbjlQOW4zeVY4bXZ3UHY2SVIvTjFVRms2clM5T09ybWF1Z3Bl?= =?utf-8?B?eS9WMGpHRkpROXpta0ZHZndQb3hJNExIQ3pWSkU0NmxjekZGK0g1aklnZ0Vj?= =?utf-8?B?QkxsTXVrbzBaaTB5WHQzWk9EQjhQRHh3TTR2K0ZjdG9GVzdxSWtkZEJFcjhw?= =?utf-8?B?c0FPOUxIMnlIbXRqWkxqUGJLL3RzMTd5T2dGYlg2ZzBHeVRmT2JkaVVXcUtI?= =?utf-8?B?YUhlbks4bWxUQXB5bFZHblNob1oyY25OdzZOOUdocW83UGtKWU1RcXluOEZn?= =?utf-8?B?WTNRdVQwT0laZjM4RmprbnV2ZWFjbGRKNUl4cmJRNkJDOWZ2Q1duemZvdksv?= =?utf-8?B?R2F5Nis2TXFBY04rMkNMeDdmbmVLSERaVlZtVzd0QnozVmNFNmsxejVQS0J5?= =?utf-8?B?ZThHeTczSlZXWjY4SXYzd21CRmw0b3Vhd05OWmwwdmxlcG1vNEFBblhMdzFw?= =?utf-8?B?eWN6Nzc3djlIOEN4OUhhYndxMTI4MzUxZSs5NTJrczJPQWIxTFdIajZOUzIy?= =?utf-8?B?SWRGRTlFZ2pqRWt2NVQwRTc4ZFR0c0dZQ1V3MitETjR6L0xLWHRJT0RYVVVt?= =?utf-8?B?dGZUWmlUalR2TmtJYk9RNTdoTkFUVkN3MkpsWGFXa2h3cVIyNDBXL2FPSUpY?= =?utf-8?B?WGRhQk1oYnJkVExZQXpFUjNLK3pyTDNKZkRjSGltRjdCMnR4NDNkdDg4d3Zh?= =?utf-8?B?TlZRL1d5TzMzRThHcXZ5M0ZKSFljaWNMQTVJb3o5Q3dWZGFLeTFOUzNGYWx6?= =?utf-8?B?enFCbDRqU254SDdUbnVUS2RYS3FZUFJvaGdoSmtXU0RGRGhvNlBlR3Q4akha?= =?utf-8?B?NEZ4SXhibzM5UGd3Z1NsRWIrcE5oWEpEcGtFZGZiNll3SzAyZ3NIMmRKQ1Nu?= =?utf-8?B?U0FNdnNoWFJrZitPcWEyeXdxenFMVFFNYm5lQWpWdmVVVGErUkdkK0JWQUlq?= =?utf-8?B?bEQ3T1I4aC9WZUZEUjZSRzMzZy9FMXBvTTF4M3lDMXZTQkFML3oyMnBkcTRV?= =?utf-8?B?MEkzdjRvU044T0R0N1FGNDVIcWM2RU5hOVEyODlPUlc3THBCNjZPY21aeUc2?= =?utf-8?B?MXU2KzBEd051NC9oa0Z6NFM1M05hT05SZE5WQ0s0ZUZMcW1VbjVuY0ZRSzNV?= =?utf-8?B?VGtJRGJHM1A4VEtOZFNFa0JhQmF4RHhFeWxuWjYrbmMwSjhWYWJTNGM2cWdI?= =?utf-8?B?eTdGdDY0QU1zZVRRUTB4R1hmOEd0VkVwbTFkcW5RRUlGWHpMOFhvTWhOYmt6?= =?utf-8?B?RXk2cmJVT090OXNFbk5ZZjJzQmVuQjdsOEJyaThBYXRySHdmSzB4a1AxR0ZW?= =?utf-8?Q?0hFjTKqlQC7+4kSCJ0G1UIL6m?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40ed53af-22bb-450d-b190-08de3477e037 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2025 03:31:00.2285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SHST5HHpwpoceyt+orhuodEigRIIKs32NHpVRfEXsbzPEUQzdTNOPPC+nohoqFHPpA2kTPxW8PxvgMs0dfJPmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7936 Hi, Xiaochen, On 12/3/25 18:37, Xiaochen Shen wrote: > Hygon CPUs supporting Platform QoS features currently undergo partial > resctrl initialization through resctrl_cpu_detect() in the Hygon BSP > init helper and AMD/Hygon common initialization code. However, several > critical data structures remain uninitialized for Hygon CPUs in the > following paths: > > - get_mem_config()-> __rdt_get_mem_config_amd(): > rdt_resource::membw,alloc_capable > hw_res::num_closid > > - rdt_init_res_defs()->rdt_init_res_defs_amd(): > rdt_resource::cache > hw_res::msr_base,msr_update > > Add the missing AMD/Hygon common initialization to ensure proper > Platform QoS functionality on Hygon CPUs. > > Fixes: d8df126349da ("x86/cpu/hygon: Add missing resctrl_cpu_detect() in bsp_init helper") This commit triggers the issue on Hygon. You may keep this fix. > Fixes: 923f3a2b48bd ("x86/resctrl: Query LLC monitoring properties once during boot") This commit just calls resctrl_cpu_detect() on AMD and Intel. The commit itself doesn't have an issue. Remove this Fixes? > Cc: stable@vger.kernel.org > Signed-off-by: Xiaochen Shen > --- > arch/x86/kernel/cpu/resctrl/core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c > index 3792ab4819dc..10de1594d328 100644 > --- a/arch/x86/kernel/cpu/resctrl/core.c > +++ b/arch/x86/kernel/cpu/resctrl/core.c > @@ -825,7 +825,8 @@ static __init bool get_mem_config(void) > > if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) > return __get_mem_config_intel(&hw_res->r_resctrl); > - else if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) > + else if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD || > + boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) > return __rdt_get_mem_config_amd(&hw_res->r_resctrl); > > return false; > @@ -987,7 +988,8 @@ static __init void rdt_init_res_defs(void) > { > if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) > rdt_init_res_defs_intel(); > - else if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) > + else if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD || > + boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) > rdt_init_res_defs_amd(); > } > Thanks. -Fenghua