From: David Hildenbrand <david@redhat.com>
To: Barry Song <21cnbao@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org
Cc: justinjiang@vivo.com, chrisl@kernel.org, hughd@google.com,
kaleshsingh@google.com, kasong@tencent.com,
linux-kernel@vger.kernel.org, ryan.roberts@arm.com,
v-songbaohua@oppo.com, ying.huang@intel.com
Subject: Re: [PATCH v2 1/2] mm: rename instances of swap_info_struct to meaningful 'si'
Date: Wed, 7 Aug 2024 11:11:33 +0200 [thread overview]
Message-ID: <d3f1ab88-b9b5-4a35-93c8-9257782a2517@redhat.com> (raw)
In-Reply-To: <20240807082508.358322-2-21cnbao@gmail.com>
On 07.08.24 10:25, Barry Song wrote:
> From: Barry Song <v-songbaohua@oppo.com>
>
> "P" means "pointer to something", rename it to a more meaningful
> identifier - "si".
> We also have a case with the name "sis", rename it to "si" as
> well.
>
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
> mm/swapfile.c | 334 +++++++++++++++++++++++++-------------------------
> 1 file changed, 167 insertions(+), 167 deletions(-)
It's a bit of churn but all straight forward. No opinion against it from
my side.
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-08-07 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 8:25 [PATCH v2 0/2] mm: batch free swaps for zap_pte_range() Barry Song
2024-08-07 8:25 ` [PATCH v2 1/2] mm: rename instances of swap_info_struct to meaningful 'si' Barry Song
2024-08-07 9:11 ` David Hildenbrand [this message]
2024-08-07 8:25 ` [PATCH v2 2/2] mm: attempt to batch free swap entries for zap_pte_range() Barry Song
2024-08-07 9:28 ` David Hildenbrand
2024-08-07 9:48 ` Barry Song
2024-08-07 10:19 ` David Hildenbrand
2024-08-07 16:16 ` Kairui Song
2024-08-07 19:14 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f1ab88-b9b5-4a35-93c8-9257782a2517@redhat.com \
--to=david@redhat.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=hughd@google.com \
--cc=justinjiang@vivo.com \
--cc=kaleshsingh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®