From: Hans de Goede <hdegoede@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 04/12] usb: common: Small class for USB role switches
Date: Sun, 25 Feb 2018 13:16:26 +0100 [thread overview]
Message-ID: <d3f1d350-95f6-91f2-b67f-c2823f76d898@redhat.com> (raw)
In-Reply-To: <90191d89-0881-3486-87f9-59b355824927@infradead.org>
Hi,
On 16-02-18 19:33, Randy Dunlap wrote:
> On 02/16/2018 02:47 AM, Hans de Goede wrote:
>> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>>
>
>> diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
>> new file mode 100644
>> index 000000000000..923e3721d183
>> --- /dev/null
>> +++ b/drivers/usb/common/roles.c
>> @@ -0,0 +1,305 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/**
>
> Just use /* since this is not kernel-doc notation.
Thank you for catching this, fixed for v2.
Regards,
Hans
>
>> + * USB Role Switch Support
>> + *
>> + * Copyright (C) 2018 Intel Corporation
>> + * Author: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> + * Hans de Goede <hdegoede@redhat.com>
>> + */
>
>
next prev parent reply other threads:[~2018-02-25 12:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 10:47 [PATCH 00/12] USB Type-C device-connection, mux and switch support Hans de Goede
2018-02-16 10:47 ` [PATCH 01/12] drivers: base: Unified device connection lookup Hans de Goede
2018-02-16 11:00 ` Andy Shevchenko
2018-02-16 11:21 ` Hans de Goede
2018-02-16 11:28 ` Heikki Krogerus
2018-02-16 10:47 ` [PATCH 02/12] usb: typec: Start using ERR_PTR Hans de Goede
2018-02-16 11:07 ` Andy Shevchenko
2018-02-16 11:21 ` Hans de Goede
2018-02-16 10:47 ` [PATCH 03/12] usb: typec: API for controlling USB Type-C Multiplexers Hans de Goede
2018-02-16 14:00 ` Andy Shevchenko
2018-02-25 12:13 ` Hans de Goede
2018-02-16 10:47 ` [PATCH 04/12] usb: common: Small class for USB role switches Hans de Goede
2018-02-16 14:07 ` Andy Shevchenko
2018-02-16 14:22 ` Heikki Krogerus
2018-02-19 9:32 ` Hans de Goede
2018-02-25 12:16 ` Hans de Goede
2018-02-16 18:33 ` Randy Dunlap
2018-02-25 12:16 ` Hans de Goede [this message]
2018-02-16 10:47 ` [PATCH 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such Hans de Goede
2018-02-16 13:19 ` Heikki Krogerus
2018-02-16 10:47 ` [PATCH 06/12] usb: typec: tcpm: Use new Type-C switch/mux and usb-role-switch functions Hans de Goede
2018-02-16 13:20 ` Heikki Krogerus
2018-02-16 10:47 ` [PATCH 07/12] xhci: Add option to get next extended capability in list by passing id = 0 Hans de Goede
2018-02-16 13:21 ` Heikki Krogerus
2018-02-16 10:47 ` [PATCH 08/12] xhci: Add Intel extended cap / otg phy mux handling Hans de Goede
2018-02-16 13:32 ` Heikki Krogerus
2018-02-16 13:53 ` Andy Shevchenko
2018-02-25 13:01 ` Hans de Goede
2018-02-16 10:47 ` [PATCH 09/12] usb: roles: Add Intel XHCI USB role switch driver Hans de Goede
2018-02-16 13:38 ` Heikki Krogerus
2018-02-25 12:11 ` Hans de Goede
2018-02-16 13:47 ` Andy Shevchenko
2018-02-25 13:29 ` Hans de Goede
2018-02-16 10:47 ` [PATCH 10/12] usb: typec: driver for Pericom PI3USB30532 Type-C cross switch Hans de Goede
2018-02-16 13:33 ` Andy Shevchenko
2018-02-16 13:43 ` Heikki Krogerus
2018-02-16 10:47 ` [PATCH 11/12] platform/x86: intel_cht_int33fe: Add device connections for the Type-C port Hans de Goede
2018-02-16 13:10 ` Andy Shevchenko
2018-02-16 13:43 ` Heikki Krogerus
2018-02-16 10:47 ` [PATCH 12/12] extcon: axp288: Set USB role where necessary Hans de Goede
2018-02-16 13:19 ` Andy Shevchenko
2018-02-25 13:49 ` Hans de Goede
2018-02-16 13:45 ` Heikki Krogerus
2018-02-16 13:36 ` [PATCH 00/12] USB Type-C device-connection, mux and switch support Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2018-02-16 10:43 [PATCH 0/12] " Hans de Goede
2018-02-16 10:43 ` [PATCH 04/12] usb: common: Small class for USB role switches Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f1d350-95f6-91f2-b67f-c2823f76d898@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=cw00.choi@samsung.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®