From: Lin Ming <lin@minggr.cn>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: wrong acpi_parse_state assigned acpi_ps_init_scope() ?
Date: Fri, 15 Jan 2010 09:47:14 +0800 [thread overview]
Message-ID: <d3f22a1001141747p25b3406fv55364be65002546b@mail.gmail.com> (raw)
In-Reply-To: <4B4FB766.1020805@gmail.com>
On Fri, Jan 15, 2010 at 8:31 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> Assign the package end, not the last AML byte.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Is this right?
>
> diff --git a/drivers/acpi/acpica/psscope.c b/drivers/acpi/acpica/psscope.c
> index 2feca5c..a8dfe16 100644
> --- a/drivers/acpi/acpica/psscope.c
> +++ b/drivers/acpi/acpica/psscope.c
> @@ -118,7 +118,7 @@ acpi_ps_init_scope(struct acpi_parse_state * parser_state,
> scope->parse_scope.op = root_op;
> scope->parse_scope.arg_count = ACPI_VAR_ARGS;
> scope->parse_scope.arg_end = parser_state->aml_end;
> - scope->parse_scope.pkg_end = parser_state->aml_end;
> + scope->parse_scope.pkg_end = parser_state->pkg_end;
->aml_end and ->pkg_end are same here.
acpi_ps_init_scope is only called in acpi_ds_init_aml_walk which set
aml_end and pkg_end the same.
acpi_ds_init_aml_walk(...)
{
....
walk_state->parser_state.aml_end =
walk_state->parser_state.pkg_end = aml_start + aml_length;
.....
status = acpi_ps_init_scope(&walk_state->parser_state, op);
.....
}
Lin Ming
>
> parser_state->scope = scope;
> parser_state->start_op = root_op;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2010-01-15 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 0:31 Roel Kluin
2010-01-15 1:47 ` Lin Ming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f22a1001141747p25b3406fv55364be65002546b@mail.gmail.com \
--to=lin@minggr.cn \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®