From: Andrew Lunn <andrew@lunn.ch>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v5 2/3] ethtool: add a PHY receive byte total
Date: Mon, 16 Nov 2026 05:39:55 +0100 [thread overview]
Message-ID: <d3f2dc1c-9daf-4b5f-903b-657ae3f32647@lunn.ch> (raw)
In-Reply-To: <CADvTj4qh8Pvss+xEwcjshodwv-yN6haP-9aaeRXg1ydSu5ibVg@mail.gmail.com>
On Sun, Nov 15, 2026 at 09:12:35PM -0700, James Hilliard wrote:
> On Sun, Nov 15, 2026 at 8:25 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Sun, Nov 15, 2026 at 12:45:46AM -0700, James Hilliard wrote:
> >
> > > The generic PHY receive-byte counter describes successfully received
> > > traffic. Some PHYs instead count bytes in all received frames,
> > > including frames with errors.
>
> That restriction comes from the current kernel-doc definition of
> ethtool_phy_stats.rx_bytes: "Total successfully received bytes".
Yes, i found this.
> Should we instead clarify the existing rx_bytes definition to include
> errored traffic and use it for ACx00, dropping rx_bytes_total? That
> would leave the existing packet counters unchanged.
What do you mean by errored traffic?
Think about it.
If you don't have a MAC, you don't have FCS.
Andrew
next prev parent reply other threads:[~2026-11-16 4:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 7:45 [PATCH net-next v5 0/3] net: phy: report ACx00 receive statistics James Hilliard
2026-11-15 7:45 ` [PATCH net-next v5 1/3] docs: networking: correct the PHY statistics group name James Hilliard
2026-11-15 15:01 ` Andrew Lunn
2026-11-15 7:45 ` [PATCH net-next v5 2/3] ethtool: add a PHY receive byte total James Hilliard
2026-11-15 15:25 ` Andrew Lunn
2026-11-16 4:12 ` James Hilliard
2026-11-16 4:39 ` Andrew Lunn [this message]
2026-11-16 4:56 ` James Hilliard
2026-11-15 7:45 ` [PATCH net-next v5 3/3] net: phy: acx00: report receive statistics James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f2dc1c-9daf-4b5f-903b-657ae3f32647@lunn.ch \
--to=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®