From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50AE26F30F for ; Wed, 2 Apr 2025 14:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743602783; cv=none; b=H/k//ig47hfjagu0FDrIW+8aQBjLVcJV61ft1AN5GbtEqhQ28lrvVNt8ZNESzAl2srjHoWkg/i2HYetmyPyWZaNYpmKz6V8nygigPsVlbfYn+y0mhRRUDLO2RZ404iwd0587Tih4S8TBbE5Z68J5GQNvx0zAHKGjgJPBGi5GSDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743602783; c=relaxed/simple; bh=43yCaCwbhhwLAjYEKpYoAbta2guzQ6EG9XK1vyidZSY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NX5Y/ad7KOZYU8S62bsXSz/h9uRwZegLCnqQgmcaZ0G4zITpRWv5KcgiQGIVFw+eMngAdHDffIWydrkVt+ic24ZrMQieZbS691D6TPwnR+Dyu2jLGSHzEmmZITeIIkn1LfO14avTTHwZaDPAWdPZgOdvjXUaiGftqlt3XYsbmoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uHAvHlMU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uRGyNfEK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uHAvHlMU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uRGyNfEK; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uHAvHlMU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uRGyNfEK"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uHAvHlMU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uRGyNfEK" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5D35F2119A; Wed, 2 Apr 2025 14:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743602779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UwVUhdlYTIPsRFnJXKzm8rQ2XZbwVn7BV/kDQ+KUUbo=; b=uHAvHlMUBgfdKyqrmmNu2h6hAMmo3ltSJEoBpUuO6eGtJWDcRRBDPAwY11LomrU4a41Mms rDzqUTErNFWrlbhb7MllFi7JnfQDh6AYFINnfr0Y2MeC1gM0GuKrHyldyZY7rcBJBkcGxD 3ZV0TEH2k0oM3zPuhcbXYRbtwLzBIMU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743602779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UwVUhdlYTIPsRFnJXKzm8rQ2XZbwVn7BV/kDQ+KUUbo=; b=uRGyNfEKoEM4z2TsLayc+dXXpeN9+o5Jv+yitLjxsBMLFDEethf498MJsijJzM4yMZxpew dzqQnHN4NalSrVDA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uHAvHlMU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=uRGyNfEK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743602779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UwVUhdlYTIPsRFnJXKzm8rQ2XZbwVn7BV/kDQ+KUUbo=; b=uHAvHlMUBgfdKyqrmmNu2h6hAMmo3ltSJEoBpUuO6eGtJWDcRRBDPAwY11LomrU4a41Mms rDzqUTErNFWrlbhb7MllFi7JnfQDh6AYFINnfr0Y2MeC1gM0GuKrHyldyZY7rcBJBkcGxD 3ZV0TEH2k0oM3zPuhcbXYRbtwLzBIMU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743602779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UwVUhdlYTIPsRFnJXKzm8rQ2XZbwVn7BV/kDQ+KUUbo=; b=uRGyNfEKoEM4z2TsLayc+dXXpeN9+o5Jv+yitLjxsBMLFDEethf498MJsijJzM4yMZxpew dzqQnHN4NalSrVDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 19C5D13A4B; Wed, 2 Apr 2025 14:06:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9uMeBVtE7WebIwAAD6G6ig (envelope-from ); Wed, 02 Apr 2025 14:06:19 +0000 Message-ID: Date: Wed, 2 Apr 2025 16:06:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/18] nvmet-fcloop: replace kref with refcount To: Daniel Wagner Cc: Daniel Wagner , James Smart , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250318-nvmet-fcloop-v3-0-05fec0fc02f6@kernel.org> <20250318-nvmet-fcloop-v3-2-05fec0fc02f6@kernel.org> <709b524c-7191-451f-81ea-8bad8f1c6a16@flourine.local> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <709b524c-7191-451f-81ea-8bad8f1c6a16@flourine.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5D35F2119A X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; FUZZY_BLOCKED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -4.51 X-Spam-Flag: NO On 4/2/25 16:03, Daniel Wagner wrote: > On Tue, Mar 18, 2025 at 11:56:50AM +0100, Hannes Reinecke wrote: >> On 3/18/25 11:39, Daniel Wagner wrote: >>> The kref wrapper is not really adding any value ontop of refcount. Thus >>> replace the kref API with the refcount API. >>> >>> Signed-off-by: Daniel Wagner >>> --- >>> drivers/nvme/target/fcloop.c | 37 +++++++++++++------------------------ >>> 1 file changed, 13 insertions(+), 24 deletions(-) >>> >> Can you split this in two, one for the nport and one for fcpreq? >> That way it's easier to follow what has been modified. > > Do you still want me to split the patch? You and Christoph have sent the > Reviewed-by tag after this review. Ah, no, Don't bother. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich